glusterfs.git/xlators/protocol, branch v3.9.1

client,server: Free xdr-allocated compound req/rsp arrays

2016-12-22T13:44:52+00:00

        Backport of: http://review.gluster.org/16210

Change-Id: If757ffc08d07aef6532e9087392258002b24847a
BUG: 1406308
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/16222
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra G

protocol/client: Fix potential mem-leaks

2016-12-21T06:55:03+00:00

        Backport of: http://review.gluster.org/16156

Commit 93eaeb9c93be3232f24e840044d560f9f0e66f71 introduces
leaks in INODELK callback where a dict is unserialized twice,
leading to dict leaks.

Change-Id: Ib01e7fd3557b59ebb748114195b234b9397bb137
BUG: 1405885
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/16186
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra G

afr, client: More mem-leak fixes in COMPOUND fop cbk

2016-12-20T09:12:59+00:00

        Backport of: http://review.gluster.org/16020

Bugs found and fixed:
1. Use correct subvolume index in pre-op-writev compound cbk
2. Prevent use-after-free of local->compound_args members in
   compound fops cbk in protocol/client
3. Fix xdata and xattr leaks in client_process_response
4. Fix possible leak of xdata in client_pre_writev() in
   test mode.
5. Free req->compound_req_array.compound_req_array_val as well
   after freeing its members
6. Free tmp_rsp->flock.lk_owner.lk_owner_val in LK fop.

Change-Id: I40f576b48625d65fcbd7a11181eeff37f9e1e011
BUG: 1402212
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/16046
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

protocol/client: fix op_errno handling, was unused variable

2016-12-18T12:57:49+00:00

        Backport of: http://review.gluster.org/15482

see comment in patch set one. Match the general logic flow of the
other fop-cbks and eliminate the unused variable and its associated
warning

also see comment in patch set seven, re: correct handling of
client_process_response(); and the associated BZ
https://bugzilla.redhat.com/show_bug.cgi?id=1376328

http://review.gluster.org/14085 fixes a "pragma leak" where the
generated rpc/xdr headers have a pair of pragmas that disable these
warnings. With the warnings disabled, many unused variables have
crept into the code base.

And 14085 won't pass its own smoke test until all these warnings are
fixed.

Change-Id: I9958a70b56023258921960410f9b641505fd4387
BUG: 1405308
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/16161
Tested-by: Krutika Dhananjay 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

protocol/server: Remove unused variable

2016-12-14T07:52:25+00:00

 >Change-Id: I0d0a786b2d02d4db37c4da6194ee4b4feac31b63
 >BUG: 1198849
 >Signed-off-by: Anoop C S 
 >Reviewed-on: http://review.gluster.org/15899
 >Smoke: Gluster Build System 
 >NetBSD-regression: NetBSD Build System 
 >CentOS-regression: Gluster Build System 
 >Reviewed-by: Vijay Bellur 

BUG: 1396780
Change-Id: I78cb34d0f91c2f375c2e4e413337253b34987baa
Signed-off-by: Anoop C S 
Reviewed-on: http://review.gluster.org/16058
Tested-by: Pranith Kumar Karampuri 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

protocol/server: Print error-xlator name

2016-12-14T07:49:25+00:00

Problem:
At the moment from which xlator the errors are stemming from is a mystery.

Fix:
With this patch we can find on the server side which xlator first gave
the errno received by server xlator. I am not yet sure how to get this
done for client side which has lot of copy_frame()s. May be another
patch.

 >Change-Id: Ie13307b965facf2a496123e81ce0bd6756f98ac9
 >BUG: 1394548
 >Signed-off-by: Pranith Kumar K 
 >Reviewed-on: http://review.gluster.org/15836
 >Smoke: Gluster Build System 
 >NetBSD-regression: NetBSD Build System 
 >Reviewed-by: Vijay Bellur 
 >CentOS-regression: Gluster Build System 

BUG: 1396780
Change-Id: I3b293d21528da391eafd0fbaa5b451a1d3ddc237
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/15886
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Raghavendra Talur

protocol/server: Print pargfid in logs for rename error

2016-12-14T07:48:51+00:00

        Backport of http://review.gluster.org/15872

 >BUG: 1394548
 >Change-Id: I42ee627c8cdf54158f083f9019a096ace449e3cc
 >Signed-off-by: Pranith Kumar K 

BUG: 1396780
Change-Id: I80c3d3c7994982b812857c6705b3bf4716bf0824
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/15887
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra Talur

protocol/server: Fix mem-leaks in compound fops

2016-11-30T16:50:14+00:00

        Backport of: http://review.gluster.org/15965

* Remove spurious 'return' statement.
* Free up 'compound_rsp_array_val' as well in the end.
* Remove multiple refs on this_args->xdata.

Change-Id: I207b5f3d87e7cfdd0d0997547cc4a0e9e32de8e1
BUG: 1399891
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/15973
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Pranith Kumar Karampuri

protocol/server: capture offset in seek

2016-11-29T04:19:01+00:00

Problem:
http://review.gluster.org/11482 implemented seek FOP but
http://review.gluster.org/#/c/14137/ 'undid' the change where we pack
the offset returned by seek in server xlator before sending it to the client.
As a result, seek always returns zero to the client for SEEK_HOLE/
SEEK_DATA.

Fix:
I think 14137 removed it unintentionally, hence adding it back again.

> Reviewed-on: http://review.gluster.org/15920
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Pranith Kumar Karampuri 

(cherry picked from commit cc37e5929d1e3ea4eaf4c4576a82066bf131ad05)
Signed-off-by: Ravishankar N 
Change-Id: I67a1f7b53214b043c5291f5704be4a50b698f91c
BUG: 1399131
Reviewed-on: http://review.gluster.org/15944
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

protocol/client: Fix iobref and iobuf leaks in COMPOUND fop

2016-11-17T06:26:01+00:00

        Backport of: http://review.gluster.org/15860

Change-Id: I5873bd0ae9a2df91876b1c9c9d8afdec9c5151f9
BUG: 1395694
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/15861
Reviewed-by: Pranith Kumar Karampuri 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System