glusterfs.git/xlators/protocol, branch v3.7.3

rpc,server,glusterd: Init transport list for accepted transport

2015-07-26T17:36:39+00:00

GlusterD or a brick would crash when encrypted transport was enabled and
an unencrypted client tried to connect to them. The crash occured when
GlusterD/server tried to remove the transport from their xprt_list due
to a DISCONNECT event. But as the client transport's list head wasn't
inited, the process would crash when list_del was performed.

Initing the client transports list head during acceptence, prevents this
crash.

Also, an extra check has been added to the GlusterD and Server
notification handlers for client DISCONNECT events. The handlers will
now first check if the client transport is a member of any list.
GlusterD and Server DISCONNECT event handlers could be called without
the ACCEPT handler, which adds the transport to the list, being called.
This situation also occurs when an unencrypted client tries to establish
a connection with an encrypted server.

Change-Id: Icc24a08d60e978aaa1d3322e0cbed680dcbda2b4
BUG: 1246809
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/11692
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra G 
(cherry picked from commit a909ccfa1b4cbf656c4608ef2124347851c492cb)
Reviewed-on: http://review.gluster.org/11762

logging: client3_3_removexattr_cbk should not log expected ENODATA

2015-07-26T08:10:24+00:00

Commit 379dbbfd changed the log level of an expected error message from
GF_LOG_DEBUG to '0'. This causes the message to always get logged. It is
intended to log the warning when the xattr could not be removed (but
exists), removing a non-existing xattr is sufficient as debug.

Backported from:
> BUG: 1246736
> Change-Id: If11d15d699e8152cc32e0c0c1d65b587c5c48892
> Reviewed-on: http://review.gluster.org/11759
> Signed-off-by: Niels de Vos 

Change-Id: If11d15d699e8152cc32e0c0c1d65b587c5c48892
BUG: 1246728
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/11760
Tested-by: NetBSD Build System 
Reviewed-by: Joe Julian 
Tested-by: Joe Julian 
Tested-by: Gluster Build System

protocol/server: use different dict for resolving

2015-07-23T06:46:16+00:00

                 Backport of http://review.gluster.org/11661

protocol/server has to resolve the inode before continuing with any fop coming
from the clients. For resolving it, server xlator was using the same dict
associated with the fop. It causes problems in some situations.

If a directory's inode was forgotten because of lru limit being exceeded, then
when a create fop comes for an entry within that directory, server tries to
resolve it. But since the parent directory's inode is not found in the inode
table, it tries to do a hard resolve by doing a lookup on the parent gfid.

If any xlator below server wants to get some extended attributes whenever
lookup comes, then they set the new keys in the same dict that came along with
the create fop. Now, the lookup of the parent succeeds and the create fop
proceeds with the same dict (with extra keys present). posix xlaror creates
those xattrs that are present in the dict. Thus the xattrs which were not to
be present by default are also set as part of create. (Ex: bit-rot related
xattrs such as bad-file, version and sign xattrs)

Change-Id: I62b0b012b0af3c92df6fced61f87dd0b6b015d4c
BUG: 1244100
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/11703
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G

protocol/server: Add null check to gf_client_put

2015-07-09T10:10:49+00:00

Change-Id: I8bab3cd7387f89743e15e7569f0bc83a7df3c754
BUG: 1240603
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/11550
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/11562
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

protocol/server: Correctly reconfigure auth.ssl-allow

2015-07-06T07:14:22+00:00

  Backport of https://review.gluster.org/11487

auth.ssl-allow wasn't being handled during reconfigure. This prevented
the ssl-allow list from being live reloaded.

Change-Id: If3435793a5684881b012de77cb254b1847b37810
BUG: 1238073
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/11492
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G

protocol/server: fail setvolume if any of xlators is not initialized yet

2015-07-02T11:14:09+00:00

We can only start recieving fops only when all xlators in graph are
initialized.

Change-Id: Id79100bab5878bb2518ed133c1118554fbb35229
BUG: 1214169
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/11504
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System

protocol/client : removing duplicate printing in gf_msg

2015-06-27T12:04:47+00:00

Since the 3rd and 5th argument of gf_msg framework
prints the error string in case of strerror(),
the 5th argument is removed.

        Backport of http://review.gluster.org/#/c/11280/

Cherry picked from commit 4acd9d1bfc2be5179ddb611f61afaaeaa15be2cb
> Change-Id: Ib1794ea2d4cb5c46a39311f0afcfd7e494540506
> BUG: 1194640
> Signed-off-by: Manikandan Selvaganesh 
> Reviewed-on: http://review.gluster.org/11280
> Tested-by: NetBSD Build System 
> Reviewed-by: Raghavendra Bhat 
> Reviewed-by: Vijay Bellur 

Change-Id: Ib1794ea2d4cb5c46a39311f0afcfd7e494540506
BUG: 1217722
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/11374
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G

protocol/server: Include a check to validate xprt->client

2015-06-27T09:55:19+00:00

rpc_transport entries(xprt) are added to the conf->xprt_list
during client connection with the server. But the client object is created
and assigned to that transport object only during GF_HANDSK_SETVOLUME. Hence
till that period, there could be xprt entries in the xprt_list without client
associated with it. Added a check to validate the client object during upcall
notify.

This is a backport of the below fix -
http://review.gluster.org/#/c/11411/

BUG: 1236274

Change-Id: I00b9a140d6ee76e44c49146e90c20b3a87dc2de8
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/11411
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-on: http://review.gluster.org/11441
Tested-by: NetBSD Build System

protocol/client : porting log messages to new framework

2015-06-17T12:11:43+00:00

        Backport of http://review.gluster.org/#/c/10042/

Cherry picked from 379dbbfd683d2b0e1704c098b1f020567328122c
> Change-Id: I9bf2ca08fef969e566a64475d0f7a16d37e66eeb
> BUG: 1194640
> Signed-off-by: Manikandan Selvaganesh 
> Reviewed-on: http://review.gluster.org/10042
> Tested-by: Gluster Build System 
> Reviewed-by: Raghavendra G 
> Tested-by: Raghavendra G 

Change-Id: I9bf2ca08fef969e566a64475d0f7a16d37e66eeb
BUG: 1217722
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/11240
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G

protocol/server : port log messages to a new framework

2015-06-15T05:25:00+00:00

        Backport of http://review.gluster.org/#/c/9874/

Cherry picked from dc089a1a51988c2b407040e1684d7b0adbd79556
> Change-Id: I7901f55d06716161cc31d2b79a600a16b5ec2ef8
> BUG: 1194640
> Signed-off-by: Manikandan Selvaganesh 
> Reviewed-on: http://review.gluster.org/9874
> Tested-by: Gluster Build System 
> Reviewed-by: Raghavendra G 

Change-Id: I7901f55d06716161cc31d2b79a600a16b5ec2ef8
BUG: 1217722
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/10552
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G