glusterfs.git/xlators/protocol, branch v3.4.0qa7

glusterd/cli: Updated the options descriptions for "volume set help"

2013-01-22T07:03:57+00:00

Change-Id: I0db00b7334bb9707ab48bd661ac03a3ad818d6e4
BUG: 893458
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/4393
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

core: fixes for gcc's '-pedantic' flag build

2013-01-22T06:17:36+00:00

* warnings on 'void *' arguments
* warnings on empty initializations
* warnings on empty array (array[0])

Change-Id: Iae440f54cbd59580eb69f3ecaed5a9926c0edf95
BUG: 875913
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/4219
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

protocol/server: do server_connection_put only if bound_xl is NULL

2013-01-16T17:52:31+00:00

If getting bound_xl fails, then while putting the connection back we
should also check for bound_xl pointer for NULL apart from the op_ret
and the connection object. We were checking just op_ret and conn pointer
till now and if the mount from a machine is not allowed as auth.allow
did not permit it, then also we were destroying the connection object.

Change-Id: Iac43e8dc078d905edafb44d6670f88989a8f82a3
BUG: 881062
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/4373
Reviewed-by: Amar Tumballi 
Tested-by: Gluster Build System

protocol/client: print a message regarding brick status in case of failure

2012-12-20T12:05:18+00:00

that way, it would help admins to look at the corresponding brick directly.

All credit goes to Amar.

Change-Id: I959df59111864cc0574945d827f8fe5f2d919491
BUG: 839021
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/4341
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

core: remove all the 'inner' functions in codebase

2012-12-20T07:35:29+00:00

* move 'dict_keys_join()' from api/glfs_fops.c to libglusterfs/dict.c
  - also added an argument which is treated as a filter function if
    required, currently useful for fuse.

* now 'make CFLAGS="-std=gnu99 -pedantic" 2>&1 | grep nested' gives
  no output.

Change-Id: I4e18496fbd93ae1d3942026ef4931889cba015e8
Signed-off-by: Amar Tumballi 
BUG: 875913
Reviewed-on: http://review.gluster.org/4187
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

protocol/server: Do not access key after GF_FREE in _delete_auth_opt()

2012-12-19T21:18:58+00:00

PROBLEMS:

1.'key' becomes a dangling pointer after the first call to dict_del()
   returns, in _delete_auth_opt(). Therefore, the second call to
   fnmatch() is made with 'key' pointing to deallocated space.

2. Also, the name _delete_auth_opt seems to suggest that the function
   is intended to match and delete "auth" options from the dictionary.
   But it winds up deleting all the options irrespective of whether
   the pattern match was successful or not. The same is true with
   _copy_auth_opt().

FIX:

Changed _delete_auth_opt() to delete the key ONLY if it matches either
of the two patterns (auth.addr.*.allow and auth.addr.*.reject).
Similarly, changed _copy_auth_opt() along the same lines.

Change-Id: Ic8664e5a0a29cefe43cb59a27e32fbdbeac154b5
BUG: 881062
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/4337
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

Fix xdr_to_generic success check

2012-12-10T05:59:56+00:00

This patch fixes the success check for xdr_to_generic function across the
codebase.

Also, cleans up the brick_op actors table in glusterfsd-mgmt.c to make sure that
the actors are called directly by rpcsvc.

Change-Id: I3086585f30c44f69f1bc83665f89e30025f76d3a
BUG: 884452
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/4278
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

protocol/client: log ENOENT errors in debug mode.

2012-12-05T00:31:02+00:00

Change-Id: I9b4ffb4a2f6be7ff5a0521f6582a9bc6f172e26c
BUG: 872490
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/4153
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

protocol/client: add an option to filter O_DIRECT flag in open

2012-11-28T11:37:03+00:00

with the option, the idea is all client-side caching will be disabled,
where as on server side process, the fd will be treated as a regular
fd, thus helping the performance better.

"gluster volume set  remote-dio enable" would set
this option in client protocol volumes.

Change-Id: Id2255a167137f8fee20849513e3011274dc829b4
Signed-off-by: Amar Tumballi 
BUG: 845213
Reviewed-on: http://review.gluster.org/4206
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

protocols: Suppress getxattr log when errno is ENOENT

2012-10-29T03:26:45+00:00

Change-Id: I3f4fe3f382aec5fd142cc409b80bd73aebd8b39b
BUG: 861015
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/4097
Reviewed-by: Jeff Darcy 
Tested-by: Gluster Build System