glusterfs.git/xlators/protocol, branch v3.1.0qa4

Fix for seg fault in dict_unserialize if undersized buffers are passed

2010-08-06T10:37:24+00:00

Signed-off-by: shishir gowda 
Signed-off-by: Anand V. Avati 

BUG: 1031 (dict_unserialize crash if undersized buffers passed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1031

rpc: changes to glusterfs programs that can take an optional payload argument.

2010-08-06T10:37:20+00:00

- The existing interface required the transport to separate the procedure
    header and procedure payload into two different buffers. Making this
    separation can prove cumbersome for transports like rdma wherein the header
    and payload can be received in a single buffer (For eg., header and payload
    of write fop sent as inline msg using rdma-send). This patch delegates the
    responsiblity of separating out header and payload to programs.

Signed-off-by: Raghavendra G 
Signed-off-by: Anand V. Avati 

BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875

changes to rpc

2010-07-28T12:08:26+00:00

- use mem-pool for requests and saved_frames.
  - preserve the rpc_req structure till rpc invokes program's reply.
    This will enable us to store transport specific data that has to
    last till reply has come (eg., memory regions of chunk lists in
    case of rdma).
  - change signature of rpc_clnt_submit to accept rsphdr_vector and
    rsppayload_vector. The buffers pointed by these vectors will be
    from iobufs and these iobufs are added to an iobref which should
    also be passed as an arguement to rpc_clnt_submit.

Signed-off-by: Raghavendra G 
Signed-off-by: Anand V. Avati 

BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875

fix all clang errors in xlator/protocol

2010-07-28T10:34:58+00:00

Signed-off-by: Amar Tumballi 
Signed-off-by: Anand V. Avati 

BUG: 1092 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1092

removed last few remaining 'ERR_ABORT's from codebase

2010-07-28T10:34:54+00:00

Signed-off-by: Amar Tumballi 
Signed-off-by: Anand V. Avati 

BUG: 966 (NULL check for avoiding NULL dereferencing of pointers..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=966

some check added to the variables after GF_CALLOC

2010-07-28T10:34:48+00:00

handles some NULL dereference problems
(reported by clang when ran with code where '#define GF_CALLOC NULL').

Signed-off-by: Amar Tumballi 
Signed-off-by: Anand V. Avati 

BUG: 966 (NULL check for avoiding NULL dereferencing of pointers..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=966

Cancel ping timer if socket or ib error

2010-07-27T08:20:15+00:00

If the there is an socket or ib error, fail the ping request
 to prevent retries. Which  would cause active connections
 to be disconnected

Signed-off-by: shishir gowda 
Signed-off-by: Anand V. Avati 

BUG: 907 (cancel ping timer in case of socket fd error or iberror)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=907

Set fdctx only if op_ret is not -1

2010-07-27T08:20:00+00:00

Signed-off-by: Anush Shetty 
Signed-off-by: Anand V. Avati 

BUG: 1218 (Crash in client_fdctx_destroy)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1218

client protocol should send the fops only after handshake

2010-07-23T11:28:53+00:00

Signed-off-by: Amar Tumballi 
Signed-off-by: Anand V. Avati 

BUG: 1195 (crash in protocol server due to unauthenticated fop request..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1195

handle some NULL dereference in server protocol

2010-07-23T11:28:49+00:00

which can happen due to un authenticated clients sending requests.

Signed-off-by: Amar Tumballi 
Signed-off-by: Anand V. Avati 

BUG: 1195 (crash in protocol server due to unauthenticated fop request..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1195