glusterfs.git/xlators/protocol/server, branch v3.9.1

client,server: Free xdr-allocated compound req/rsp arrays

2016-12-22T13:44:52+00:00

        Backport of: http://review.gluster.org/16210

Change-Id: If757ffc08d07aef6532e9087392258002b24847a
BUG: 1406308
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/16222
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra G

protocol/server: Remove unused variable

2016-12-14T07:52:25+00:00

 >Change-Id: I0d0a786b2d02d4db37c4da6194ee4b4feac31b63
 >BUG: 1198849
 >Signed-off-by: Anoop C S 
 >Reviewed-on: http://review.gluster.org/15899
 >Smoke: Gluster Build System 
 >NetBSD-regression: NetBSD Build System 
 >CentOS-regression: Gluster Build System 
 >Reviewed-by: Vijay Bellur 

BUG: 1396780
Change-Id: I78cb34d0f91c2f375c2e4e413337253b34987baa
Signed-off-by: Anoop C S 
Reviewed-on: http://review.gluster.org/16058
Tested-by: Pranith Kumar Karampuri 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

protocol/server: Print error-xlator name

2016-12-14T07:49:25+00:00

Problem:
At the moment from which xlator the errors are stemming from is a mystery.

Fix:
With this patch we can find on the server side which xlator first gave
the errno received by server xlator. I am not yet sure how to get this
done for client side which has lot of copy_frame()s. May be another
patch.

 >Change-Id: Ie13307b965facf2a496123e81ce0bd6756f98ac9
 >BUG: 1394548
 >Signed-off-by: Pranith Kumar K 
 >Reviewed-on: http://review.gluster.org/15836
 >Smoke: Gluster Build System 
 >NetBSD-regression: NetBSD Build System 
 >Reviewed-by: Vijay Bellur 
 >CentOS-regression: Gluster Build System 

BUG: 1396780
Change-Id: I3b293d21528da391eafd0fbaa5b451a1d3ddc237
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/15886
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Raghavendra Talur

protocol/server: Print pargfid in logs for rename error

2016-12-14T07:48:51+00:00

        Backport of http://review.gluster.org/15872

 >BUG: 1394548
 >Change-Id: I42ee627c8cdf54158f083f9019a096ace449e3cc
 >Signed-off-by: Pranith Kumar K 

BUG: 1396780
Change-Id: I80c3d3c7994982b812857c6705b3bf4716bf0824
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/15887
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra Talur

protocol/server: Fix mem-leaks in compound fops

2016-11-30T16:50:14+00:00

        Backport of: http://review.gluster.org/15965

* Remove spurious 'return' statement.
* Free up 'compound_rsp_array_val' as well in the end.
* Remove multiple refs on this_args->xdata.

Change-Id: I207b5f3d87e7cfdd0d0997547cc4a0e9e32de8e1
BUG: 1399891
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/15973
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Pranith Kumar Karampuri

protocol/server: capture offset in seek

2016-11-29T04:19:01+00:00

Problem:
http://review.gluster.org/11482 implemented seek FOP but
http://review.gluster.org/#/c/14137/ 'undid' the change where we pack
the offset returned by seek in server xlator before sending it to the client.
As a result, seek always returns zero to the client for SEEK_HOLE/
SEEK_DATA.

Fix:
I think 14137 removed it unintentionally, hence adding it back again.

> Reviewed-on: http://review.gluster.org/15920
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Pranith Kumar Karampuri 

(cherry picked from commit cc37e5929d1e3ea4eaf4c4576a82066bf131ad05)
Signed-off-by: Ravishankar N 
Change-Id: I67a1f7b53214b043c5291f5704be4a50b698f91c
BUG: 1399131
Reviewed-on: http://review.gluster.org/15944
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

compound fops: Fix file corruption issue

2016-10-25T04:14:54+00:00

        Backport of: http://review.gluster.org/#/c/15654/

1. Address of a local variable @args is copied into state->req
in server3_3_compound (). But even after the function has gone out of
scope, in server_compound_resume () this pointer is accessed and
dereferenced. This patch fixes that.

2. Compound fops, by virtue of NOT having a vector sizer (like the one
writev has), ends up having both the header and the data (in case one of
its member fops is WRITEV) in the same hdr_iobuf. This buffer was not
being preserved through the lifetime of the compound fop, causing it to
be overwritten by a parallel write fop, even when the writev associated
with the currently executing compound fop is yet to hit the desk, thereby
corrupting the file's data. This is fixed by associating the hdr_iobuf with
the iobref so its memory remains valid through the lifetime of the fop.

3. Also fixed a use-after-free bug in protocol/client in compound fops cbk,
missed by Linux but caught by NetBSD.

Finally, big thanks to Pranith Kumar K and Raghavendra Gowdappa for their
help in debugging this file corruption issue.

Change-Id: I58da39ae544ad81192849926399a971c4c01c986
BUG: 1387984
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/15709
NetBSD-regression: NetBSD Build System 
Reviewed-by: Raghavendra G 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System

protocol-server: generate events

2016-09-08T07:59:22+00:00

This patch add/generate the events seen from/in the protocol server
side, which will be consumed by the new eventing framework.

-------------------------------------------------------------------------
|          event                |            description                |
|-------------------------------|---------------------------------------|
| EVENT_CLIENT_CONNECT          |          new client connected         |
|-------------------------------|---------------------------------------|
| EVENT_CLIENT_AUTH_REJECT      |     client cannot be authenticated    |
|-------------------------------|---------------------------------------|
| EVENT_CLIENT_DISCONNECT       |        client had disconnected        |
-------------------------------------------------------------------------

Thanks to "Raghavendra Talur"  for all the help

Backport of:
> Change-Id: I4fda83fae7747507f64d81a7645cc3a8a2fbaeae
> BUG: 1369403
> Signed-off-by: Prasanna Kumar Kalever 
> Reviewed-on: http://review.gluster.org/15294
> Tested-by: Prasanna Kumar Kalever 
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Raghavendra G 

Change-Id: I4fda83fae7747507f64d81a7645cc3a8a2fbaeae
BUG: 1373740
Signed-off-by: Prasanna Kumar Kalever 
Reviewed-on: http://review.gluster.org/15415
Tested-by: Prasanna Kumar Kalever 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Atin Mukherjee

compound fops: Some fixes to compound fops framework

2016-08-31T06:50:40+00:00

Change-Id: I808fd5f9f002a35bff94d310c5d61a781e49570b
BUG: 1360169
Signed-off-by: Anuradha Talur 
Reviewed-on: http://review.gluster.org/15010
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra G

protocol/server: fix unused variable warnings/errors

2016-08-27T11:17:49+00:00

http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.

However 14085 won't pass the smoke test until all the warnings are
fixed.

Change-Id: I5a48055c4b0a4a07dd511ad4f2e9ef823b9c60b2
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/15255
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra G