glusterfs.git/xlators/protocol/client, branch v3.3.0qa30

rpc-clnt: separate out connection_cleanup() from destroy()

2012-03-19T16:14:40+00:00

noticed that there are possibilities where one would like to do a
connection_cleanup() before destroying a RPC connection itself, also
current code is such that, rpc_clnt_connection_cleanup() does
rpc_clnt_ref() and unref(), creating a race window/double unref
possibilities in the code.

by separating out the functions, this race window/double fault can be
prevented.

Change-Id: I7ebd3392efa891232857b6db9108b0b19e40fc12
Signed-off-by: Amar Tumballi 
BUG: 802403
Reviewed-on: http://review.gluster.com/2979
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

protocol/client: Handle failures in lock self healing gracefully (part 1).

2012-03-19T16:05:58+00:00

During reopening of fd's and reacquiring of locks on the fd (after a
reconnect), a release on a fd on which reacquiring of locks is in progress
will free up fdctx. This patch will keep fdctx valid until the reacquiring
of locks is in progress.

Change-Id: I0464c751a5aa986abac0b72b48b261fceeba24e8
BUG: 795386
Signed-off-by: Mohammed Junaid 
Reviewed-on: http://review.gluster.com/2937
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Vijay Bellur

protocol/server: Handle server send reply failure gracefully.

2012-03-19T15:11:43+00:00

Server send reply failure should not call server connection cleanup because
if a reconnection happens with in the grace-timeout the connection object is
reused. We must cleanup only on grace-timeout.

Change-Id: I7d171a863382646ff392031c2b845fe4f0d3d5dc
BUG: 803365
Signed-off-by: Mohammed Junaid 
Reviewed-on: http://review.gluster.com/2947
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

protocol/client: Avoid STACK_DESTROYing more than once in RELEASE fops.

2012-03-19T12:58:30+00:00

Change-Id: I435327c6133aa6739731dabddde860b0b43c1497
BUG: 804607
Signed-off-by: Vijay Bellur 
Reviewed-on: http://review.gluster.com/2978
Reviewed-by: Amar Tumballi 
Tested-by: Gluster Build System

protocol/client: replace STACK_UNWIND_STRICT macro with CLIENT_STACK_UNWIND,

2012-03-18T08:52:37+00:00

which does appropraite cleanup before unwinding.

Signed-off-by: Raghavendra G 
Change-Id: Ic49d6e21c5fc56e747afec35be2bebbbbd2a6583
BUG: 767359
Reviewed-on: http://review.gluster.com/2897
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Anand Avati

rpc: don't unwind the fop in caller if client_submit_request fails

2012-03-18T08:52:04+00:00

client_submit_request guarantees that the cbkfn - which we pass to
it as argument - is called whenever there is a failure.

Change-Id: I0e8ce5a6b320246dc13ce4318b04739d38d183a3
BUG: 767359
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.com/2896
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Anand Avati

protocol/client: remove unused variables from 'priv/conf'

2012-03-12T12:27:33+00:00

'last_sent', and 'last_recieved' variables were not used anymore
after having RPC layer. Hence removed it from the code.

Change-Id: I1ba74d47f909406ebde43476ccfed724e6c7e77f
Signed-off-by: Amar Tumballi 
BUG: 801721
Reviewed-on: http://review.gluster.com/2916
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

protocol/client: Register a timer(grace-timer) conditionally.

2012-03-10T13:27:56+00:00

A grace timer is registered on a disconnect, but a reconnect timer sends a
connect request after every 3sec and if the server is down, the client protocol
receives disconnect and a grace timer will be registered which on timeout will
increase the lk-version value. Its enough to register the grace timer once after
the disconnect and later just ignore other psuedo disconnects.

Change-Id: I36a153aa86b350d87fe50d014ee0297f558a7fb6
BUG: 795386
Signed-off-by: Mohammed Junaid 
Reviewed-on: http://review.gluster.com/2906
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Vijay Bellur

protocol/client: Added lk_ctx info in fdctx dump

2012-03-07T18:17:41+00:00

- Added a brief explanation as to why we can't use gf_log
  when in statedump.

- Removed gf_log messages from client_priv_dump since
  it can cause a 'deadlock' - See statedump.c for explanation

- Added try-lock based accessors for fd_lk_list for dump purposes.

Change-Id: I1d755a4ef2c568acf22fb8c4ab0a33a4f5fd07b4
BUG: 789858
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.com/2882
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Vijay Bellur

protocol/client: Free readdirp xdr leak

2012-03-07T17:20:06+00:00

Change-Id: I5e46deedd93e852a483693de42e4bec0082bc08b
BUG: 796186
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/2886
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi