glusterfs.git/xlators/protocol/client/src, branch v2.0.7

protocol/client: access glusterfs context from the ctx member of xlator object

2009-09-22T13:13:43+00:00

- A global context pointer cannot be used with libglusterfsclient, since
    there can be many contexts in a single process.

Signed-off-by: Anand V. Avati 

BUG: 271 (applications using booster protocol/client crash in client_setvolume_cbk.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=271

client-protocol: fix race-condition encountered while accessing fdctx

2009-09-22T13:13:35+00:00

- In protocol/client, fdctx is accessed by two sets of procedures,
  protocol_client_mark_fd_bad falls in one set whereas the other set consists of
  all fops which receive fd as an argument. The way these fdctxs are got is
  different in these two sets. While in the former set, fdctx is accessed
  through conf->saved_fds, which is a list of fdctxs of fds representing
  opened/created files. In the latter set, fdctxs are got directly from fd
  through fd_ctx_get(). Now there can be race conditions between two threads
  executing one procedure from these two sets. As an example let us consider
  following scenario:

  A flush operation is timed out and polling thread executing
  protocol_client_mark_fd_bad, fuse thread executing client_release. This can
  happen because, immediately a reply for flush is written to fuse, a release on
  the same fd can be sent to glusterfs and the polling thread still might be
  doing cleanup. Consider following set of events:

  1. fuse thread does fd_ctx_get (fd).
  2. polling thread gets the same fdctx but through conf->saved_fds.
  3. Now both threads go ahead and does list_del (fdctx) and eventually free
     fdctx.

  In other situations the same set events might occur and the threads
  executing fops other than flush in the second set might be accessing a
  fdctx freed in protocol_client_mark_fd_bad.

Signed-off-by: Anand V. Avati 

BUG: 127 (race-condition in accessing fdctx in protocol/client)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=127

protocol/client: 'connecting' event is properly notified.

2009-08-21T02:05:24+00:00

when there are no servers available to client, and transport init is
not successful, send 'connecting' event once to parent so it doesn't
hand in there.

Signed-off-by: Anand V. Avati 

BUG: 224 (Client hangs if none of the servers are up)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=224

protocol/client: fixed registration of saved_fds

2009-08-07T08:24:33+00:00

In client_open_cbk, client_opendir_cbk the list_add_tail macros were invoked with wrong
ordered arguments, causing the existing registered fd list to get unlinked from the
saved_fds list. The effects of this is far fetched - when transport disconnects, open
fds are no more marked bad as they are not reachable from the saved_fds list. After
reconnection, resumed access on this fd causes reference to invalid fds on the server.
It could appear in the form of 'unresolved fd' error, readdir happening on a file fd,
files reading from other files, etc.

Signed-off-by: Anand V. Avati 

BUG: 192 (sefault in posix-readdir)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=192

BUG: 126 (Immediate segfault when used for rootfs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=126

BUG: 173 ([ glusterfs 2.0.6rc1 ] - "server SEG fault")
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=173

BUG: 194 (Apache+Booster results in inconsistent download size using wget)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=194

protocol/client: use translated flags in protocol/client open and create fops

2009-07-08T02:32:18+00:00

Signed-off-by: Anand V. Avati

build warning fixes

2009-06-30T23:33:45+00:00

integer typecast warnings fixed

Signed-off-by: Anand V. Avati

client_xattrop: use dict_allocate_and_serialize during serializing xattr

2009-06-30T22:24:54+00:00

- though the previous commit fixes bug #29, this patch fixes bugs
    arising in similar situations where xattrop is initiated by
    xlators other than afr.

Signed-off-by: Anand V. Avati

client: Replace saved_fds dict with list

2009-06-30T21:36:27+00:00

Thhie change removes a huge inefficiency in file open
path where every open resulted in dictionary operations
in order to let the client maintain a list of fd_t's being
used over a particular client context.

Resolves: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=16

Signed-off-by: Anand V. Avati

Fix some trivial typos.

2009-06-29T17:15:13+00:00

I noticed that there were some minor spelling mistakes/typos in some
of the source files. This patch fixes the ones I've found.

Signed-off-by: Anand V. Avati

version check between client/server made more specific to protocol only.

2009-06-29T16:59:12+00:00

This patch is a step towards giving compatibility between the versions of
GlusterFS. Now onwards, the protocol-version won't depend on release
versions. In general, multiple glusterfs versions can have common
protocol-version.

Signed-off-by: Anand V. Avati