glusterfs.git/xlators/protocol/client/src/client3_1-fops.c, branch v5.4

xlators/protocol: better filename

2012-07-04T18:56:59+00:00

3_1 name was used for very first version of GlusterFS which
used RPC for its protocol, even though we changed protocol
after 3.1.x, we kept the name of few files as is. Changed
the file names to something better.

Change-Id: I297f1979e7c7e909e60674eec2e632506bc776f5
BUG: 764890
Signed-off-by: Amar Tumballi 
Reviewed-on: http://review.gluster.com/3628
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

protocol/client: Re-open should not have O_CREAT|O_TRUNC|O_EXCL

2012-06-20T06:50:30+00:00

RCA
The bug is observed in 3.2.x because posix xlator changes
the uid/gid of file as per frame->root-uid/gid if O_CREAT flag
is set in open fop. Posix does not do this in 3.3.x so that
bug does not appear anymore but this issue exposed the actual
bug in client xlator re-open. Re-open of a file on re-connection
should not perform re-open with the same flags at the time of
open/create/opendir. Imagine a case where a file is opened with
O_TRUNC|O_RDWR and some data is written to it, now if the brick
goes down and comes back the file will be truncated.
When I tested this case, the file is not truncated because locks
xlator resets O_TRUNC unconditionally.
Client xlator re-open bug and locks xlator bug cancel each other.

Fix
Reset O_CREAT|O_TRUNC|O_EXCL flags in re-open.
Locks xlator should not reset O_TRUNC.

Additional changes
Removed wbflags as it is not assigned at all.

Testcases
Automated go program is at:
://bugzilla.redhat.com/show_bug.cgi?id=807976#c2

Change-Id: I0080344fdda2e62e7c976c35a5bf5f1fa8838891
BUG: 807976
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/3582
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Anand Avati

protocol/client: Remember the gfid of opened fd

2012-06-06T19:35:44+00:00

This is needed when the fresh lookup triggers self-heal, gfid
won't be present in inode yet. Similar situation happens with
Rebalance as it does not perform inode_link.
Added similar fix for re-opendir.
Removed inode from fdctx and removed some duplication of code.

Change-Id: Ic94e5738c8585ed86801d2eed9ddab1015246710
BUG: 826080
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/3517
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Anand Avati

replicate: default read_child to a local brick if there is one.

2012-06-05T17:43:34+00:00

Controlled by the "choose-local" option (on by default).

Change-Id: I560f27c81703f2c9c62fdb51532c8eb763826df7
BUG: 806462
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.com/3005
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

protocol/client: do not ignore the xdata received for some fops

2012-06-04T05:07:30+00:00

opendir, fsetattr, fsync, lk were sending NULL xdata to the server
even though it (xdata) had values within it.

Change-Id: Ic274ab903c5c1e443409dd250ede80cd85d10b36
BUG: 826923
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.com/3502
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Anand Avati

protocol/client: provide a buffer for storing reply of readlink.

2012-06-01T22:58:31+00:00

since a readlink response can be bigger than size of rdma-msges
that can be inlined, we need to provide a buffer where server
can do an rdma-write of response.

Change-Id: I6ab06c3a94702f810ab0c57b409aaaf35cc93057
BUG: 822337
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.com/3464
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

protocol: do not log getxattr/ENODATA as warning

2012-05-30T05:57:18+00:00

When SELinux is enabled, most of the files do not have labels and
result is a ton of unnecessary logs

Change-Id: I0e781e2fb6bcfb3fb12298175a41f7b981af9c39
BUG: 811217
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.com/3486
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi

protocol/client: do not print the null gfid when symlink fails

2012-05-22T19:16:48+00:00

Change-Id: I1a2748768bc30a00c4f7b2e2fda1d282bc581658
BUG: 823880
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.com/3411
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

protocol: handle proper vector size for writev()/readv()

2012-05-21T23:50:57+00:00

* fixes the offset handling issue when 'xdata' is sent in writev/readv fop
  at the transport layer itself.
* client_writev() was not sending xdata on wire, fixed

Change-Id: Ib5ced64c84d415f07032662017979c65d9a1a128
Signed-off-by: Amar Tumballi 
BUG: 808078
Reviewed-on: http://review.gluster.com/3182
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy 
Tested-by: Jeff Darcy 
Reviewed-by: Anand Avati

protocol/client: check if the name is NULL before duping it

2012-05-17T16:07:54+00:00

Change-Id: I1cefc34af6fae2e71b05179824963e06361c35a2
BUG: 822385
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.com/3353
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Tested-by: Anand Avati