glusterfs.git/xlators/protocol/client/src/client3_1-fops.c, branch v3.3.0qa30

protocol/client: Handle failures in lock self healing gracefully (part 1).

2012-03-19T16:05:58+00:00

During reopening of fd's and reacquiring of locks on the fd (after a
reconnect), a release on a fd on which reacquiring of locks is in progress
will free up fdctx. This patch will keep fdctx valid until the reacquiring
of locks is in progress.

Change-Id: I0464c751a5aa986abac0b72b48b261fceeba24e8
BUG: 795386
Signed-off-by: Mohammed Junaid 
Reviewed-on: http://review.gluster.com/2937
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Vijay Bellur

protocol/client: Avoid STACK_DESTROYing more than once in RELEASE fops.

2012-03-19T12:58:30+00:00

Change-Id: I435327c6133aa6739731dabddde860b0b43c1497
BUG: 804607
Signed-off-by: Vijay Bellur 
Reviewed-on: http://review.gluster.com/2978
Reviewed-by: Amar Tumballi 
Tested-by: Gluster Build System

protocol/client: replace STACK_UNWIND_STRICT macro with CLIENT_STACK_UNWIND,

2012-03-18T08:52:37+00:00

which does appropraite cleanup before unwinding.

Signed-off-by: Raghavendra G 
Change-Id: Ic49d6e21c5fc56e747afec35be2bebbbbd2a6583
BUG: 767359
Reviewed-on: http://review.gluster.com/2897
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Anand Avati

rpc: don't unwind the fop in caller if client_submit_request fails

2012-03-18T08:52:04+00:00

client_submit_request guarantees that the cbkfn - which we pass to
it as argument - is called whenever there is a failure.

Change-Id: I0e8ce5a6b320246dc13ce4318b04739d38d183a3
BUG: 767359
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.com/2896
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Anand Avati

Fix memory leaks found in readdir

2012-03-01T19:42:56+00:00

Change-Id: I0e221e4de9ee12586b09cd8bf7f394e9d4b88a11
BUG: 765785
Reviewed-on: http://review.gluster.com/2853
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Vijay Bellur

protocol/client: Print correct error message

2012-02-22T15:09:32+00:00

Change-Id: Ic68626c4a205cd78b60831aa7bd838b6d8824fa1
BUG: 796195
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/2800
Reviewed-by: Amar Tumballi 
Tested-by: Gluster Build System

core: utilize mempool for frame->local allocations

2012-02-21T10:42:09+00:00

in each translator, which uses 'frame->local', we are using
GF_CALLOC/GF_FREE, which would be costly considering the
number of allocation happening in a lifetime of 'fop'. It
would be good to utilize the mem pool framework for xlator's
local structures, so there is no allocation overhead.

Change-Id: Ida6e65039a24d9c219b380aa1c3559f36046dc94
Signed-off-by: Amar Tumballi 
BUG: 765336
Reviewed-on: http://review.gluster.com/2772
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

rpc/clnt: handle PARENT_DOWN event appropriately

2012-02-21T09:42:42+00:00

Change-Id: I4644e944bad4d240d16de47786b9fa277333dba4
BUG: 767862
Signed-off-by: Raghavendra G 
Signed-off-by: Amar Tumballi 
Reviewed-on: http://review.gluster.com/2735
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

protocol/client,server: fcntl lock self healing.

2012-02-20T12:45:31+00:00

Currently(with out this patch), on a disconnect the server cleans up
the transport which inturn closes the fd's and releases the locks acquired on
those fd's by that client. On a reconnect, client just reopens the fd's but
doesn't reacquire the locks. The application that had previously acquired
the locks still is under the assumption that it is the owner of those locks
which might have been granted to other clients(if they request) by the server
leading to data corruption.

This patch allows the client to reacquire the fcntl locks (held on the fd's)
during client-server handshake.

* The server identifies the client via process-uuid-xl (which is a combination
  of uuid and client-protocol name, it is assumed to be unique) and lk-version
  number.

* The client maintains a list of process-uuid-xl, lk-version pair for each
  accepted connection. On a connect, the server traverses the list for a
  matching pair, if a matching pair is not found the the server returns
  lk-version with value 0, else it returns the lk-version it has in store.

* On a disconnect, the server and client enter grace period, and on the
  completion of the grace period, the client bumps up its lk-version number
  (which means, it will reacquire the locks the next time) and the server will
  distroy the connection. If reconnection happens within the grace period, the
  server will find the matching (process-uuid-xl, lk-version) pair in its list
  which guarantees that the fd's and there corresponding locks are still valid
  for this client.

Configurable options:
  To set grace-timeout, the following options are
    option server.grace-timeout value
    option client.grace-timeout value

  To enable or disable the lk-heal,
    option lk-heal [on|off]

gluster volume set command can be used to configurable options
Change-Id: Id677ef1087b300d649f278b8b2aa0d94eae85ed2
BUG: 795386
Signed-off-by: Mohammed Junaid 
Reviewed-on: http://review.gluster.com/2766
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

protocol/client: delete locks only for non-anonymous fds

2012-02-20T08:49:44+00:00

delete_granted_lock_owners () is not called for anonymous
fds since they are not involved in locking

Change-Id: Icdc7818f98f5371232ba276ed442704ef69e6b0e
BUG: 787365
Signed-off-by: Rajesh Amaravathi 
Reviewed-on: http://review.gluster.com/2754
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Vijay Bellur