glusterfs.git/xlators/performance, branch v3.7.7

all: reduce "inline" usage

2016-01-18T09:02:34+00:00

There are three kinds of inline functions: plain inline, extern inline,
and static inline.  All three have been removed from .c files, except
those in "contrib" which aren't our problem.  Inlines in .h files, which
are overwhelmingly "static inline" already, have generally been left
alone.  Over time we should be able to "lower" these into .c files, but
that has to be done in a case-by-case fashion requiring more manual
effort.  This part was easy to do automatically without (as far as I can
tell) any ill effect.

In the process, several pieces of dead code were flagged by the
compiler, and were removed.

backport of Change-Id: I56a5e614735c9e0a6ee420dab949eac22e25c155,
http://review.gluster.org/11769, BUG: 1245331

Change-Id: Iba1efb0bc578ea4a5e9bf76b7bd93dc1be9eba44
BUG: 1283302
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/12646
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos

md-cache: Remove readdirp fop for md-cache

2015-11-17T18:23:03+00:00

readdirp call will return inode for each entry and
will share this nodeid with kernal, also md-cache
will cache this gfid and base name. So when a lookup
operation is perfromed on such an inode, md-cache
will wind the call, that prevents populating inode
ctx for other lower layer xlators.

>Change-Id: I43c768703a3cc66d05b1c32909d1a2781001cb49
>BUG: 1236032
>Signed-off-by: Mohammed Rafi KC 
>Reviewed-on: http://review.gluster.org/11894
>Tested-by: Gluster Build System 
>Reviewed-by: Raghavendra G 

(cherry picked from commit c8c9308134ae4ce24c630a1b0ccfcf4e8f9b0fe7)


Change-Id: Iaa5451f5ff25fb16119a6c3322b1787709d1aba4
BUG: 1266880
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/12554
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Dan Lambright 
Tested-by: Dan Lambright

performance translators : port the missing gf_log to gf_msg

2015-09-28T04:48:32+00:00

        backport of: http://review.gluster.org/#/c/11906/

> Change-Id: I5cc2b4669b164fe09637c86da05d2d94589dd7e4
> BUG: 1253149
> Signed-off-by: Hari Gowtham 
> Reviewed-on: http://review.gluster.org/11906
> Tested-by: NetBSD Build System 
> Reviewed-by: Raghavendra G 
> Signed-off-by: Hari Gowtham 

Change-Id: I54c35e86428a01af5b593df7d3c9bf66a599999c
BUG: 1258727
Signed-off-by: Hari Gowtham 
Reviewed-on: http://review.gluster.org/12073
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G

features/bit-rot-stub: deny access to bad objects

2015-07-15T04:46:01+00:00

                       Backport of http://review.gluster.org/11126

* Access to bad objects (especially operations such as open, readv, writev)
  should be denied to prevent applications from getting wrong data.

* Do not allow anyone apart from scrubber to set bad object xattr.

* Do not allow bad object xattr to be removed.

Change-Id: I6903184ab64a9d1ea595330b603935979c33bc26
BUG: 1241529
Reviewed-on: http://review.gluster.org/11603
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Venky Shankar

core: fix Ubuntu code audit (cppcheck) results

2015-07-07T04:59:52+00:00

see http://review.gluster.org/#/c/8351/, comments to Change Set 4.

Change-Id: Ie15c5919e5bf9b0a1c66e20dc42d80fdfa8bd7f4
BUG: 1227808
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/11069
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Vijay Bellur

Logging: Porting the performance translator

2015-06-29T09:21:53+00:00

         logs to new logging framework

> Change-Id: Ie6aaf8d30bd4457bb73c48e23e6b1dea27598644
> BUG: 1194640
> Signed-off-by: arao 

BUG: 1217722
Change-Id: I0856c43dbf8c0a1aa084d4478c9bdf3f41dfc0b8
Signed-off-by: arao 
Reviewed-on: http://review.gluster.org/11442
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G

quick-read: Do a null check before unref

2015-04-29T05:01:37+00:00

Backport of http://review.gluster.org/10206

Commit 4ea5b8d2046b9e0bc7f24cdf1b2e72ab8b462c9e seems to have removed the check
as a part of static analyis fixes but I'm seeing errors in the client log.

---------------------
touch  /mnt/fuse_mnt/zero-byte-file
echo 3 > /proc/sys/vm/drop_caches
cat  /mnt/fuse_mnt/zero-byte-file

mount log:
[2015-04-13 05:52:21.683256] E [iobuf.c:790:iobuf_unref] (-->
/usr/local/lib/libglusterfs.so.0(_gf_log_callingfn+0x232)[0x7feda12c0e24] (-->
/usr/local/lib/libglusterfs.so.0(iobuf_unref+0x56)[0x7feda1304c8e] (-->
/usr/local/lib/glusterfs/3.7dev/xlator/performance/quick-read.so(qr_readv_cached+0x466)[0x7fed95b7e2fc]
(-->
/usr/local/lib/glusterfs/3.7dev/xlator/performance/quick-read.so(qr_readv+0x70)[0x7fed95b7e385]
(-->
/usr/local/lib/libglusterfs.so.0(default_readv_resume+0x270)[0x7feda12d4401]
))))) 0-iobuf: invalid argument: iobuf

---------------------

Change-Id: Ia6b29165cdef8783a716fe1e72d3d13bf0220aae
BUG: 1214168
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/10329
Tested-by: NetBSD Build System
Reviewed-by: Raghavendra Talur 
Tested-by: Raghavendra Talur 
Reviewed-by: Vijay Bellur

performance/md-cache: set right error check in {f}getxattr_cbk()

2015-04-07T03:57:45+00:00

Currently mdc_{f}getxattr_cbk() check(s) for a non-zero value to
determine if any cache update has to be performed. Right from
posix xlator, op_ret has a positive value upon success and -1 upon
failure. This patch sets right the check in getxattr callbacks so
that xattr cache update happens for successful calls.

Change-Id: Ifa5ec38bdf7e3dc095de9a56d91559b13cd9e8b6
BUG: 1208784
Signed-off-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/10127
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Talur

Avoid conflict between contrib/uuid and system uuid

2015-04-04T17:48:35+00:00

glusterfs relies on Linux uuid implementation, which
API is incompatible with most other systems's uuid. As
a result, libglusterfs has to embed contrib/uuid,
which is the Linux implementation, on non Linux systems.
This implementation is incompatible with systtem's
built in, but the symbols have the same names.

Usually this is not a problem because when we link
with -lglusterfs, libc's symbols are trumped. However
there is a problem when a program not linked with
-lglusterfs will dlopen() glusterfs component. In
such a case, libc's uuid implementation is already
loaded in the calling program, and it will be used
instead of libglusterfs's implementation, causing
crashes.

A possible workaround is to use pre-load libglusterfs
in the calling program (using LD_PRELOAD on NetBSD for
instance), but such a mechanism is not portable, nor
is it flexible. A much better approach is to rename
libglusterfs's uuid_* functions to gf_uuid_* to avoid
any possible conflict. This is what this change attempts.

BUG: 1206587
Change-Id: I9ccd3e13afed1c7fc18508e92c7beb0f5d49f31a
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/10017
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

symlink-cache: Fixing coverity issues

2015-03-30T07:36:29+00:00

CID: 1124389
Misspelt variable leading to dead code
and memory leak, corrected.

Change-Id: I1278f07f81e2db33640e0f289558d919343cb6ce
BUG: 789278
Signed-off-by: arao 
Reviewed-on: http://review.gluster.org/9694
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur