glusterfs.git/xlators/nfs/server/src, branch v3.7.2

nfs: Authentication performance improvements

2015-06-17T02:03:43+00:00

When file operations are sent to the NFS server, authorized filehandles
are cached using the exportid, mountid, gfid and host as the key to the
cache. This meant that any file OR directory will always fail on the
*first* fop to that filehandle since the cache used the gfid as part of
the key to the cache. However, if an export is authorized, this
effectively means that ALL subdirectories and files in the export
directory are authorized per the permissions of the export. This results
slow times to walking a directory structure over an NFS mount.

Cherry picked from commit a9f58cd6cfc29a47af868fff29ce3133b9f9efe5)
> Change-Id: Iad811ad7255b454d1712e75a637478401d40791e
> BUG: 1232165
> Signed-off-by: Shreyas Siravara 
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/11245
> Reviewed-by: jiffin tony Thottan 
> Reviewed-by: Kaleb KEITHLEY 
> Tested-by: Gluster Build System 

Change-Id: Iad811ad7255b454d1712e75a637478401d40791e
BUG: 1231366
Signed-off-by: Shreyas Siravara 
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/11256
Reviewed-by: jiffin tony Thottan 
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

nfs.c nfs3.c: port log messages to a new framework

2015-06-14T10:45:53+00:00

        Backport of http://review.gluster.org/#/c/10216/

Cherry picked from 6601aad8380f0f0ccbd4bb9147d8d3584a88da20
> Change-Id: I9ddb90d66d3ad3adb2916c0c949834794ee7bdf3
> BUG: 1194640
> Signed-off-by: Hari Gowtham 
> Reviewed-on: http://review.gluster.org/10216
> Tested-by: Gluster Build System 
> Reviewed-by: Niels de Vos 

Change-Id: I9ddb90d66d3ad3adb2916c0c949834794ee7bdf3
BUG: 1217722
Signed-off-by: Hari Gowtham 
Reviewed-on: http://review.gluster.org/11146
Tested-by: Gluster Build System 
Reviewed-by: jiffin tony Thottan 
Reviewed-by: Niels de Vos

nfs: allocate and return the hashkey for the auth_cache_entry

2015-06-09T17:09:22+00:00

The allocation of the hashkey was never returned to the calling
function.

Allocating it with alloca() puts it on the stack, returning from the
function makes the pointer invalid. Functions that are annotated with
"inline" and call alloca(), will not always be inlined. Returning a
pointer allocated with alloca() is in those cases not correct. One such
confirmation was provided by GCC developer Alexandre Oliva:
 - http://gcc.gnu.org/ml/gcc-help/2004-04/msg00158.html

It is more correct to call GF_MALLOC() and GF_FREE() for the hashkey. If
this would result in preformance hit, we can always think of using
alloca() again and turn make_hashkey() into a macro (yuck).

Cherry picked from commit b8b59fea7822f9ab1e10d7a3f730354fe82a6097:
> Change-Id: Ia86a1f79d33240af4713bfb92f702b0ee6e87eb7
> BUG: 1226714
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/11019
> Reviewed-by: Kaleb KEITHLEY 
> Reviewed-by: jiffin tony Thottan 
> Reviewed-by: soumya k 
> Tested-by: Gluster Build System 

Change-Id: Ia86a1f79d33240af4713bfb92f702b0ee6e87eb7
BUG: 1227916
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/11075
Tested-by: Gluster Build System 
Reviewed-by: jiffin tony Thottan

nfs: Use uuid_clear() instead of memset

2015-06-01T09:21:00+00:00

Fixes the following incorrect usage:

mount3.c: In function '__mnt3_build_mountid_from_path':
mount3.c:705:24: warning: 'sizeof' on array function parameter 'mountid' will
return size of 'unsigned char *' [-Wsizeof-array-argument]
         length = sizeof(mountid);
                        ^
mount3.c:699:58: note: declared here
 __mnt3_build_mountid_from_path (const char *path, uuid_t mountid)
                                                          ^
mount3.c: In function '__mnt3_get_mount_id':
mount3.c:732:24: warning: 'sizeof' on array function parameter 'mountid' will
return size of 'unsigned char *' [-Wsizeof-array-argument]
         length = sizeof(mountid);
                        ^
mount3.c:726:46: note: declared here
 __mnt3_get_mount_id (xlator_t *mntxl, uuid_t mountid)

Cherry picked from commit df12f00851a234b0e892af4b958e606a1fa660ed:
> Change-Id: I08f46c5994578fc99a7b61681e808d1115e41d71
> BUG: 1221095
> Signed-off-by: Vijay Bellur 
> Reviewed-on: http://review.gluster.org/10765
> Reviewed-by: Niels de Vos 
> Reviewed-by: Kaleb KEITHLEY 
> Tested-by: Gluster Build System 

Change-Id: I08f46c5994578fc99a7b61681e808d1115e41d71
BUG: 1222198
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/10798
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Kaleb KEITHLEY

nfs: allocate the auth_cache->cache_dict on auth_cache_init()

2015-05-08T03:07:03+00:00

It seems possible that auth_cache->cache_dict is not always allocated
before it is accessed. Instead of allocating the dict upon the 1st
access, just create it in auth_cache_init().

Cherry picked from commit eb8847703b8560a045e7ed0336f895bcceda98ea:
> Change-Id: I00e60522478b433cb0aae0c1f0948eac544dfd2b
> URL: http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10710
> BUG: 1143880
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/10600
> Tested-by: Gluster Build System 
> Reviewed-by: Kaleb KEITHLEY 
> Reviewed-by: jiffin tony Thottan 
> Tested-by: NetBSD Build System

Change-Id: I00e60522478b433cb0aae0c1f0948eac544dfd2b
BUG: 1212182
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/10655
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Gluster Build System

nfs : fix for coredump caused by export/netgroup feature in the regression

2015-05-07T11:45:58+00:00

      Backport of http://review.gluster.org/#/c/10250/

cherry-picked from 306585d2e57aadc7d15951ab1114d49fd9dbf5aa
>Change-Id: Idaae234b9e81c40040393e748db1f61363a48ed0
>BUG: 1211913
>Signed-off-by: Jiffin Tony Thottan 
>Reviewed-on: http://review.gluster.org/10250
>Tested-by: Gluster Build System 
>Reviewed-by: Niels de Vos 

Change-Id: Ic6d6b2f8fc0629678f0adb59e967e73c0923977a
BUG: 1212182
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: http://review.gluster.org/10618
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

nfs / nfs files : porting log messages to a new framework

2015-05-07T08:07:28+00:00

        Backport of http://review.gluster.org/#/c/10214/

Porting log messages to a new framework for nfs-common.c,
nfs-fops.c, nfs-fops.h, nfs-inodes.c, nfs3-fh.c, nfs3-helpers.c.

Cherry picked from f3ff9abbe5f80911a88222cbdbcfa8616b4743da
> Change-Id: I55cd94de62eafe6ad3754cd065d7459a81a9f285
> BUG: 1194640
> Signed-off-by: Manikandan Selvaganesh 
> Reviewed-on: http://review.gluster.org/10214
> Tested-by: Gluster Build System 
> Reviewed-by: Niels de Vos 

Change-Id: I55cd94de62eafe6ad3754cd065d7459a81a9f285
BUG: 1217722
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/10550
Tested-by: NetBSD Build System
Reviewed-by: jiffin tony Thottan 
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System

nfs / mount files : porting log messages to a new framework

2015-05-06T20:35:33+00:00

        Backport of http://review.gluster.org/#/c/10210/

Porting log messages to a new framework for mount3udp_svc.c,
mount3.c, mount3-auth.c files.

Cherry picked from ee6cd10ce947787bf6ea589bca1cb259c4bb214d
> Change-Id: I1e9cab500b6052bfac43c5ae1c82278e20d2f898
> BUG: 1194640
> Signed-off-by: Manikandan Selvaganesh 
> Reviewed-on: http://review.gluster.org/10210
> Tested-by: Gluster Build System 
> Reviewed-by: Niels de Vos 

Change-Id: I1e9cab500b6052bfac43c5ae1c82278e20d2f898
BUG: 1217722
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/10551
Tested-by: Gluster Build System 
Reviewed-by: jiffin tony Thottan 
Reviewed-by: Niels de Vos

nfs / acl3.c, nlm files : port log messages to a new framework

2015-05-06T20:27:32+00:00

        Backport of http://review.gluster.org/#/c/10217/

Porting log messages to a new framework for acl3.c, nlm4.c,
nlmcbk_svc.c

Cherry picked from a7f848245ae5b0e4bbe363de13ec1676753352c5
> Change-Id: Iee4daae4fe1460eddf95d285615335b836d7f958
> BUG: 1194640
> Signed-off-by: Manikandan Selvaganesh 
> Reviewed-on: http://review.gluster.org/10217
> Tested-by: Gluster Build System 
> Reviewed-by: Niels de Vos 

Change-Id: Iee4daae4fe1460eddf95d285615335b836d7f958
Signed-off-by: Manikandan Selvaganesh 
BUG: 1217722
Reviewed-on: http://review.gluster.org/10549
Tested-by: Gluster Build System 
Reviewed-by: jiffin tony Thottan 
Reviewed-by: Niels de Vos

nfs/auth,exports,netgroup : port log messages to a new framework

2015-05-06T19:08:38+00:00

Five gf_log messages are not changed to gf_msg because gf_msg
not sending the output to STDOUT.
Bug id : BZ1218506

Cherry picked from de7c629d02b723e6b4c3d50a14ea5f072e27ccc1
> Change-Id: Ie8de286355becc3fd73fa80057734b834cf40b04
> BUG: 1194640
> Signed-off-by: Manikandan Selvaganesh 
> Reviewed-on: http://review.gluster.org/10173
> Tested-by: Gluster Build System 
> Reviewed-by: Niels de Vos 
> Reviewed-by: jiffin tony Thottan 

Change-Id: Ie8de286355becc3fd73fa80057734b834cf40b04
Signed-off-by: Manikandan Selvaganesh 
BUG: 1217722
Reviewed-on: http://review.gluster.org/10546
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System
Reviewed-by: jiffin tony Thottan 
Reviewed-by: Niels de Vos