glusterfs.git/xlators/nfs/server/src, branch v3.1.0qa8

xlators/nfs: nfs3-helpers.c remove dead assignments.

2010-08-23T05:27:35+00:00

Signed-off-by: Sachidananda Urs 
Signed-off-by: Anand V. Avati 

BUG: 1115 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1115

xlators/nfs: nfs3.c - remove dead assignments.

2010-08-23T05:27:30+00:00

Removed dead assignments and unused variables reported by clang.

One of the reports uncovers a minor bug in gnfs.
> Dead store  Dead assignment  xlators/nfs/server/src/nfs3.c  2860  1

A separate bug is logged for the above report and assigned to Shehjar.

Signed-off-by: Sachidananda Urs 
Signed-off-by: Anand V. Avati 

BUG: 1114 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1114

rpm spec: Use only 3 rpms for GlusterFS

2010-08-17T09:23:42+00:00

Generates the following 3 rpms:
1. glusterfs-fuse
2. glusterfs-main
3. glusterfs-ibverbs

Signed-off-by: Pavan Vilas Sondur 
Signed-off-by: Anand V. Avati 

BUG: 1275 (Fix rpm glusterfs spec file for 3.1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1275

minor assignement errors reported by clang fixed

2010-08-12T10:55:08+00:00

Signed-off-by: Kaushik BV 
Signed-off-by: Anand V. Avati 

BUG: 1117 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1117

nfs: Do not build nfs/rpc as shared library

2010-08-10T09:44:26+00:00

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Anand V. Avati 

BUG: 1274 (nfs fails to start)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1274

nfs, nfs/rpc: Rename functions to prevent gfrpcsvc conflict

2010-08-10T09:44:22+00:00

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Anand V. Avati 

BUG: 1274 (nfs fails to start)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1274

nfs3: NULL fdentry check before removing from fdcache

2010-07-28T10:10:02+00:00

Suppose a file name 1 is created and some data is written to it. After this
another 512 files are newly created and written to. When the the 513th file is
created and an fd_t opened for it, it results in 1's fd_t being replaced in the
fd-lru with 513th file's fd_t. This is the correct behaviour resulting in all
refs getting unref from the fd_t of 1 and the fd and all related state being
freed.

But, in some workloads, some refs are still pending even after the fd_t is
removed from LRU, resulting in the fd still being bound to the inode. In
nfs3svc_remove_cbk, while removing the inode state, we also ensure that any
fd_ts in the cache for this inode are also removed. While removing the fd_t,
this situation where the fd_t has replaced with another, even while a ref
remains on the fd_t, results in a crash in the fdcache_remove path in
nfs3svc_remove_cbk. This happens because the fd_ctx_get results in a NULL value
because the ctx was already deleted when this fd_t was removed from fd-lru
earlier. This patch fixes the crash by introducing a NULL check.

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Anand V. Avati 

BUG: 885 ([NFS Xlator] Crash in nfs3_fdcache_update)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=885

nfs3: Error returns must check for <0, not == -1

2010-07-28T09:24:45+00:00

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Anand V. Avati 

BUG: 854 (nfs server didn't start)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=854

nfs3: Return ESTALE when fh resolver exhausts dirents

2010-07-28T09:24:41+00:00

During hard fh resolution, if a directory traversal goes right
through to end-of-dir without finding a hash match, we need to return
an ESTALE, not ENOENT.

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Anand V. Avati 

BUG: 854 (nfs server didn't start)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=854

nfs3: Stop ESTALE from falling into SERVERFAULT

2010-07-28T09:24:37+00:00

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Anand V. Avati 

BUG: 854 (nfs server didn't start)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=854