glusterfs.git/xlators/nfs/server/src, branch v3.1.0qa2

nfs3: Fix race updating op queue on uncached fd open

2010-07-06T12:58:52+00:00

The order of locking while performing async fd opens was resulting in
a deadlock when a particular pattern of operations was generated by
compilebench. This patch improves handling of those situations while
locking the fd-cache, inode and inode queue.

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Anand V. Avati 

BUG: 1047 (Compilebench hangs nfs server)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1047

nfs: Assign incremental lk owner to frames

2010-07-05T05:52:55+00:00

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Anand V. Avati 

BUG: 960 (Disk space leakage and fs corruption after VMs are vmotion'ed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=960

nfs: Support directory level exports

2010-07-05T05:52:51+00:00

nfsx has followed traditional approach of exporting whole volumes
as NFS exports. The Platform requires and some users have approached us for
introducing exports of only specific directories instead of full Gluster
volumes. This commit introduces this support through two nfsx options:

Option 1:

=========
option nfs3..export-dir ,,..

export-dir will allow the export of a particular dir as a single export
by itself. For eg.:

volume posix
        type storage/posix
        option directory /export/
end-volume

volume posix-ac
        type features/access-control
        subvolumes posix
end-volume

volume nfs
        type nfs/server
        subvolumes posix-ac
        option rpc-auth.addr.allow *
        option nfs3.posix-ac.export-dir /homes/shehjart
end-volume

A comma separate list of sub-directories will set up those dirs as separated exports.
At the nfs client, the mount command will be:

$ mount :/posix-ac/homes/shehjart /mnt

Option 2:
=========
option nfs3..export-volumes 

There can be situations where users only want the directory level
exports and require that volume exports be completely disabled. The
above option allows us to do this. By default, volume exports are
enabled. From the earlier example, replacing  with
posix-ac, will disable mounting of the posix-ac volume as a whole.

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Anand V. Avati 

BUG: 989 (Support directory exports in nfsx)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=989

NULL dereference fixes in code base after running with 'clang'

2010-07-02T12:17:03+00:00

* 212 logical (NULL deref/divide by zero) errors reduced to 28
  (27 of them in contrib/ and lex part of codebase, 1 is invalid)
* 11 API errors reduced to 0

Signed-off-by: Amar Tumballi 
Signed-off-by: Anand V. Avati 

BUG: 966 (NULL check for avoiding NULL dereferencing of pointers..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=966

mem-types: include *-mem-types.h in noinst_HEADERS variables in all Makefile.am

2010-06-08T12:25:07+00:00

Signed-off-by: Anand V. Avati 
Signed-off-by: Anand V. Avati 

BUG: 329 (Replacing memory allocation functions with mem-type functions)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=329

mount3: Handle unmount for unknown volume names

2010-06-01T07:23:58+00:00

In case the nfs client sends an unmount request for a volume
that does not exist anymore.

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Anand V. Avati 

BUG: 961 (Unmount with invalid export crashes nfsx)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=961

mount3: Handle as well for unmount dirpath

2010-06-01T07:23:54+00:00

Till now nfsx would crash if the export was mounted simply as
 as compared to the traditional method of /.

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Anand V. Avati 

BUG: 944 (vmware unmount crashes nfsx)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=944

nfs3: Special-case the lookup for parent dir of root

2010-06-01T07:23:51+00:00

When a lookup request comes in for (rootfh, ".."), we need to handle
it in a way that returns the attributes and handle of the root dir.
Not doing so crashes nfsx because the inode table is not able to
find a inode for the root's parent. This inode was being referenced in
nfs3_lookup_parentdir_resume when filling a loc for the lookup fop.

For the record, such a lookup request is sent by vmkernel.

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Anand V. Avati 

BUG: 942 (NFS crashes as a vmware ESX data store)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=942

nfs3: Funge . and .. ino/gen in readdir of root

2010-06-01T07:23:46+00:00

In the readdir reply for the root of the export, replace the ino
and gen number for the . and .. entries with 1 and 0 respectively.
On clients which inspect this field, the client will error out due
to the change in inode number of the root directory when see for "."

.. also needs to be replaced because we do not have a concept of
the parent directory of root. The return of 1 and 0 is the same as
the behaviour of: stat /.. command.

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Anand V. Avati 

BUG: 942 (NFS crashes as a vmware ESX data store)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=942

nfs: Introduce trusted-write and trusted-sync options

2010-05-21T07:32:04+00:00

Introduces two new options:

1. nfs3.*.trusted-write: Forces UNSTABLE writes to return STABLE to NFS
clients to prevent the clients from sending a COMMIT. STABLE writes
are still handled in a sync manner and so are COMMITs if they're sent
at all.

2. nfs3.*.trusted-sync: Forces all WRITEs and COMMITs to return STABLE
return flags to NFS clients to avoid the overhead of STABLE writes, and
COMMITs that follow UNSTABLE writes. This includes the trusted-write
functionality. In addition to the trusted-write, it also writes
STABLE writes in an UNSTABLE manner.

Both violate the NFS protocol but allow better write perf in most
configurations. Use with caution.

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Anand V. Avati 

BUG: 924 (Slow NFS synchronous writes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=924