glusterfs.git/xlators/nfs/server/src/nfs3.h, branch v3.2.5qa6

nfs3: Resolve entry vs. hash conflict at same dir depth

2011-09-08T06:53:55+00:00

Intro Note
==========
The current code in hard fh resolution takes the first-match approach, i.e.
which ever dirent either matches the hash or matches the gfid first
is the one chosen as the result for the next step of fh resolution. In
the latter case, i.e., dirent matches the gfid, we the next step is to
conclude the fh resolution by returning the entry whose gfid matched.
In the former, i.e., the hash matches the dirent, we choose the hash-matching
dirent as the next directory to descend into, for searching the file to be
operated upon.

Problem
=======
When performing hard fh resolution, there can be a situation where:

o the hash of the primary entry,i.e. the entry we're looking for and the hash
of another sibling directory, match. Note the use of "sibling", meaning both
the primary entry and the hash matching one are in the same directory, i.e.,
their filehandle.hashcount will be same.

o the sibling directory is encountered first during the dir search.

Because of the current code described in "Intro", we'll end up descending into
the sibling directory even though the correct behaviour is to ignore this and
wait till we encounter the primary entry in the same parent directory.

Once we end up descending into this sibling directory, the directory depth
validation check fails. The check fails because it notices that the resolution
is attempting to open a directory that is deeper in the fs tree than the file
we're looking for. When this check fails, we return an ESTALE. So basically, a
false-positive results in an estale to Specsfs.

This is not a theoretical situation. Me and Avati saw this on specsfs test
where sfs created terabytes-sized file system for its tests. The number of
files was so huge in a single directory that the hashes of two entries ended up
colliding.

Change-Id: I78d8756252330201e165d788a29277b4bce0df90
BUG: 3510
Reviewed-on: http://review.gluster.com/358
Tested-by: Gluster Build System 
Reviewed-by: Shehjar Tikoo

Change Copyright current year

2011-08-10T17:57:44+00:00

Change-Id: Id1f1a91cf15d933d5621a0073ddaebe02df0f159
BUG: 3348
Reviewed-on: http://review.gluster.com/198
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

LICENSE: s/GNU Affero General Public/GNU General Public/

2011-08-06T13:40:14+00:00

Change-Id: Ibf5f45431d7a55b70d7304649af652d6f25bb688
BUG: 3348
Reviewed-on: http://review.gluster.com/183
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

nfs3: Force root lookup before starting fh resolution

2010-12-29T18:20:50+00:00

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Anand V. Avati 

BUG: 2200 (cp dies with "Invalid argument" after failover)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2200

nfs3: Prevent second lookup on a fresh entry lookup

2010-11-25T14:35:34+00:00

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Anand V. Avati 

BUG: 1756 (NFS must revalidate inode on first ESTALE on lookup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1756

nfs3: Fresh inode lookup on failed revalidation

2010-11-25T14:35:19+00:00

Brings in changes that were earlier introduced in commit:
f5afcc47f9f00472d6c2b3f48127e02332cd457a

but reverted because the patch was buggy and caused a seg-fault
due to extra inode_unrefs.

It fixes that extra inode_unref and cleans up the revalidation logic.

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Anand V. Avati 

BUG: 1756 (NFS must revalidate inode on first ESTALE on lookup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1756

Revert "nfs: Use only 38467 as default port instead of 3846[567]"

2010-11-15T12:03:55+00:00

This reverts commit be5c02a81c19336a6b922b1e1f28293c90955e7f.

By default, continue to register the three original port numbers
so that an upgrade to future version from 3.1 release does not
break mount requests against portmap, which may have old port
numbers registered.

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Anand V. Avati 

BUG: 1743 (XenServer is not compatible with GlusterNFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1743

nfs: Use only 38467 as default port instead of 3846[567]

2010-11-09T10:11:59+00:00

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Anand V. Avati 

BUG: 1743 (XenServer is not compatible with GlusterNFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1743

Revert "nfs3: Revalidate inode on receiving ESTALE on lookup"

2010-10-12T07:11:19+00:00

This reverts commit f5afcc47f9f00472d6c2b3f48127e02332cd457a.

Signed-off-by: Anand V. Avati 
Signed-off-by: Vijay Bellur 

BUG: 1756 (NFS must revalidate inode on first ESTALE on lookup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1756

Revert "Revert "nfs3: Revalidate inode on receiving ESTALE on lookup""

2010-10-11T19:31:26+00:00

This reverts commit 6dd3b7fa3bc7acf9281cc17f08010675e2297089.