glusterfs.git/xlators/nfs/server/src/nfs3.c, branch v3.1.0qa31

nfs, nfs3: Base volume access on CHILD-UP-DOWN event

2010-09-22T11:14:27+00:00

Overall, the aim of this patch is to change the result of an nfs
op depending on whether the underlying volume is up or down
as notified by CHILD_UP and CHILD_DOWN events.

This patch contains three intertwined changes:
o Only when the lookup on the root of a volume is successful does gnfs now
export the subvolume. Till now the result of the lookup was not used to
determine whether we should export that volume. Not accounting for root lookup
failure resulted in ESTALEs on first access because some children of distribute
were down at the time of the root lookup.

o Only when lookups on all the subvolumes have succeeded are
these exports enabled through NFS.

o When a child of say distribute goes down, on CHILD_DOWN event nfs will
ignore all incoming requests from the client because ignoring these
will prevent ESTALEs for those requests and in the hope that ignoring the
requests will make the client retransmit. There are risks in this approach
absent the DRC but we're willing to live with that for now.
When a child goes down, the mount exports list will continue to show it
but mount requests will be denied.

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Vijay Bellur 

BUG: 1643 (Initial requests after mount ESTALE if DHT subvolumes connect after nfs startup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1643

nfs3: Unref & unbind dir fd with inode lock on EOF

2010-09-17T13:24:01+00:00

..so that when EOF is reached on this fd, any further
requests on the same inode do not get handled through this
fd but result in a new fd being opened.

Unbinding results in the fd getting deleted from the inode's fd list.

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Vijay Bellur 

BUG: 1619 (glusterfs nfs server crashed on dht+replica(2x2))
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1619

nfs3: Copy deviceid from correct gfid start octet

2010-09-15T11:55:18+00:00

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Vijay Bellur 

BUG: 1600 (showmount works but unable to mount)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1600

nfs,nfs3,mnt3: Transition fh resolution to gfid

2010-09-14T09:32:03+00:00

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Vijay Bellur 

BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971

nfs3: Do not unref dst inode on rename cbk

2010-09-02T12:17:19+00:00

This gets done when the call state gets wiped. Doing it here results
an extra unref causing a segfault.

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Vijay Bellur 

BUG: 1464 (fd leak after rename)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1464

nfs3: Free vectored write args using FREE not GF_FREE

2010-09-02T12:17:06+00:00

..because the file handle in write3args is allocated inside
libc using malloc not memory accounting code in glusterfs.

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Vijay Bellur 

BUG: 1499 (GNFS from mainline Glusterfs-3.1-qa13 crashes while initiating SFS2008)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1499

nfs3: Close dst cached fd & unref inode on rename

2010-08-31T14:44:50+00:00

If the src file is over-writing an existing file and if the
destination file is open, then  close the cached fd on the
destination file and unref the inode for it.

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Vijay Bellur 

BUG: 1464 (fd leak after rename)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1464

nfs3: Dont ref dir fd_t used in hard fh resolution

2010-08-31T14:44:18+00:00

..because the extra ref was under the mistaken assumption that
directory fd_t will be cached even during hard fh resolution and
that is not the case.

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Vijay Bellur 

BUG: 1397 (Cached dir fd_ts are a leakin')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1397

xlators/nfs: nfs3.c - remove dead assignments.

2010-08-23T05:27:30+00:00

Removed dead assignments and unused variables reported by clang.

One of the reports uncovers a minor bug in gnfs.
> Dead store  Dead assignment  xlators/nfs/server/src/nfs3.c  2860  1

A separate bug is logged for the above report and assigned to Shehjar.

Signed-off-by: Sachidananda Urs 
Signed-off-by: Anand V. Avati 

BUG: 1114 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1114

nfs, nfs/rpc: Rename functions to prevent gfrpcsvc conflict

2010-08-10T09:44:22+00:00

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Anand V. Avati 

BUG: 1274 (nfs fails to start)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1274