glusterfs.git/xlators/nfs/server/src/mount3.c, branch v3.7.14

nfs: build exportlist with multiple groupnodes

2016-07-03T11:15:35+00:00

The EXPORT procedure of the MOUNT protocol does not correctly create
structures for the 'groupnodes' in the reply. Each 'groupnode' should be
a single entry in the 'nfs.rpc-auth-allow' volume option. Because the
value is handled as a single string, the encoding of the
groupnode->gr_name fails when the value of the volume option is longer
than 255 characters.

In the error case, encoding the EXPORTS reply fails, and the waiting
'showmount' command will not receive a reply and times out.

Splitting the allowed entries and creating a groupnode for each one
prevents the too long ->gr_name. This is following the structures for
the EXPORTS reply in the MOUNT protocol more correctly as well. Note
that the contents of ->gr_name is expected to be server dependent.

This is backport of below mainline fix -
	http://review.gluster.org/#/c/14667/

Change-Id: Ibbabad581cc9aa00feb80fbbc851a1b10b28383d
BUG: 1343290
Signed-off-by: Niels de Vos 
Signed-off-by: Bipin Kunal 
Reviewed-on: http://review.gluster.org/14698
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

nfs: send lookup if inode_ctx is not set

2016-02-22T14:49:05+00:00

During resolving of an entry or inode, if inode ctx
was not set, we will send a lookup.

This patch also make sure that inode_ctx will be created
after every inode_link.

Back port of>
>Change-Id: I137a7e2510635ff4ea6d007b671961341f89c949
>BUG: 1297311
>Signed-off-by: Mohammed Rafi KC 
>Reviewed-on: http://review.gluster.org/13224
>Reviewed-by: soumya k 
>Tested-by: NetBSD Build System 
>Reviewed-by: Dan Lambright 
>Tested-by: Dan Lambright 

Change-Id: I2034521e23ef24ac75f80aff736abf5811fc0de6
BUG: 1306131
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/13413
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Dan Lambright

all: reduce "inline" usage

2016-01-18T09:02:34+00:00

There are three kinds of inline functions: plain inline, extern inline,
and static inline.  All three have been removed from .c files, except
those in "contrib" which aren't our problem.  Inlines in .h files, which
are overwhelmingly "static inline" already, have generally been left
alone.  Over time we should be able to "lower" these into .c files, but
that has to be done in a case-by-case fashion requiring more manual
effort.  This part was easy to do automatically without (as far as I can
tell) any ill effect.

In the process, several pieces of dead code were flagged by the
compiler, and were removed.

backport of Change-Id: I56a5e614735c9e0a6ee420dab949eac22e25c155,
http://review.gluster.org/11769, BUG: 1245331

Change-Id: Iba1efb0bc578ea4a5e9bf76b7bd93dc1be9eba44
BUG: 1283302
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/12646
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos

nfs: Fixes "Remote I/O error" mount failures

2015-10-30T16:21:22+00:00

- Fixes issue where NFS mount fail with "Remove I/O error" after the
  target directory has been deleted and re-created after the gNFSd has
  already cached the inode of the first generation of the target
  directory.
- The solution is to follow the guidance of the AFR2 comments and
  refresh the inode by deleting it from cache and looking it up
  again.

BUG: 1258197
Change-Id: I9c7d8bd460ee9e5ea0b5b47d23886b1afcdcd563
Reported-by: Richard Wareing 
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/12047
Tested-by: Gluster Build System

nfs: Use uuid_clear() instead of memset

2015-06-01T09:21:00+00:00

Fixes the following incorrect usage:

mount3.c: In function '__mnt3_build_mountid_from_path':
mount3.c:705:24: warning: 'sizeof' on array function parameter 'mountid' will
return size of 'unsigned char *' [-Wsizeof-array-argument]
         length = sizeof(mountid);
                        ^
mount3.c:699:58: note: declared here
 __mnt3_build_mountid_from_path (const char *path, uuid_t mountid)
                                                          ^
mount3.c: In function '__mnt3_get_mount_id':
mount3.c:732:24: warning: 'sizeof' on array function parameter 'mountid' will
return size of 'unsigned char *' [-Wsizeof-array-argument]
         length = sizeof(mountid);
                        ^
mount3.c:726:46: note: declared here
 __mnt3_get_mount_id (xlator_t *mntxl, uuid_t mountid)

Cherry picked from commit df12f00851a234b0e892af4b958e606a1fa660ed:
> Change-Id: I08f46c5994578fc99a7b61681e808d1115e41d71
> BUG: 1221095
> Signed-off-by: Vijay Bellur 
> Reviewed-on: http://review.gluster.org/10765
> Reviewed-by: Niels de Vos 
> Reviewed-by: Kaleb KEITHLEY 
> Tested-by: Gluster Build System 

Change-Id: I08f46c5994578fc99a7b61681e808d1115e41d71
BUG: 1222198
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/10798
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Kaleb KEITHLEY

nfs / mount files : porting log messages to a new framework

2015-05-06T20:35:33+00:00

        Backport of http://review.gluster.org/#/c/10210/

Porting log messages to a new framework for mount3udp_svc.c,
mount3.c, mount3-auth.c files.

Cherry picked from ee6cd10ce947787bf6ea589bca1cb259c4bb214d
> Change-Id: I1e9cab500b6052bfac43c5ae1c82278e20d2f898
> BUG: 1194640
> Signed-off-by: Manikandan Selvaganesh 
> Reviewed-on: http://review.gluster.org/10210
> Tested-by: Gluster Build System 
> Reviewed-by: Niels de Vos 

Change-Id: I1e9cab500b6052bfac43c5ae1c82278e20d2f898
BUG: 1217722
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/10551
Tested-by: Gluster Build System 
Reviewed-by: jiffin tony Thottan 
Reviewed-by: Niels de Vos

nfs: make it possible to disable nfs.mount-rmtab

2015-05-03T18:16:09+00:00

When there are many NFS-clients doing very often mount/unmount actions,
the updating of the 'rmtab' can become a bottleneck and cause delays. In
these situations, the output of 'showmount' may be less important than
the responsiveness of the (un)mounting.

By setting 'nfs.mount-rmtab' to the value "/-", the cache file is not
updated anymore, and the entries are only kept in memory.

Cherry picked from commit 331ef6e1a86bfc0a93f8a9dec6ad35c417873849:
> BUG: 1169317
> Change-Id: I40c4d8d754932f86fb2b1b2588843390464c773d
> Reported-by: Cyril Peponnet 
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/9223
> Tested-by: Gluster Build System 
> Reviewed-by: soumya k 
> Reviewed-by: jiffin tony Thottan 
> Reviewed-by: Kaleb KEITHLEY 

This change also contains the fixes to the test-case from:
>
> nfs: fix spurious failure in bug-1166862.t
>
> In some environments, "showmount" could return an NFS-client that does
> not start with "1". This would cause the test-case to fail. The check is
> incorrect, the number of lines should get counted instead.
>
> Also moving the test-case to the .../nfs/... subdirectory.
>
> Cherry picked from commit ee9b35a780607daddc2832b9af5ed6bf414aebc0:
> BUG: 1166862
> Change-Id: Ic03aa8145ca57d78aea01564466e924b03bb302a
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/10419
> Tested-by: Gluster Build System 
> Reviewed-by: Vijay Bellur 
>

Change-Id: I40c4d8d754932f86fb2b1b2588843390464c773d
BUG: 1215385
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/10379
Tested-by: NetBSD Build System
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

Avoid conflict between contrib/uuid and system uuid

2015-04-04T17:48:35+00:00

glusterfs relies on Linux uuid implementation, which
API is incompatible with most other systems's uuid. As
a result, libglusterfs has to embed contrib/uuid,
which is the Linux implementation, on non Linux systems.
This implementation is incompatible with systtem's
built in, but the symbols have the same names.

Usually this is not a problem because when we link
with -lglusterfs, libc's symbols are trumped. However
there is a problem when a program not linked with
-lglusterfs will dlopen() glusterfs component. In
such a case, libc's uuid implementation is already
loaded in the calling program, and it will be used
instead of libglusterfs's implementation, causing
crashes.

A possible workaround is to use pre-load libglusterfs
in the calling program (using LD_PRELOAD on NetBSD for
instance), but such a mechanism is not portable, nor
is it flexible. A much better approach is to rename
libglusterfs's uuid_* functions to gf_uuid_* to avoid
any possible conflict. This is what this change attempts.

BUG: 1206587
Change-Id: I9ccd3e13afed1c7fc18508e92c7beb0f5d49f31a
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/10017
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

Xlators : Fixed typos

2015-04-02T10:21:08+00:00

Change-Id: I948f85cb369206ee8ce8b8cd5e48cae9adb971c9
BUG: 1075417
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/9529
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Humble Devassy Chirammal

gNFS: Export / Netgroup authentication on Gluster NFS mount

2015-03-15T14:01:38+00:00

* Parses linux style export file/netgroups file into a structure that
  can be lookedup.

* This parser turns each line into a structure called an "export
  directory". Each of these has a dictionary of hosts and netgroups
  which can be looked up during the mount authentication process.
  (See Change-Id Ic060aac and I7e6aa6bc)

* A string beginning withan '@' is treated as a netgroup and a string
  beginning without an @ is a host.
  (See Change-Id Ie04800d)

* This parser does not currently support all the options in the man page
  ('man exports'), but we can easily add them.

BUG: 1143880
URL: http://www.gluster.org/community/documentation/index.php/Features/Exports_Netgroups_Authentication
Change-Id: I181e8c1814d6ef3cae5b4d88353622734f0c0f0b
Original-author: Shreyas Siravara 
CC: Richard Wareing 
CC: Jiffin Tony Thottan 
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/8758
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur