glusterfs.git/xlators/mount, branch v3.3.2

mount/fuse: add mount-option "enable-ino32" for the native client

2013-02-07T21:38:20+00:00

By default the GlusterFS-native client uses 64-bit inodes. Some 32-bit
applications can not handle these correctly. Introduce a client-side
mount option "enable-ino32" which causes the FUSE-client to squash the
64-bit inodes into a 32-bit value.

Change-Id: I7544010a27b7eb2d3b9fadb84ed934e4e7dff21e
BUG: 850352
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/3886
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

glusterfs SEGV on Fedora 17 from UFO fallocate(2) call

2012-09-17T21:49:59+00:00

An upload of a file will cause the volume's glusterfs to SEGV
when it fields a FUSE_FALLOCATE op. Swift inspects libc to determine
if there is a symbol for fallocate(2) and if so will use it. And
while the libc in RHEL 6 does have fallocate(2), the version of
fuse in RHEL 6 does not support fallocate, and things are handled
gracefully elsewhere (the kernel perhaps?)

N.B. fallocate was added to version 7.19 of fuse. Fedora 17 and
later (and maybe earlier too) has 7.19. RHEL 6 still has 7.13.
Glusterfs uses the 7.13 version 
(in contrib/fuse-include/fuse_kernel.h)

Thus on Fedora 17, with both fallocate(2) in libc and fallocate
support in fuse, the fallocate invocation is dispatched to glusterfs,
but the dispatch table (fuse_std_ops in
xlators/mount/fuse/src/fuse-bridge.c) is too short for one thing;
the fallocate opcode (43) indexes beyond the end of the table, and
even when that doesn't directly cause a SEGV, the NULL pointer at
that location does cause a SEGV when attempting to call the function
through the pointer.

BUG: 856704
Change-Id: Iffe3994dde6ca29444d07d27eb04d6f86773fa03
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/3941
Tested-by: Gluster Build System 
Reviewed-by: Mohammed Junaid 
Reviewed-by: Anand Avati

mount.glusterfs: Add support for {attribute,entry}-timeout options

2012-09-17T19:12:23+00:00

Change-Id: Ib0c9b5be6f05cf9a36271df67e5e5c251c4c4628
BUG: 829279
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/3840
Tested-by: Gluster Build System 
Reviewed-by: Brian Foster 
Reviewed-by: Jeff Darcy 
Reviewed-by: Vijay Bellur

mount.glusterfs NerBSD portability fix

2012-09-12T19:39:41+00:00

NetBSD stat(1) gets inode using -f %i while Linux uses -c %i
This has already been fixed a few lines above, but one test
failed to be fixed.

This is not based on master, as the code hasbeen reworked a lot,
and is already bug-free.

BUG: 764655
Change-Id: I5dc1196ddba06ff31f695b7dbb0c6d28df32f324
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/3926
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

NetBSD build fixes

2012-07-13T21:08:22+00:00

This is a backport of Change-Id: Icd7290f1e340675d763665a0d0c5f95bc14e0c55

BUG: 764655
Change-Id: Iaca3dc30e61c0864af673b90d2a7fdea6a3143cc
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.com/3577
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

Set LD_LIBRARY_PATH before starting glusterfs

2012-07-09T12:41:28+00:00

This is a backport of Change-Id: I13bf0bea043351498b4bc885c5ac45b108229a0a

BUG: 764655
Change-Id: I7908352f7a9baae48a7c3bd2c8845980d0dc9b96
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.com/3578
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

stat(1) flag to specify format is not portable

2012-07-09T12:40:34+00:00

This is a backport of Change-Id: Iae3c40b03118078530c29d14d5f7180c36361c16

BUG: 764655
Change-Id: Ic4e7adbda6b53b248aa93cd20a045cb885fa818e
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.com/3579
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

mount.glusterfs: update the glusterd WORKDIR

2012-07-03T12:02:44+00:00

Change-Id: I70d091611d314598412b5315adcbe1b5147a8773
Signed-off-by: Amar Tumballi 
BUG: 824231
Reviewed-on: http://review.gluster.com/3512
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

fuse: make SELinux support configurable

2012-05-30T05:58:07+00:00

Make support for SELinux labels (extended attributes) configurable
and disabled by default as it can cause significant performance
penalty when enabled (it need not be enabled unless specially crafted
policies are set -- which is not by default)

Change-Id: I97bc4b1c26cf055fd520e9bf2d49e52b14fe7515
BUG: 811217
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.com/3485
Tested-by: Gluster Build System

fuse, glusterfsd: mount logic fixes

2012-05-27T16:55:47+00:00

Commit 7d0397c2 introduced two issues:

 i) broke the libfuse derived mount logic (details below)
ii) in case of a daemonized glusterfs client is ran as daemon, parent
    process can return earlier than the mount is in place, which breaks
    agents that programmatically do a gluster mount via a direct call to
    glusterfs (ie. not via mount(8)).

This patch fixes these issues by a refactor that merges the approaches
sported by commits

  7d0397c2 fuse: allow requests during mount (needed for SELinux labels)
  c5d781e0 upon daemonizing, wait on mtab update to terminate in parent

Original daemonized libfuse event flow is as follows:

  try:
    fd = open("/dev/fuse")
    mount("-oopts,fd=%s" % fd ...)
    mount(8) -f    # manipulate mtab
  except:
    sp = socketpair()
    env _FUSE_COMMFD=sp fusermount -oopts
    fd = receive_fd(sp)

  where fusermount(1) does:
    fd = open("/dev/fuse")
    mount("-oopts,fd=%d" % fd ...)
    sp = atoi(getenv("_FUSE_COMMFD"))
    send_fd(sp, fd)

  daemonize(
    # in child
    fuse_loop(fd)
  )
  # in parent
  exit()

As of 013850c9 (instead of adopting FUSE's 47e61004¹), we went for async
mtab manipulation, and as of c5d781e0, still wanted keep that in sync
with termination of daemon parent, so we changed it to:

  try:
    fd = open("/dev/fuse")
    mount("-oopts,fd=%s" % fd ...)
    pid = fork(
      # in child
      mount(8) -f
    )
  except:
    sp = socketpair()
    env _FUSE_COMMFD=sp fusermount -oopts
    fd = receive_fd(sp)

  daemonize(
    fuse_loop(fd)
  )
  waitpid(pid)
  exit()

(Note the new approch came only to direct [privileged] mount, so fusermount
based mounting was already partially broken.)

As of 7d0397c2, with the purpose of facilitating async mount, the event flow
was practically reduced to:

  fd = open("/dev/fuse")
  fork(
    mount("-oopts,fd=%s" % fd ...)
    fork(
      mount(8) -n
    )
  )

  daemonize(
    fuse_loop(fd)
  )
  exit()

Thus fusermount based mounting become defunct; however, the dead
code was still kept around. So, we should either drop it or fix
it. Also, the mtab manipulator is forked into yet another child
with no purpose, while syncing with it in daemon parent is broken.
mount(2) is neither synced with parent.

Now we are coming to the following scheme:

  fd = open("/dev/fuse")
  pid = fork(
    try:
      mount("-oopts,fd=%s" % fd ...)
      mount(8) -n
    except:
      env _FUSE_DEVFD=fd fusermount -oopts
  )

  where fusermount(1) does:
    fd = getenv("_FUSE_DEVFD")
    mount("-oopts,fd=%s" % fd ...)

  daemonize(
    fuse_loop(fd)
  )
  waitpid(pid)
  exit()

Nb.:

- We can't help losing compatibility with upstream fusermount,
  as it sends back the fd only when mount(2) is completed,
  thus defeating the async mount approach. The
  'getenv("_FUSE_DEVFD")' mechanism is specfic to glusterfs'
  fusermount (at the moment -- sure we can talk about it with
  upstream)

- fusermount opens /dev/fuse at same privilege level as of
  original process², so we can bravely go on with doing the open
  unconditionally in original process

- Original mounting code actually tries to mount through
  fusermount _twice_: if first attempt fails, then, assuming
  subtype support is missing in kernel, it tries again subtype
  stripped. However, this is redundant, as fusermount internally
  also performs the subtype check³. Therefore we simplified the
  logic to have just a single fusermount call.

- we revert the changes to mount.glusterfs as of 7d0397c2, as
  now there is no issue with glusterfs to work around in that scope

¹ http://fuse.git.sourceforge.net/git/gitweb.cgi?p=fuse/fuse;a=blobdiff;f=ChangeLog;h=47e61004;hb=4c3d9b19;hpb=e61b775a
² http://fuse.git.sourceforge.net/git/gitweb.cgi?p=fuse/fuse;a=blob;f=util/fusermount.c;h=b2e87d95#l1023
³ http://fuse.git.sourceforge.net/git/gitweb.cgi?p=fuse/fuse;a=blob;f=util/fusermount.c;h=b2e87d95#l839

Change-Id: I0c4ab70e0c5ad7b27337228749b266bcd0ba941d
BUG: 811217
Signed-off-by: Csaba Henk 
Reviewed-on: http://review.gluster.com/3428
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur