glusterfs.git/xlators/mgmt, branch v3.8.1

glusterd: search port from last_alloc to base_port

2016-07-07T13:51:28+00:00

Backport of http://review.gluster.org/14268

If a brick process is killed ungracefully then GlusterD wouldn't receive a
PMAP_SIGNOUT event and hence the stale port details wouldn't be removed out.

Now consider the following case:
1. Create a volume with 1 birck
2. Start the volume (say brick port allocated is 49152)
3. Kill the brick process by 'kill -9'
4. Stop & delete the volume
5. Recreate the volume and start it. (Now the brick port gets 49153)
6. Mount the volume

Now in step 6 mount will fail as GlusterD will provide back the stale port
number given the query starts searching from the base_port.

Solution:

To avoid this, searching for port from last_alloc and coming down to base_port
should solve the issue.

>Change-Id: I9afafd722a7fda0caac4cc892605f4e7c0e48e73
>BUG: 1334270
>Signed-off-by: Atin Mukherjee 
>Reviewed-on: http://review.gluster.org/14268
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Samikshan Bairagya 
>Reviewed-by: Jeff Darcy 

Change-Id: I9afafd722a7fda0caac4cc892605f4e7c0e48e73
BUG: 1353426
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/14867
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kaushal M

Fix opRet value for volume info --xml call on non-existent volume

2016-07-07T04:17:50+00:00

The opRet field was being assigned to 0 in the XML output when a
gluster volume info --xml call is made on a non-existent volume.
This change assigns a value of -1 to opRet for volume info calls
for non-existent volumes. Other fields like opErrno and opErrstr
are also assigned relevant values

> Reviewed-on: http://review.gluster.org/13843
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: darshan n 
> Reviewed-by: Atin Mukherjee 
> NetBSD-regression: NetBSD Build System 

(cherry picked from commit a6e551122c603ab0cba798e7e2b30d3a15191b68)

Change-Id: I3920c602328f74252c87bb521f5a43d4bdc7d44d
BUG: 1352880
Signed-off-by: Samikshan Bairagya 
Reviewed-on: http://review.gluster.org/14863
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Atin Mukherjee

glusterd: compare uuid instead of hostname address resolution

2016-07-05T14:43:24+00:00

Backport of http://review.gluster.org/14849

In glusterd_get_brickinfo () brick's hostname is address resolved. This adds an
unnecessary latency since it uses calls like getaddrinfo (). Instead given the
local brick's uuid is already known a comparison of MY_UUID and brickinfo->uuid
is much more light weight than the previous approach.

On a scale testing where cluster hosting ~400 volumes spanning across 4 nodes,
if a node goes for a reboot, few of the bricks don't come up. After few days of
analysis its found that glusterd_pmap_sigin () was taking signficant amount of
latency and further code walthrough revealed this unnecessary address
resolution. Applying this fix solves the issue and now all the brick processes
come up on a node reboot.

Backport of commit 633e6fe265bc2de42dade58dc6a15c285957da76:
> Change-Id: I299b8660ce0da6f3f739354f5c637bc356d82133
> BUG: 1352279
> Signed-off-by: Atin Mukherjee 
> Reviewed-on: http://review.gluster.org/14849
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Prashanth Pai 
> Reviewed-by: Samikshan Bairagya 
> Reviewed-by: Kaushal M 

Change-Id: I299b8660ce0da6f3f739354f5c637bc356d82133
BUG: 1352817
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/14860
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos 
Smoke: Gluster Build System

glusterd/geo-rep: Add relative path validation to copy file command

2016-07-05T11:58:48+00:00

Added validation for input file, command fails if input file path is
relative path pointing outside of GLUSTERD_WORKDIR.

BUG: 1350785
Change-Id: I329d43ebed69bfe9fe03d6be70dc8c78a605ffc5
Signed-off-by: Aravinda VK 
Reviewed-on: http://review.gluster.org/14772
(cherry picked from commit 888de8851e718d8e3117e47fa35cfc075b998f62)
Reviewed-on: http://review.gluster.org/14819
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

glusterd/cli: coverity fixes

2016-07-04T10:19:56+00:00

Backport of http://review.gluster.org/#/c/14818/

A downstream coverity run has revealed few of the following coverity defects.
Since the downstream code is a clone of a specific upstream branch the defects
hold true for the upstream as well.

Defect type: NEGATIVE_RETURNS
xlators/mgmt/glusterd/src/glusterd-rpc-ops.c:641: negative_returns: "op_errno"
is passed to a parameter that cannot be negative.

Defect type: BUFFER_SIZE_WARNING
xlators/mgmt/glusterd/src/glusterd-volume-ops.c:2124: buffer_size_warning:
Calling strncpy with a maximum size argument of 261 bytes on destination array
"volinfo->volname" of size 261 bytes might leave the destination string
unterminated.

Defect type: BUFFER_SIZE_WARNING
xlators/mgmt/glusterd/src/glusterd-volgen.c:4888: buffer_size_warning: Calling
strncpy with a maximum size argument of 261 bytes on destination array
"volinfo->volname" of size 261 bytes might leave the destination string
unterminated.

Defect type: STRING_OVERFLOW
xlators/mgmt/glusterd/src/glusterd-volgen.c:3449: string_overflow: You might
overrun the 256 byte destination string "tmp_volname" by writing 261 bytes from
"volinfo->volname".

Defect type: BUFFER_SIZE_WARNING
xlators/mgmt/glusterd/src/glusterd-utils.c:3392: buffer_size_warning: Calling
strncpy with a maximum size argument of 261 bytes on destination array
"new_volinfo->volname" of size 261 bytes might leave the destination string
unterminated.

Defect type: NO_EFFECT
xlators/mgmt/glusterd/src/glusterd-utils.c:7359: remediation: Was
"rebal->rebalance_id" formerly declared as a pointer?

Defect type: USE_AFTER_FREE
xlators/mgmt/glusterd/src/glusterd-utils.c:7115: pass_freed_arg: Passing freed
pointer "volinfo" as an argument to "glusterd_friend_contains_vol_bricks".

Defect type: DEADCODE
cli/src/cli-cmd-parser.c:1767: dead_error_begin: Execution cannot reach this
statement: "ret = -1;".

Change-Id: Ie941bdf31923e2f39618dd94bfae16fdb3ad65f1
BUG: 1352281
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/14818
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/14850
Reviewed-by: Prashanth Pai

glusterd/ganesha : persist value set by teardown in info file

2016-07-04T05:39:18+00:00

During teardown, all the volumes exported via NFS-Ganesha will be
unexported. So all related volume options need to reset. Currently
this change made using dict_set on volopt dictionary, i.e change
is only reflected in memory not persisted in the volume info file
Therefore incase of glusterd restart this data can be lost.

Also this patch fix similar issue in ganesha_manage_export().

Upstream reference :
>Change-Id: Ib843ac30adb28a70e13a9a1df57020ef2f3db8a4
>BUG: 1349270
>Signed-off-by: Jiffin Tony Thottan 
>Reviewed-on: http://review.gluster.org/14778
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Kaleb KEITHLEY 
>Reviewed-by: Atin Mukherjee 
>(cherry picked from commit 16c34b101f604a09a5c735fb39815c59ee4ecbdb)

Change-Id: Ib843ac30adb28a70e13a9a1df57020ef2f3db8a4
BUG: 1351151
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: http://review.gluster.org/14831
Reviewed-by: Atin Mukherjee 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

Tier/glusterd: Resetting the tier status value to not started

2016-06-20T04:09:05+00:00

        back-port of : http://review.gluster.org/#/c/14106/
        back-port of : http://review.gluster.org/#/c/14229/

Problem: during a volume restart or tier start force, the
value of tier status is set as started irrespective of the result.

Fix: The appropriate value of status is set during the restart of
rebalance function.

>Change-Id: I6164f0add48542a57dee059e80fa0f9bb036dbef
>BUG: 1315666
>Signed-off-by: hari 

>Change-Id: Ie4345bd7ce1d458574e36b70fe8994b3d758396a
>BUG: 1316808
>Signed-off-by: hari 
>Reviewed-on: http://review.gluster.org/14229
>Smoke: Gluster Build System 
>Tested-by: hari gowtham 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Atin Mukherjee 

Change-Id: I8e8e0662535c9dbe09eb6c7078422b40c218b473
BUG: 1347509
Signed-off-by: hari gowtham 
Reviewed-on: http://review.gluster.org/14749
Tested-by: hari gowtham 
Reviewed-by: Atin Mukherjee 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

glusterd: unsafe strcat, strncat use in glusterd_op_stage_gsync_create()

2016-06-17T09:30:55+00:00

SuSE build system post-compile analysis aborts pkg build due to
unsafe strcat, strncat usage.

mainline
>    BUG: 1347354
>    http://review.gluster.org/14745

Change-Id: I52ac41e1172d0c1e5695a91b9f731cc9e7de4db4
BUG: 1347355
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/14746
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Avra Sengupta

performance/decompounder: Add graph for decompounder xlator

2016-06-14T15:16:51+00:00

This xlator will fall below protocol/server.
This is mandatory xlator without any options.

Observed that the callback for decompounder translator
was not added which was causing volume start
to fail.
Added cbks for decompounder.
master-
http://review.gluster.org/#/c/13968/

Change-Id: I3e16a566376338d9c6d36d6fbc7bf295fda9f3a6
BUG: 1346222
Signed-off-by: Ashish Pandey 
Reviewed-on: http://review.gluster.org/14729
Reviewed-by: Ravishankar N 
Smoke: Gluster Build System 
Reviewed-by: Anuradha Talur 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos 
NetBSD-regression: NetBSD Build System

glusterd/geo-rep: Avoid started status check if same host

2016-06-13T14:40:04+00:00

After carrying out add-brick, session creation is carried out
again, to involve new brick in the session. This needs to be done,
even if the session is in Started state.

While involving slave uuid as part of a session, User is warned
if session is in Started state. This check needs to be avoided
if it is same slave host and session creation needs to be proceeded.

> Change-Id: Ic73edd5bd9e3ee55da96f5aceec0bafa14d3f3dd
> BUG: 1342979
> Signed-off-by: Saravanakumar Arumugam 
> Reviewed-on: http://review.gluster.org/14653
> CentOS-regression: Gluster Build System 
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Aravinda VK 
(cherry picked from commit c62493efadbcf5085bbd65a409eed9391301c154)

Change-Id: Ic73edd5bd9e3ee55da96f5aceec0bafa14d3f3dd
BUG: 1344607
Signed-off-by: Saravanakumar Arumugam 
Reviewed-on: http://review.gluster.org/14711
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos 
Smoke: Gluster Build System