glusterfs.git/xlators/mgmt, branch bug-deprecated

glusterd: use list_for_each_entry_safe for cleanup

2015-01-08T16:49:55+00:00

Use list_for_each_entry_safe() instead of
list_for_each_entry() for cleanup of local
xaction_peers list.

Change-Id: I6d70c04dfb90cbbcd8d9fc4155b8e5e7d7612460
BUG: 1173414
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/9416
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi

glusterd: Refactor glusterd-utils.c

2015-01-08T13:32:11+00:00

Refactor glusterd-utils.c to create
glusterd-snapshot-utils.c consisting of all snapshot
utility functions.

Change-Id: Id9823a2aec9b115f9c040c9940f288d4fe753d9b
BUG: 1176770
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/9391
Reviewed-by: Kaushal M 
Reviewed-by: Rajesh Joseph 
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi

glusterd: cluster quorum count check correction

2015-01-06T13:44:38+00:00

Due to the recent change introduced by commit
da9deb54df91dedc51ebe165f3a0be646455cb5b cluster quorum count calucation now
depends on whether the peer list is either all peers or global transaction peer
list or the local transaction peer list.

Change-Id: I9f63af9a0cb3cfd6369b050247d0ef3ac93d760f
BUG: 1173414
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/9350
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Avra Sengupta 
Reviewed-by: Kaushal M

glusterd: Move statedump utils into a new file.

2014-12-29T06:59:36+00:00

Change-Id: I1bf26c9d294e95f7b82cfc7a96f9d5575f5e0362
BUG: 1176770
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/9313
Tested-by: Gluster Build System 
Reviewed-by: Atin Mukherjee

glusterd: check_volume_exists should query in-memory representation

2014-12-29T06:59:15+00:00

... instead of consulting the on-disk data directory. There is no reason
why the on-disk is more accurate than the in-memory representation. In
fact, it is the other way around when a node is reconciling
volume/cluster configuration with the rest of the cluster.

Change-Id: I786823efdf1d0f6b9e6fcdb72d51e5227c399ce1
BUG: 1176770
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/9292
Tested-by: Gluster Build System 
Reviewed-by: Atin Mukherjee

glusterd: coverity fix for overrun in glusterd_stop_uds_listener

2014-12-29T05:25:28+00:00

CID: 1260432

Change-Id: I6845bc4c231b53428419a5a2ad0c78ea9da31058
BUG: 1093692
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/9338
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi

mgmt/glusterd: Add option to enable lock trace

2014-12-29T05:18:42+00:00

Change-Id: I24ed0f866d53e91a8323c043a38f73207cbfd7d2
BUG: 1168189
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/9351
Reviewed-by: Krutika Dhananjay 
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi

glusterd: fix unix domain notify fn

2014-12-23T12:22:22+00:00

... and unlink the 'right' socket file

Change-Id: Id12ee8c622914555b7933104e13b43b3b31b5d19
BUG: 1176770
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/9315
Reviewed-by: Kaushal M 
Tested-by: Kaushal M

glusterd: Maintain per transaction xaction_peers list in syncop & mgmt_v3

2014-12-23T04:14:14+00:00

In current implementation xaction_peers list is maintained in a global variable
(glustrd_priv_t) for syncop/mgmt_v3. This means consistency and atomicity of
peerinfo list across transactions is not guranteed when multiple syncop/mgmt_v3
transaction are going through.

We had got into a problem in mgmt_v3-locks.t which was failing spuriously, the
reason for that was two volume set operations (in two different volume) was
going through simultaneouly and both of these transaction were manipulating the
same xaction_peers structure which lead to a corrupted list. Because of which in
some cases unlock request to peer was never triggered and we end up with having
stale locks.

Solution is to maintain a per transaction local xaction_peers list for every
syncop.

Please note I've identified this problem in op-sm area as well and a separate
patch will be attempted to fix it.

Finally thanks to Krishnan Parthasarathi and Kaushal M for your constant help to
get to the root cause.

Change-Id: Ib1eaac9e5c8fc319f4e7f8d2ad965bc1357a7c63
BUG: 1173414
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/9269
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M

glusterd: Returning success from mgmt_v3 handler functions

2014-12-20T06:05:47+00:00

The mgmt_v3 handler functions already send the ret code as
part of the *send_resp calls, and further propagating the
ret code to the calling functions will lead to double deletion
of the req object. Hence returning success from the mgmt_v3
handler functions.

Change-Id: I1090e49c54a786daae5fd97b5c1fbcb5d819acba
BUG: 1138577
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/8620
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi