glusterfs.git/xlators/mgmt/glusterd/src, branch v3.8.7

uss: snapd should enable SSL if SSL is enabled on volume

2016-12-11T10:09:47+00:00

During snapd graph generation we should check if SSL is
enabled on main volume or not. This is because clients
will communicate with snapd as if it is communicating to
a brick.


> Reviewed-on: http://review.gluster.org/15979
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Kaushal M 
(cherry picked from commit 182f0d12040dab5081ca645a3f370f65cd68b528)

Change-Id: I0d7fe86c567b297a8528a48faf06161d4c3cb415
Signed-off-by: Rajesh Joseph 
BUG: 1400459
Reviewed-on: http://review.gluster.org/15986
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Atin Mukherjee

cluster/afr: CLI for granular entry heal enablement/disablement

2016-11-29T10:52:25+00:00

        Backport of: http://review.gluster.org/15747
When there are already existing non-granular indices created that are
yet to be healed, if granular-entry-heal option is toggled from 'off' to
'on', AFR self-heal whenever it kicks in, will try to look for granular
indices in 'entry-changes'. Because of the absence of name indices,
granular entry healing logic will fail to heal these directories, and
worse yet unset pending extended attributes with the assumption that
are no entries that need heal.

To get around this, a new CLI is introduced which will invoke glfsheal
program to figure whether at the time an attempt is made to enable
granular entry heal, there are pending heals on the volume OR there
are one or more bricks that are down. If either of them is true, the
command will be failed with the appropriate error.

New CLI: gluster volume heal  granular-entry-heal {enable,disable}

Change-Id: I342e0390f847fcb015a50ef58aedfcbcb58f4ed3
BUG: 1398501
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/15942
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

glusterd: clean up old port and allocate new one on every restart

2016-11-23T10:37:16+00:00

    Backport of http://review.gluster.org/#/c/15005/9.

GlusterD as of now was blindly assuming that the brick port which was
already allocated would be available to be reused and that assumption
is absolutely wrong.

Solution : On first attempt, we thought GlusterD should check if the
already allocated brick ports are free, if not allocate new port and
pass it to the daemon. But with that approach there is a possibility
that if PMAP_SIGNOUT is missed out, the stale port will be given back
to the clients where connection will keep on failing. Now given the
port allocation always start from base_port, if everytime a new port
has to be allocated for the daemons, the port range will still be
under control. So this fix tries to clean up old port using
pmap_registry_remove () if any and then goes for pmap_registry_alloc ()

This patch is being ported to 3.8 branch because, the brick process
blindly re-using old port, without registering with the pmap server,
causes snapd daemon to not start properly, even though snapd registers
with the pmap server. With this patch, all the brick processes and
snapd will register with the pmap server to either get the same port,
or a new port, and avoid port collision.

> Reviewed-on: http://review.gluster.org/15005
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Avra Sengupta 

(cherry picked from commit c3dee6d35326c6495591eb5bbf7f52f64031e2c4)

Change-Id: If54a055d01ab0cbc06589dc1191d8fc52eb2c84f
BUG: 1369766
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/15308
Tested-by: Avra Sengupta 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Niels de Vos

glusterd/quota: upgrade quota.conf file during an upgrade

2016-11-08T16:46:41+00:00

Problem
=======
When quota is enabled on 3.6, it will have quota conf version in quota.conf
as v1.1. This node gets upgraded to 3.7 but it will still have quota conf
version as v1.1 until a quota enable/disable/set limit is initiated. When
this is not initiated and when this node tries to peer probe a node which
is a fresh install of 3.7 (which will have quota conf version as v1.2), then this
will result in "Peer rejected" state. This patch fixes the issue.

Solution
========
When an upgrade happens from 3.6 to 3.7, quota.conf file needs
to be modified as well. With 3.6, in quota.conf the version will be
v1.1 and it needs to be changed to v1.2 from 3.7. This is because in
3.7, inode quota feature is introduced. So when an op-version bumpup
happens quota.conf needs to be upgraded with quota conf version v1.2
and all the 16 byte uuid needs to be changed to 17 bytes uuid as well.

Previously, when the cluster version is upgraded to 3.7, the quota.conf
got upgraded as well. But, the upgradation was done only when quota
enable/disable/set limit is done. With this patch, the upgradation is done
during a cluster op version bump up as well.

> Reviewed-on: http://review.gluster.org/15352
> Tested-by: Atin Mukherjee 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Smoke: Gluster Build System 
> Reviewed-by: Atin Mukherjee 
(cherry picked from commit 4b2cff614462508eef529c5d128e0974720e3f50)

Change-Id: Idb5ba29d3e1ea0e45c85d87c952c75da9e0f99f0
BUG: 1392716
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/15791
Smoke: Gluster Build System 
Reviewed-by: Manikandan Selvaganesh 
Tested-by: Manikandan Selvaganesh 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

glusterd/shared storage: Check for hook-script at staging

2016-11-07T05:18:28+00:00

Check if S32gluster_enable_shared_storage.sh is present
at /var/lib/glusterd/hooks/1/set/post/ at staging
before proceeding with the command. Fail the command
with the appropriate error message in case it is not
present.

> Reviewed-on: http://review.gluster.org/15718
> NetBSD-regression: NetBSD Build System 
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Atin Mukherjee 

(cherry picked from commit 29587a91716e1e55bd172d63340c40249fb343c9)

Change-Id: I84e3912f1cdffb927f8a40d74d52be43ee69388b
BUG: 1377448
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/15741
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Atin Mukherjee

snapshot: Fix for memory leaks in snapshot code path

2016-11-04T06:05:16+00:00

> Reviewed-on: http://review.gluster.org/15668
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Smoke: Gluster Build System 
> Reviewed-by: Rajesh Joseph 

(cherry picked from commit 48a4c4e525665115f7e8c478d3bf51764427378d)

Change-Id: Idc2cb16574d166e3c0ee1f7c3a485f1acb19fc8c
BUG: 1388354
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/15720
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Rajesh Joseph

glusterd: fix return val in glusterd_op_volume_dict_uuid_to_hostname ()

2016-09-29T05:28:45+00:00

glusterd_op_volume_dict_uuid_to_hostname () ignores few dict_get_str failures
but doesn't reset the ret value to 0.

Reproducer steps:
1. Configure a volume and start it (gNFS has to be disabled)
2. gluster volume status

An warning log is observed with:
[MSGID: 106217] [glusterd-op-sm.c:4706:glusterd_op_modify_op_ctx] 0-management:
Failed uuid to hostname conversion
[2016-09-22 09:21:38.537533] W [MSGID: 106387]
[glusterd-op-sm.c:4812:glusterd_op_modify_op_ctx] 0-management: op_ctx
modification failed

>Reviewed-on: http://review.gluster.org/15547
>Smoke: Gluster Build System 
>CentOS-regression: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>Reviewed-by: Samikshan Bairagya 
>Reviewed-by: Kaushal M 

Change-Id: I1d3aa79304d83a9d5db1b7198773d8c2780e24a9
BUG: 1379284
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/15571
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Prashanth Pai

Tier: failing detach commit on detach failure and in-progress

2016-09-16T12:56:53+00:00

        back-port of:http://review.gluster.org/#/c/15438/

PROBLEM: if detach status has failed or if it remains in progress
we allow detach commit to happen. only detach force should
be allowed.

FIX: check the detach status for failure or inprogress and disallow
with the apt error message.

> Change-Id: Ib97d540fec67717bb55c18d133187c665cf69ef1
> BUG: 1374584
> Signed-off-by: hari gowtham 
> Reviewed-on: http://review.gluster.org/15438
> Smoke: Gluster Build System 
> Tested-by: hari gowtham 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Dan Lambright 
> Tested-by: Dan Lambright 

Change-Id: I4098c45f5338f8bc4262e75fa6630dabc755e133
BUG: 1375565
Signed-off-by: hari gowtham 
Reviewed-on: http://review.gluster.org/15492
Tested-by: hari gowtham 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Dan Lambright

snapshot: Display number of snapshots in volume info

2016-08-24T10:17:30+00:00

    Backport of http://review.gluster.org/#/c/15029/

Display number of snapshots in a volume in volume info
output. This number gets modified, with create, delete,
and restore operations.

> Reviewed-on: http://review.gluster.org/15029
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Rajesh Joseph 

(cherry picked from commit 1df4a89de17e44c8c1f9b4794a7b8c2741f2bc2e)

Change-Id: Ic9b7c2b6950980f8ce75ca362998c097ea7c863d
BUG: 1369328
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/15288
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Rajesh Joseph

snapshot/cli: Fix snapshot status xml output

2016-08-24T10:15:12+00:00

    Backport of http://review.gluster.org/#/c/14018/

snap status --xml errors out if a brick is down and
doesn't have pid. It is handled in the cli of the snap
status where "N/A" is displayed in such a scenario.
Handled the same in xml

snap status  --xml fails as the writer is
not initialised for the same. Using GF_SNAP_STATUS_TYPE_ITER
instead of GF_SNAP_STATUS_TYPE_SNAP for all snap's
status to differentiate between the two scenarios.

Added testcase volume-snapshot-xml.t to check
all snapshot commands xml outputs

> Reviewed-on: http://review.gluster.org/14018
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Rajesh Joseph 

Change-Id: I99563e8f3e84f1aaeabd865326bb825c44f5c745
BUG: 1369372
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/15291
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Rajesh Joseph