glusterfs.git/xlators/mgmt/glusterd/src, branch v3.7.9

snapshot: Fix parent volinfo corruption in snapshot restore

2016-03-11T08:06:55+00:00

    Backport of http://review.gluster.org/#/c/13282/

Remove parent_volinfo irrespective of success or failure
of glusterd_lvm_snapshot_remove(). This prevents the
duplication of the volinfo after the execution of
glusterd_snapshot_restore().

When commit fails on originator node, we don't perform
commit on the other nodes, as a result we don't have a
backup of /var/lib/glusterd/vols/ in the
GLUSTERD_TRASH in other nodes. But in the postvalidate
we try to restore from GLUSTED_TRASH and end up cleaning
up /var/lib/glusterd/vols/. Hence moved
glusterd_snapshot_backup_vol() from commit to prevalidate,
so that the backup is always available when a cleanup is
needed.

Change-Id: Icd471b23faf02bad680b9a1aadc4a0175f7cce8b
BUG: 1301030
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/13282
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Rajesh Joseph 
(cherry picked from commit 3f78b6b3dc6376945a1b1a7c4af16103901ab746)
Reviewed-on: http://review.gluster.org/13548

glusterd: fixing few memory leak in glusterd

2016-03-10T15:20:04+00:00

This patch is backport of: http://review.gluster.org/#/c/12927/

Current glusterd code base having memory leak. This is because of
memory allocate by dict_allocate_and_serialize function in
"gd_syncop_mgmt_v3_lock" and "gd_syncop_mgmt_v3_unlock"
function is not freeing up memory upon exit.

Fix is to free the memory after exit of the above function.

Thanks Carlos and Roman for finding out the issue and fix.

 >> Change-Id: Id67aa794c84969830ca7ea8c2374f80c64d7a639
 >> BUG: 1287517
 >> Signed-off-by: Gaurav Kumar Garg 
 >> Signed-off-by: Carlos Chinea 
 >> Signed-off-by: Roman Tereshonkov 
 >> Reviewed-on: http://review.gluster.org/12927
 >> Smoke: Gluster Build System 
 >> NetBSD-regression: NetBSD Build System 
 >> CentOS-regression: Gluster Build System 
 >> Reviewed-by: Jeff Darcy 

Change-Id: Id67aa794c84969830ca7ea8c2374f80c64d7a639
BUG: 1311377
Signed-off-by: Gaurav Kumar Garg 
(cherry picked from commit e38bf1bdeda3c7a89be3193ad62a72b9139358dd)
Reviewed-on: http://review.gluster.org/13503
Smoke: Gluster Build System 
Reviewed-by: Vijay Bellur 
Tested-by: Vijay Bellur 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System

glusterd: volume get should pick options from priv->opts too

2016-03-09T07:25:52+00:00

Backport of http://review.gluster.org/13272

As of now volume get was not looking for all the global options maintained in
option dictionary in glusterd_conf_t. This patch includes the same.

Change-Id: Ib05259a2dcacc4a712cae4217fe4a6553b61da56
BUG: 1315939
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/13272
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Gaurav Kumar Garg 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/13651

glusterd: avoid setting op-version lower than current cluster op-version

2016-03-09T02:18:12+00:00

This patch is backport of: http://review.gluster.org/#/c/13622/

Currently glusterd allow setting a cluster op-version which is lower than
current cluster op-version. Though command is successful but it does not
set that lower op-version.

With this fix it will return error message "Required op-version
(requested op-version) should not be lower than current cluster
op-version (current cluster op-version)"

Change-Id: Ia5b61858ee22a5a26721ec12ab12ff48e1a40c82
BUG: 1315562
Signed-off-by: Gaurav Kumar Garg 

  >> Change-Id: Ia5b61858ee22a5a26721ec12ab12ff48e1a40c82
  >> BUG: 1315186
  >> Signed-off-by: Gaurav Kumar Garg 
  >> Reviewed-on: http://review.gluster.org/13622
  >> Smoke: Gluster Build System 
  >> CentOS-regression: Gluster Build System 
  >> NetBSD-regression: NetBSD Build System 
  >> Reviewed-by: Atin Mukherjee 
(cherry picked from commit 2d87a981657ee23d00c20813deddeb320e0afa8f)

Change-Id: Ie75b2a0c43ab2c5a908f4d3800e1df62770d315b
Reviewed-on: http://review.gluster.org/13635
Tested-by: Gaurav Kumar Garg 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Vijay Bellur

Tier: making detach start fail when brick on hot tier is down

2016-03-08T15:50:59+00:00

        backport of : http://review.gluster.org/#/c/13474/6

Currently detach tier start happens even when a hot brick is down
this might lead to data loss.

This patch prevents the detach tier start from being executed
successfully if a brick in hot tier is down

>Change-Id: I3b6047a44bd01b8a6887d41f799f64de6bf075ef
>BUG: 1309999
>Signed-off-by: hari 

Change-Id: Ica0ae72f8e30156090be43e428545d684bdea36b
BUG: 1314617
Signed-off-by: hari 
Reviewed-on: http://review.gluster.org/13602
Smoke: Gluster Build System 
Tested-by: hari gowtham 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Dan Lambright

glusterd: coverity warning in gluster_copy_nfs_ganesha_file()

2016-03-05T23:50:52+00:00

fix unused return value from snprintf.

Also minor cleanup, including safe handling of truncated output
by snprintf, and lstat() -> sys_lstat()

backport from mainline:
>Change-Id: Ibec8c7e6cc4ef07b6535d01a0719359fa3ef8030
>BUG: 1310755
>Reviewed-on: http://review.gluster.org/13486

Change-Id: Ic893751c5ce83c85b01c311091f2728d4997e599
BUG: 1315009
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/13612
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/ec: Mark self-heal fops as internal

2016-03-05T01:26:21+00:00

 >Change-Id: I8ae7af266d3e00460f0cfdc9389a926e5f2fee36
 >BUG: 1282761
 >Signed-off-by: Pranith Kumar K 
 >Reviewed-on: http://review.gluster.org/12598
 >Tested-by: Gluster Build System 
 >Tested-by: NetBSD Build System 
 >Reviewed-by: Xavier Hernandez 

BUG: 1283757
Change-Id: Ic20d4ee031265305db1a6ed2cf591ce94b7d0749
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/12668
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

glusterd: Avoid ret value of glusterd_resolve_brick in retreive brick path

2016-03-04T04:15:10+00:00

Backport of http://review.gluster.org/13588

In glusterd_store_retrieve_bricks() commit a60c39d introduced
glusterd_resolve_brick () call to resolve all the bricks which is incorrect
since by the time peerinfo list may not be constructed. The requirement here was
to get the local brick's uuid populated and match that with MY_UUID.

Fix is to overlook the return code of glusterd_resolve_brick() to ensure that
the failure in resolving non local bricks are genuine and expected.

Change-Id: I22822ae5b4e96fe4eacd50ea5c41e58061557106
BUG: 1314164
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/13589
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

mgmt/glusterd: Show features.shard option in volume-set-help output

2016-03-04T03:45:19+00:00

        Backport of: http://review.gluster.org/#/c/13565/

Change-Id: Ief6f62c65dd8cc736edc785ac06af6ee7309862c
BUG: 1313339
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/13566
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Pranith Kumar Karampuri

glusterd: use string comparison for realpath checks in glusterd_is_brickpath_available

2016-03-03T04:15:59+00:00

Backport of http://review.gluster.org/13258

glusterd_is_brickpath_available () used to call realpath() for checking the
whether the new brick path matches with the existing ones. The problem with this
is if the underlying file system is bad for any one of the existing bricks then
realpath() would fail and we wouldn't allow to create the new brick even if it
should be allowed.

Fix is to use string comparison with having a new field real_path in brickinfo
to store the absolute path

Change-Id: I1250ea5345f00fca0f6128056ebd08750d604f0a
BUG: 1312878
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/13258
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/13550