glusterfs.git/xlators/mgmt/glusterd/src, branch v3.6.2beta1

mgmt/glusterd: Out of bounds access to fs_info struct

2014-12-13T06:14:11+00:00

Change-Id: Ibc75713d35c9cbafd493c8cf6b5294eaf29f05d4
BUG: 1163920
Signed-off-by: Petr Medonos 
Reviewed-on: http://review.gluster.org/9126
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd/geo-rep: Fix glusterd crash in non-originator slave node.

2014-11-13T07:23:14+00:00

Problem: glusterd crashes in non-originator slave node during geo-rep
         create push-pem.

Cause: In glusterd_op_copy_file, the value of the key "common_pem_contents"
       is freed explicitly even after dict_set is successful when it is
       taken cared by dict_free.

Solution: Free only in failure cases before dict_set.

BUG: 1159210
Change-Id: I726f923915fc24de6588469c27f2cc996c20c59d
Reviewed-On: http://review.gluster.org/9018/
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/9026
Tested-by: Gluster Build System 
Reviewed-by: Venky Shankar 
Tested-by: Venky Shankar

geo-rep/glusterd: Enable changelog and marker during geo-rep create.

2014-11-13T01:56:59+00:00

PROBLEM:
Geo-rep misses few a files to sync when I/O happenned during
geo-rep start.

ANALYSES:
To use the available changelogs to handle deletes/renames,
'xsync upper limit' is introduced which limits the xsync
crawl till the changelog register time.  But there is a
small time interval between the changelog register time and
the time changelog actually enabled. If there is I/O between
this interval, it will not be synced through xsync as it is
beyond changelog register time and not through changelog also
as changelog is not actually enabled.

SOLUTION:
Enable changelog and marker during geo-rep create instead
of geo-rep start so that entries are captured in changelog
and above said interval is nullified.

BUG: 1159205
Change-Id: If5203eb1cfcbde3999f97a5f1a6a1af4875ac358
Reviewed-on: http://review.gluster.org/8650
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/9023
Tested-by: Gluster Build System 
Reviewed-by: Venky Shankar 
Tested-by: Venky Shankar

glusterd/geo-rep: Fix race in updating status file

2014-11-12T12:28:02+00:00

When geo-rep is in paused state and a node in a cluster
is rebooted, the geo-rep status goes to "faulty (Paused)"
and no worker processes are started on that node yet. In
this state, when geo-rep is resumed, there is a race in
updating status file between glusterd and gsyncd itself
as geo-rep is resumed first and then status is updated.
glusterd tries to update to previous state and gsyncd
tries to update it to "Initializing...(Paused)" on
restart as it was paused previously. If gsyncd on restart
wins, the state is always paused but the process is not
acutally paused. So the solution is glusterd to update
the status file and then resume.

BUG: 1159195
Change-Id: I4c06f42226db98f5a3c49b90f31ecf6cf2b6d0cb
Reviewed-on: http://review.gluster.org/8911
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/9021
Tested-by: Gluster Build System 
Reviewed-by: Venky Shankar 
Tested-by: Venky Shankar

glusterd: make bricks respect 'transport.socket.bind-address'

2014-10-21T17:15:58+00:00

When GlusterD starts the brick processes, these will listen on all
interfaces. When the 'transport.socket.bind-address' option is set in
glusterd.vol, the brick processes should only listen on the specified
hostname or IP-address.

Cherry picked from commit 430b874c4f1a171c106a9e1e6507e14e79805a1d:
> Change-Id: I8e7d1f294904081137c23f3446261329d0d13bba
> BUG: 1149863
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/8910
> Tested-by: Gluster Build System 
> Reviewed-by: Krishnan Parthasarathi 
> Tested-by: Krishnan Parthasarathi 

Change-Id: I8e7d1f294904081137c23f3446261329d0d13bba
BUG: 1151745
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/8951
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd: pass the bind-address to starting services

2014-10-21T12:30:14+00:00

When the transport.socket.bind-address option is set to a hostname or
ip-address, the services started by GlusterD fail to connect to the
management daemon. GlusterD always forces the services to connect to the
"localhost" hostname, even if it is not listening on that address.

GlusterD should take the transport.socket.bind-address option into
consideration, and pass that to the glusterfs-clients with the -s or
--volfile commandline parameter.

Note that this is not a change that removes all hard-coded dependencies
on "localhost". This change merely makes it possible to start required
services when the transport.socket.bind-address option is set.

Cherry picked from commit 283fa797f4bf98130b42c36972305b8cb6e5aaaf:
> Change-Id: I36a0ed6c69342e6327adc258fea023929055d7f2
> BUG: 1149863
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/8908
> Tested-by: Gluster Build System 
> Reviewed-by: Jeff Darcy 
> Reviewed-by: Krishnan Parthasarathi 
> Tested-by: Krishnan Parthasarathi 

Change-Id: I36a0ed6c69342e6327adc258fea023929055d7f2
BUG: 1151745
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/8950
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

Do not hardcode umount(8) path, emulate lazy umount

2014-10-03T15:01:29+00:00

1) Use a system-dependent macro for umount(8) location instead of
relying on $PATH  to find it, for security and portability sake.

2) Introduce gf_umount_lazy() to replace umount -l (-l for lazy) invocations,
which is only supported on Linux; On Linux behavior in unchanged. On other
systems, we fork an external process (umountd) that will take care of
periodically attempt to unmount, and optionally rmdir.

Backport of Ia91167c0652f8ddab85136324b08f87c5ac1edd51d

BUG: 1138897
Change-Id: I9d82c87e85af0dee79f2de39bc697c486b7103c8
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/8863
Tested-by: Gluster Build System 
Reviewed-by: Csaba Henk 
Reviewed-by: Vijay Bellur

glusterd/quota: Heal pgfid xattr on existing data when the quota is enable

2014-09-30T16:42:40+00:00

This is a backport of http://review.gluster.org/#/c/8878/

The pgfid extended attributes are used to construct the ancestry path
(from the file to the volume root) for nameless lookups on files.
As NFS relies on nameless lookups heavily, quota enforcement through NFS
would be inconsistent if quota were to be enabled on a volume with
existing data.

Solution is to heal the pgfid extended attributes as a part of lookup
perfomed by quota-crawl process. In a posix lookup check for pgfid xattr
and if it is missing set the xattr.

BUG: 1147953
Change-Id: I707d91a056e07452bfd1e070af5eddaa752a84ac
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/8890
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd: Improve debugging experience for glusterd locks

2014-09-26T16:58:21+00:00

Today, when glusterd's internal locking mechanism fails
with invalid type or when another competing lock is being
held, the log message doesn't provide enough information
directly as to which command saw this (first). Following
is a snippet of how a failure would look in the log file.
This would greatly assist in debugging.

[2014-09-03 04:57:58.549418] E
[glusterd-locks.c:520:glusterd_mgmt_v3_lock]
(-->/usr/local/lib/glusterfs/3.7dev/xlator/mgmt/glusterd.so(__glusterd_handle_create_volume+0x801)
[0x7f30b071e651]
(-->/usr/local/lib/glusterfs/3.7dev/xlator/mgmt/glusterd.so(glusterd_op_begin_synctask+0x2c)
[0x7f30b072e19c]
(-->/usr/local/lib/glusterfs/3.7dev/xlator/mgmt/glusterd.so(gd_sync_task_begin+0x55d)
[0x7f30b072de6d]))) 0-management: Invalid entity. Cannot perform locking
operation on vol types

Change-Id: I0595f49d60e620e8b065f3506bdb147ccee383a7
BUG: 1145093
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/8842
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

OSX/FreeBSD: Regression fix

2014-09-24T23:34:05+00:00

Introduced in "1f6e992f1aaa676be5bd47d17e58f1171825cf43"

Change-Id: Id684e2f082def7d01ef3c258ea6598da6205591f
BUG: 1117822
Signed-off-by: Harshavardhana 
Reviewed-on: http://review.gluster.org/8840
Reviewed-by: Justin Clift 
Tested-by: Justin Clift