glusterfs.git/xlators/mgmt/glusterd/src, branch v3.6.0beta1

snapview-server: register a callback with glusterd to get

2014-09-18T17:59:30+00:00

 notifications

* As of now snapview-server is polling (sending rpc requests to glusterd) to
  get the latest list of snapshots at some regular time intervals
  (non configurable). Instead of that register a callback with glusterd so that
  glusterd sends notifications to snapd whenever a snapshot is created/deleted
  and snapview-server can configure itself.

rebase of the patch http://review.gluster.org/#/c/8150/

Change-Id: Iee2582b1a823d50c79233a41cf2106f458b40691
BUG: 1143961
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/8767
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

geo-rep/glusterd: API to check active geo-rep session for the volume

2014-09-09T03:08:08+00:00

Requirement:
Snapshot needs an API to fail the CLI if any geo-rep session is active
for that volume.

Solution:
A function "gd_vol_is_geo_rep_active" is provided to check if any
geo-rep session is active for that volume. An in memory dict called
'gsync_running_slaves' is maintained in 'volinfo' structure to keep
track of active geo-rep session for the volume. The key
'slavenode::slavevol' with value 'running' is added whenever geo-rep
is started/resumed into the dict and the same is removed if
stopped/paused. So the 'count' in dict is used to decide whether the
geo-rep is active or not for that volume.

Also added "this->name" in gf_log in routines which this patch is
touched.

BUG: 1138952
Change-Id: Ib13aeb509a56edf510651b77e20bf3cc43a3e763
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/8459
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/8645
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

feature/geo-rep: Keep marker.tstamp's mtime unchangeable during snapshot.

2014-09-08T19:02:19+00:00

Problem:

Geo-replicatoin does a full xsync crawl after snapshot
restoration of slave and master. It does not do history crawl.

Analysis:

Marker creates 'marker.tstamp' file when geo-rep is started
for the first time. The virtual extended attribute
'trusted.glusterfs.volume-mark' is maintained and whenever
it is queried on gluster mount point, marker fills it on
the fly and returns the combination of uuid, ctime of
marker.tstamp and others. So ctime of marker.tstamp, in other
sense 'volume-mark'  marks the geo-rep start time when the
session is freshly created.

From the above, after the first filesystem crawl(xsync) is
done during first geo-rep start, stime should always be less
than 'volume-mark'. So whenever stime is less than volume-mark,
it does full filesystem crawl (xsync).

Root Cause:

When snapshot is restored, marker.tstamp file is freshly
created losing the timestamps, it was originally created with.

Solution:

1. Change is made to depend on mtime instead of ctime.
2. mtime and atime of marker.tstamp is restored back when
   snapshot is created and restored.

BUG: 1138952
Change-Id: I0e19e1cb2593171b9a2b41d0d303330feb7fd2b3
Signed-off-by: Kotresh H R 
Reviewed-on: http://review.gluster.org/8401
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/8642

gluster: Fix the recursive goto outs in the source code.

2014-09-08T06:35:36+00:00

Added a script check_goto.pl, that when run from
the source code root, will scan all .c files to match
the following pattern:

label:
        if (condition)
            goto label;

On finding such a pattern the script will print the file name
and the line number. There are certain cases where the above
recursive pattern is intended. Hence adding those labels to
ignore-labels. Thanks Vijaikumar Mallikarjuna for the perl
script.

Also fixed all such existing errors

BUG: 1138952
Change-Id: Ie6b75621711736e7e30f2f9d25e50435d58fc1e2
Signed-off-by: Vijaikumar Mallikarjuna 
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/8307
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/8637
Reviewed-by: Vijay Bellur

Always check for ENODATA with ENOATTR

2014-09-08T06:23:42+00:00

Linux defines ENODATA and ENOATTR with the same value, which means that
code can miss on on the two without breaking.

FreeBSD does not have ENODATA and GlusterFS defines it as ENOATTR just
like Linux does.

On NetBSD, ENODATA != ENOATTR, hence we need to check for both values
to get portable behavior.

This is a backport of  I003a3af055fdad285d235f2a0c192c9cce56fab8

BUG: 1138897
Change-Id: I272cd53e637993c7fd2ac74bd607001d3581ced7
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/8634
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

NetBSD /dev/fuse detection

2014-09-08T06:20:36+00:00

NetBSD's FUSE being pure userland implementation, there is no /dev/fuse
to open. Test /dev/puffs (kernel fs-in-userland subsystem supporting FUSE)
insead.

This is a backport of Ia65e95c246dc31ea2839cf64d7c851430828542e

BUG: 1138897
Change-Id: I9beb673cff08d429c8ae66a819266f6037086b3e
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/8633
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

Fix glustershd detection on volume restart

2014-09-08T06:19:08+00:00

On NetBSD and FreeBSD, doing a 'gluster volume start $volume force' causes
NFS server, quotad, snapd and glustershd to be undetected by glusterd once the
volume has restarted. 'gluster volume status' shows the three processes
as 'N' in the online column, while they have been launched successfully.

This happens because glusterd attempts to connect to its child processes
just between the child does a unlink() on the socket in
__socket_server_bind() and the time it calls bind() and listen().
Different scheduling policy may explain why the problem does not happen
on Linux, but it may pop up some day since we make no guaranteed
assumptions here.

This patchet works this around by introducing a boolean
transport.socket.ignore-enoent option, set by nfs and glustershd,
which prevents ENOENT to be fatal and cause glusterd to retry and
suceed later. Behavior of other clients is unaffected.

This is a backport of  Ifdc4d45b2513743ed42ee235a5c61a086321644c

BUG: 1138897
Change-Id: I04472f045249c99a9492218ceebfab847474db2d
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/8630
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

build: make GLUSTERD_WORKDIR rely on localstatedir

2014-09-03T18:01:45+00:00

Backport from master branch - http://review.gluster.org/#/c/8246/

- Break-way from '/var/lib/glusterd' hard-coded previously,
  instead rely on 'configure' value from 'localstatedir'
- Provide 's/lib/db' as default working directory for gluster
  management daemon for BSD and Darwin based installations
- loff_t is really off_t on Darwin
- fix-off the warnings generated by clang on FreeBSD/Darwin
- Now 'tests/*' use GLUSTERD_WORKDIR a common variable for all
  platforms.
- Define proper environment for running tests, define correct PATH
  and LD_LIBRARY_PATH when running tests, so that the desired version
  of glusterfs is used, regardless where it is installed.
  (Thanks to manu@netbsd.org for this additional work)

Change-Id: I06e684ac4c26d1e74c9daf76753403ad15f79276
BUG: 1130308
Signed-off-by: Harshavardhana 
Reviewed-on: http://review.gluster.org/8486
Tested-by: Gluster Build System

cli: Xml output for geo-replication status command

2014-08-28T16:52:25+00:00

This patch adds xml output for geo-replication status
and status detail command.
sample:
--------------------------------------------------------------
  
    
      master
      
        
        :2a301d66-b9d2-44b4-b827-d680d67123eb:ssh://XXXXXXXXXX::slave
          
            localhost.localdomain
            2a301d66-b9d2-44b4-b827-d680d67123eb
            /root/master_b1
            ssh://XXXXXXXXXXX::slave
            faulty
            N/A
            N/A
          
        
      
    
  
-------------------------------------------------------------

Change-Id: Ia19dbe751c3ab1ec7cb8923cdd6c8b99c374072f
BUG: 1133464
Signed-off-by: ndarshan 
Reviewed-on: http://review.gluster.org/8089
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M 
Signed-off-by: ndarshan 
Reviewed-on: http://review.gluster.org/8532
Reviewed-by: Sachin Pandit 
Reviewed-by: Vijay Bellur

glusterd: Correctly reset volinfo->caps during volume create

2014-07-17T12:21:00+00:00

Change-Id: I012899be08a06d39ea5c9fb98a66acf833d7213f
BUG: 1120589
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/8323
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi