glusterfs.git/xlators/mgmt/glusterd/src, branch v3.3.2qa2

localtime and ctime are not MT-SAFE

2013-02-08T20:04:42+00:00

There are a number of nit-level issues throughout the source with
the use of localtime and ctime. While they apparently aren't causing
too many problems, apart from the one in bz 828058, they ought to be
fixed. Among the "real" problems that are fixed in this patch:
1) general localtime and ctime not MT-SAFE. There's a non-zero chance
   that another thread calling localtime (or ctime) will over-write
   the static data about to be used in another thread
2) localtime(& <64-bit-type>) or ctime(& <64-bit-type>) generally
   not a problem on 64-bit or little-endian 32-bit. But even though
   we probably have zero users on big-ending 32-bit platforms, it's
   still incorrect.
3) multiple nested calls passed as params. Last one wins, i.e. over-
   writes result of prior calls.
4) Inconsistent error handling. Most of these calls are for logging,
   tracing, or dumping. I submit that if an error somehow occurs in
   the call to localtime or ctime, the log/trace/dump still should
   still occur.
5) Appliances should all have their clocks set to UTC, and all log
   entries, traces, and dumps should use GMT.
6) fix strtok(), change to strtok_r()

Other things this patch fixes/changes (that aren't bugs per se):
1) Change "%Y-%m-%d %H:%M:%S" and similar to their equivalent shorthand,
   e.g. "%F %T"
2) change sizeof(timestr) to sizeof timestr. sizeof is an operator,
   not a function. You don't use i +(32), why use sizeof().
   (And yes, you do use parens with sizeof().)
3) change 'char timestr[256]' to 'char timestr[32]' where appropriate.
   Per-thread stack is limited. Time strings are never longer than ~20
   characters, so why waste 220+ bytes on the stack?

Things this patch doesn't fix:
1) hodgepodge of %Y-%m-%d %H:%M:%S versus %Y/%m/%d-%H%M%S and other
   variations. It's not clear to me whether this ever matters, not to
   mention 3rd party log filtering tools may already rely on a
   particular format. Still it would be nice to have a single manifest
   constant and have every call to localtime/strftime consistently use
   the same format.

BUG: 832173

Change-Id: Iee9719db4576eacc6c75694d9107954d0912cba8
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/3613
Reviewed-by: Anand Avati 
Tested-by: Anand Avati

glusterd-volgen: by default include 'cluster/distribute' in volfile

2012-10-25T09:09:24+00:00

This is a backport of Ie9d559e6b26aafd3d67908ab20a006e4e5e70d73
We need it in order to avoid spurious EINVAL when scaling from 1 brick to
more in distributed volumes.

BUG: 815227
Change-Id: I9858af03bf6d7724ff997f341faca62e89aecfb0
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/3838
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

Fixed some general typing errors.

2012-09-27T18:22:34+00:00

Eg: changed recieved to received

Change-Id: I360fcb99c97c8a0222e373fee20ea2fccfb938db
BUG: 860543
Signed-off-by: Varun Shastry 
Reviewed-on: http://review.gluster.org/3999
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd: nfs.disable fix for "volume set help"

2012-09-17T05:00:38+00:00

Fixes volgen to include "nfs.disable" in output of "volume set help".

Change-Id: Idaac2cee04b7b38aad5a77db558808c0eb699fcf
BUG: 828027
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/3881
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Vijay Bellur

storage/posix: Option to set brick(of a volume)'s root dir's uid/gid

2012-09-14T08:29:27+00:00

CLI
---
gluster volume set VOLNAME owner-uid uid
gluster volume set VOLNAME owner-gid gid
where uid,gid are the owner's user id and group id respectively that
would be set on the root of all brick (backend) fs.

TODO: uid/gid should not be -1. Today we don't validate that in CLI.

Change-Id: Ib6a2fb5e404691c5fe105a89faaeff3e1ab72e91
BUG: 853842
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/3939
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cli: Added special key "group" for bulk volume set.

2012-09-12T19:26:15+00:00

gluster volume set VOLNAME group group_name

- where group_name is a file under /var/lib/glusterd/groups containing one
  key, value pair per line as below,
  key1=value1
  key2=value2
  [...]
- the command sets key1 to value1 and so on.

Change-Id: Ic4c8dedb98d013b29a74e57f8ee7c1d3573137d2
BUG: 851237
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/3896
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

Honour configure --localstatedir and --sysconfdir

2012-09-10T04:10:19+00:00

Makes sure /etc/glusterd to /var/lib/glusterd migration does
nonour configure --localstatedir and --sysconfdir.

Backport of I65a5f96424d67531e81e75b084265bd4e6e30f29

BUG: 764655
Change-Id: I71e0d3b7f0d27b490b591dcc92ddfe26fb8e818d
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/3911
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

glusterd: Expect setmntent(3) to return NULL

2012-09-09T17:41:20+00:00

- Closed the mtab FILE * using endmntent(3)

Change-Id: I5e1ebb7f092abda638cfbb5524da693dcac6c872
BUG: 851109
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/3922
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cli: Proper xml output for "gluster peer status"

2012-08-30T10:37:40+00:00

Change-Id: I90952ba2ea606552cf4ad67dd296a440f90592d6
BUG: 847760
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/3870
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd: Fixed incorrect assumptions in rpcsvc actors of glusterd

2012-08-30T10:29:51+00:00

Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/3864
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati 

Conflicts:

	xlators/mgmt/glusterd/src/glusterd-handler.c

Change-Id: Iabfcb401de9d658e32433aa1e8c87b329cbd2cf7
BUG: 851109
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/3876
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur