glusterfs.git/xlators/mgmt/glusterd/src, branch v3.11.1

Revert "Revert "glusterd: disallow rebalance & remove-brick on a sharded volume""

2017-06-27T14:04:55+00:00

This is being reverted as a new bug around rebalance has been uncovered.
As a result we would like to retain the warning in the code and in the
release-notes.

The new bug being, https://bugzilla.redhat.com/show_bug.cgi?id=1465075

This reverts commit 9c5403587517b5922cb87bff75033839e96d56ab.

Change-Id: Ifd38ae0a41539aeb67723eb3ee704c18c50571b0
BUG: 1465123
Signed-off-by: Shyam 
Reviewed-on: https://review.gluster.org/17631
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Atin Mukherjee

Revert "glusterd: disallow rebalance & remove-brick on a sharded volume"

2017-06-19T15:48:25+00:00

This reverts commit 8375b3d70d5c6268c6770b42a18b2e1bc09e411e.

Backport of:
> Change-Id: I45493fcbb1f25fd0fff27b2b3526c42642ccb464
> BUG: 1460585
> Reviewed-on: https://review.gluster.org/17506
> (cherry-picked from c0d4081cf4b90a4316b786cc53263a7c56fdb344)

Now that some of the users have confirmed rebalance works fine without
causing corruption of VMs, time to revert the CLI restriction.

Change-Id: I45493fcbb1f25fd0fff27b2b3526c42642ccb464
BUG: 1460997
Signed-off-by: Krutika Dhananjay 
Reviewed-on: https://review.gluster.org/17533
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Atin Mukherjee

index: Do not proceed with init if brick is not mounted

2017-06-19T15:48:10+00:00

..or else when a volume start force is given, we end up creating
/brick-path/.glusterfs/indices folder and various subdirs under it and
eventually starting the brick process.

As a part of this patch, glusterd_get_index_basepath() is added in
glusterd, who will then use it to create the basepath during
volume-create, add-brick, replace-brick and reset-brick. It also uses this
function to set the 'index-base' xlator option for the index translator.

> Reviewed-on: https://review.gluster.org/17426
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Atin Mukherjee 
> Reviewed-by: Pranith Kumar Karampuri 
(cherry picked from commit b58a15948fb3fc37b6c0b70171482f50ed957f42)

Change-Id: Id018cf3cb6f1e2e35b5c4cf438d1e939025cb0fc
BUG: 1462636
Signed-off-by: Ravishankar N 
Reviewed-on: https://review.gluster.org/17562
Smoke: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

core: fix spelling errors

2017-06-13T14:34:34+00:00

fixes for various minor spelling errors and typos

master BUG: 1457808
master: https://review.gluster.org/17442

Reported-by: Patrick Matthäi 
Change-Id: Ic1be36f82e3d822bbdc9559878bd79520fc0fcd5
BUG: 1459090
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: https://review.gluster.org/17475
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

tier: port value missing on cli parsing

2017-06-13T14:19:14+00:00

problem: as tier didn't have a port all the values regarding
the port were removed. but the cli needs a port value to parse and
print the status.

fix: fake the port value with a zero.

>Change-Id: I6491f6c441f7cfddbdaa724fcbe7c30e348aa765
>BUG: 1452006
>Signed-off-by: hari gowtham 
>Reviewed-on: https://review.gluster.org/17419
>Smoke: Gluster Build System 
>Tested-by: hari gowtham 
>Reviewed-by: Shyamsundar Ranganathan 
>Reviewed-by: Prashanth Pai 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Samikshan Bairagya 
>NetBSD-regression: NetBSD Build System 
>Reviewed-by: Atin Mukherjee 

Change-Id: I6491f6c441f7cfddbdaa724fcbe7c30e348aa765
BUG: 1457289
Signed-off-by: hari gowtham 
Reviewed-on: https://review.gluster.org/17487
Smoke: Gluster Build System 
Tested-by: hari gowtham 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Atin Mukherjee

Tier: removing port allocated for tier

2017-06-07T13:29:07+00:00

Problem: Tier has a port which it doesn't use.

Fix: Remove the port getting allocated for tier.

>Change-Id: If0fe393fc335d9f622a063787e0a3c6db9b7a50c
>BUG: 1452006
>Signed-off-by: hari gowtham 
>Reviewed-on: https://review.gluster.org/17328
>Tested-by: hari gowtham 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Smoke: Gluster Build System 
>Reviewed-by: Shyamsundar Ranganathan 

Change-Id: If0fe393fc335d9f622a063787e0a3c6db9b7a50c
BUG: 1457289
Signed-off-by: hari gowtham 
Reviewed-on: https://review.gluster.org/17428
Smoke: Gluster Build System 
Tested-by: hari gowtham 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Shyamsundar Ranganathan

glusterd : volume profile command on one of the node crashes glusterd

2017-05-25T15:31:53+00:00

When volume profile command is issued on one of the node glusterd
crashes. Its a race condition which may hit when profile command and
status command is being executed from node A and node B respectively.
While doing so event GD_OP_STATE_BRICK_OP_SENT/GD_OP_STATE_BRICK_COMMITTED
is being triggered. As handling of event is not thread safe, hence context
got modify and glusterd crashes.

With the fix now we are validating the context before using it.

> Reviewed-on: https://review.gluster.org/17350
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Samikshan Bairagya 
> NetBSD-regression: NetBSD Build System 
Reviewed-by: Atin Mukherjee 
(cherry picked from commit 8dc63c8824fc1a00c873c16e8a16a14fca7c8cca)

Change-Id: Ic07c3cdc5644677b0e40ff0fac6fcca834158913
BUG: 1454612
Signed-off-by: Gaurav Yadav 
Reviewed-on: https://review.gluster.org/17362
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

glusterd: ignore incorrect uuid validation if uuid_str is empty

2017-05-25T14:50:21+00:00

If uuid_str is not filled up in dictionary (when glusterd bit is old),
we shouldn't be additional validation with peer uuid otherwise the
handshake request will fail.

Refer :
http://lists.gluster.org/pipermail/gluster-users/2017-May/031187.html
Credits : pawan@platform.sh

>Reviewed-on: https://review.gluster.org/17358
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Amar Tumballi 
>Reviewed-by: Prashanth Pai 
>(cherry picked from commit b1fbc695a63801a3a2c62738fd6660388123724a)

Change-Id: I2c30bf0490c31d1418b31d555e7758696e79409f
BUG: 1455177
Signed-off-by: Atin Mukherjee 
Reviewed-on: https://review.gluster.org/17385
Smoke: Gluster Build System 
Reviewed-by: Prashanth Pai 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

glusterd: Eliminate race in brick compatibility checking stage

2017-05-25T13:13:16+00:00

In https://review.gluster.org/17307/, while looking for compatible
bricks for multiplexing, it is checked if the brick pidfile exists
before checking if the corresponding brick process is running.

However checking if the brick process is running just after
checking if the pidfile exists isn't enough since there might be
race conditions where the pidfile has been created but hasn't
been updated with a pid value yet. This commit solves that by
making sure that we wait iteratively till the pid value is updated
as well.

> Reviewed-on: https://review.gluster.org/17375
> Smoke: Gluster Build System 
> Reviewed-by: Atin Mukherjee 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 

(cherry picked from commit a8624b8b13a1f4222e4d3e33fa5836d7b45369bc)

Change-Id: Ib7a158f95566486f7c1f84b6357c9b89e4c797ae
BUG: 1453086
Signed-off-by: Samikshan Bairagya 
Reviewed-on: https://review.gluster.org/17383
Smoke: Gluster Build System 
Reviewed-by: Atin Mukherjee 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

Tier: Watermark check for hi and low value being equal

2017-05-23T23:48:48+00:00

Problem: Both low and hi watermark can be set to same value
as the check missed the case for being equal.

Fix: Add the check to both the hi and low values being equal
along with the low value being higher than hi value.

>Change-Id: Ia235163aeefdcb2a059e2e58a5cfd8fb7f1a4c64
>BUG: 1447960
>Signed-off-by: hari gowtham 
>Reviewed-on: https://review.gluster.org/17175
>Smoke: Gluster Build System 
>Tested-by: hari gowtham 
>Reviewed-by: Atin Mukherjee 
>Reviewed-by: Milind Changire 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 

Signed-off-by: hari gowtham 
Change-Id: Ia235163aeefdcb2a059e2e58a5cfd8fb7f1a4c64
BUG: 1454597
Reviewed-on: https://review.gluster.org/17364
Smoke: Gluster Build System 
Tested-by: hari gowtham 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Atin Mukherjee 
CentOS-regression: Gluster Build System