glusterfs.git/xlators/mgmt/glusterd/src, branch v3.10.4

Revert "Revert "glusterd: disallow rebalance & remove-brick on a sharded volume""

2017-07-04T14:39:29+00:00

This is being reverted as a new bug around rebalance has been uncovered. As a result we would like to retain the warning in the code and in the release-notes.

The new bug being, https://bugzilla.redhat.com/show_bug.cgi?id=1465075

A similar revert is being tracked for 3.11 here, https://review.gluster.org/17631 based on votes to both, we may want to consider this for 3.10 as well.

This reverts commit abaf577626650edb4b9dfdddd43ba04a2a8e8ef3.

BUG: 1467010
Change-Id: Iecd0357c44e41e2b421222e8f98fe8300513f963
Reviewed-on: https://review.gluster.org/17632
Reviewed-by: Raghavendra Talur 
Tested-by: Raghavendra Talur 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System

core: assorted typos and spelling mistakes from Debian lintian

2017-07-01T15:58:24+00:00

Plus minor readability improvements.

Reported-by: pmatthaei@debian.org
master BUG: 1466785
master https://review.gluster.org/17660
release-3.11 BUG: 1466801
release-3.11 https://review.gluster.org/17661
Change-Id: I5393819a2fc9f240a19811143bb57b127df717cf
BUG: 1466852
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: https://review.gluster.org/17663
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra Talur

rpc: add options to manage socket keepalive lifespan

2017-06-20T04:58:25+00:00

Problem:
Default values for handling socket timeouts for brick responses are
insufficient for aggressive applications such as databases.

Solution:
Add 1:1 gluster options for keepalive, keepalive-idle,
keepalive-interval and keepalive-timeout as per the socket level options
available as per tcp(7) man page.

Default values for options are NOT agressive and continue to be values
which result in default timeout when only the keep alive option is
turned on.

These options are Linux specific and will not be applicable to the
*BSDs.

mainline:
> BUG: 1426059
> Signed-off-by: Milind Changire 
> Reviewed-on: https://review.gluster.org/16731
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Raghavendra G 
(cherry picked from commit 6b8df081b46ac4f485c86a5052fc30472e74bfbb)

Change-Id: I2a08ecd949ca8ceb3e090d336ad634341e2dbf14
BUG: 1452038
Signed-off-by: Milind Changire 
Reviewed-on: https://review.gluster.org/17330
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra Talur

Revert "glusterd: disallow rebalance & remove-brick on a sharded volume"

2017-06-20T04:54:21+00:00

This reverts commit 8375b3d70d5c6268c6770b42a18b2e1bc09e411e.

Backport of:
> Change-Id: I45493fcbb1f25fd0fff27b2b3526c42642ccb464
> BUG: 1460585
> Reviewed-on: https://review.gluster.org/17506
> (cherry-picked from c0d4081cf4b90a4316b786cc53263a7c56fdb344)

Now that some of the users have confirmed rebalance works fine without
causing corruption of VMs, time to revert the CLI restriction.

Change-Id: I45493fcbb1f25fd0fff27b2b3526c42642ccb464
BUG: 1460993
Signed-off-by: Krutika Dhananjay 
Reviewed-on: https://review.gluster.org/17532
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Atin Mukherjee

tier: port value missing on cli parsing

2017-05-31T17:51:32+00:00

problem: as tier didn't have a port all the values regarding
the port were removed. but the cli needs a port value to parse and
print the status.

fix: fake the port value with a zero.

>Change-Id: I6491f6c441f7cfddbdaa724fcbe7c30e348aa765
>BUG: 1452006
>Signed-off-by: hari gowtham 
>Reviewed-on: https://review.gluster.org/17419
>Smoke: Gluster Build System 
>Tested-by: hari gowtham 
>Reviewed-by: Shyamsundar Ranganathan 
>Reviewed-by: Prashanth Pai 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Samikshan Bairagya 
>NetBSD-regression: NetBSD Build System 
>Reviewed-by: Atin Mukherjee 

Signed-off-by: hari gowtham 
Change-Id: I6491f6c441f7cfddbdaa724fcbe7c30e348aa765
BUG: 1456682
Reviewed-on: https://review.gluster.org/17427
Smoke: Gluster Build System 
Tested-by: hari gowtham 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Raghavendra Talur 
CentOS-regression: Gluster Build System

glusterd: Eliminate race in brick compatibility checking stage

2017-05-31T15:06:58+00:00

In https://review.gluster.org/17307/, while looking for compatible
bricks for multiplexing, it is checked if the brick pidfile exists
before checking if the corresponding brick process is running.

However checking if the brick process is running just after
checking if the pidfile exists isn't enough since there might be
race conditions where the pidfile has been created but hasn't
been updated with a pid value yet. This commit solves that by
making sure that we wait iteratively till the pid value is updated
as well.

> Reviewed-on: https://review.gluster.org/17375
> Smoke: Gluster Build System 
> Reviewed-by: Atin Mukherjee 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 

(cherry picked from commit a8624b8b13a1f4222e4d3e33fa5836d7b45369bc)

Change-Id: Ib7a158f95566486f7c1f84b6357c9b89e4c797ae
BUG: 1453087
Signed-off-by: Samikshan Bairagya 
Reviewed-on: https://review.gluster.org/17425
NetBSD-regression: NetBSD Build System 
Tested-by: Raghavendra Talur 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Raghavendra Talur

Tier: removing port allocated for tier

2017-05-31T06:00:16+00:00

Problem: Tier has a port which it doesn't use.

Fix: Remove the port getting allocated for tier.

>Change-Id: If0fe393fc335d9f622a063787e0a3c6db9b7a50c
>BUG: 1452006
>Signed-off-by: hari gowtham 
>Reviewed-on: https://review.gluster.org/17328
>Tested-by: hari gowtham 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Smoke: Gluster Build System 
>Reviewed-by: Shyamsundar Ranganathan 

Change-Id: If0fe393fc335d9f622a063787e0a3c6db9b7a50c
BUG: 1456682
Signed-off-by: hari gowtham 
Reviewed-on: https://review.gluster.org/17420
Smoke: Gluster Build System 
Tested-by: hari gowtham 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra Talur

Fixes upgrade issue in quota.conf

2017-05-31T05:58:24+00:00

When an op-version bump up is done the glusterd_store_quota_config
upgrades the quota conf file, although overwriting the same later
which leaves out all gfid entries. While this is warranted for
enable opcode, for upgrade we need to retain gfids. So for upgrade
opcode, we return once the upgrade is done.

> Reviewed-on: http://review.gluster.org/16425
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Atin Mukherjee 
> (cherry picked from commit 89cf743118ab6554c7f210754e51c4921cbb60c7)

Change-Id: I2b38c6022d74b4a14dc07432651a51cc39ad5120
BUG: 1450773
Signed-off-by: Sanoj Unnikrishnan 
Reviewed-on: https://review.gluster.org/17292
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra Talur

glusterd: Don't spawn new glusterfsds on node reboot with brick-mux

2017-05-30T13:36:40+00:00

With brick multiplexing enabled, upon a node reboot new bricks were
not being attached to the first spawned brick process even though
there wasn't any compatibility issues.

The reason for this is that upon glusterd restart after a node
reboot, since brick services aren't running, glusterd starts the
bricks in a "no-wait" mode. So after a brick process is spawned for
the first brick, there isn't enough time for the corresponding pid
file to get populated with a value before the compatibilty check is
made for the next brick.

This commit solves this by iteratively waiting for the pidfile to be
populated in the brick compatibility comparison stage before checking
if the brick process is alive.

> Reviewed-on: https://review.gluster.org/17307
> Reviewed-by: Atin Mukherjee 
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 

(cherry picked from commit 13e7b3b354a252ad4065f7b2f0f805c40a3c5d18)

Change-Id: Ibd1f8e54c63e4bb04162143c9d70f09918a44aa4
BUG: 1453087
Signed-off-by: Samikshan Bairagya 
Reviewed-on: https://review.gluster.org/17352
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Atin Mukherjee 
Reviewed-by: Raghavendra Talur

glusterd: ignore incorrect uuid validation if uuid_str is empty

2017-05-30T13:35:38+00:00

If uuid_str is not filled up in dictionary (when glusterd bit is old),
we shouldn't be additional validation with peer uuid otherwise the
handshake request will fail.

Refer :
http://lists.gluster.org/pipermail/gluster-users/2017-May/031187.html
Credits : pawan@platform.sh

>Reviewed-on: https://review.gluster.org/17358
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Amar Tumballi 
>Reviewed-by: Prashanth Pai 
>(cherry picked from commit b1fbc695a63801a3a2c62738fd6660388123724a)

Change-Id: I2c30bf0490c31d1418b31d555e7758696e79409f
BUG: 1455182
Signed-off-by: Atin Mukherjee 
Reviewed-on: https://review.gluster.org/17386
Smoke: Gluster Build System 
Reviewed-by: Prashanth Pai 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra Talur