glusterfs.git/xlators/mgmt/glusterd/src, branch release-3.9

snapshot: Fix restore rollback to reassign snap volume ids to bricks

2017-02-03T06:25:56+00:00

Added further checks to ensure we do not go beyond prevalidate
when trying to restore a snapshot which has a nfs-gansha conf
file, in a cluster when nfs-ganesha is not enabled

The error message for the particular scenario is:
"Snapshot() has a nfs-ganesha export conf
file. cluster.enable-shared-storage and nfs-ganesha
should be enabled before restoring this snapshot."

> Reviewed-on: http://review.gluster.org/16116
> Reviewed-by: Rajesh Joseph 
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 

Change-Id: I1b87e9907e0a5e162f26ef1ca89fe76e8da8610f
BUG: 1405909
Signed-off-by: Avra Sengupta 
Reviewed-on: https://review.gluster.org/16195
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: jiffin tony Thottan 
CentOS-regression: Gluster Build System 
Reviewed-by: Aravinda VK

glusterd/geo-rep: Fix geo-rep config issue

2017-01-11T04:53:52+00:00

Problem:
Geo-replication config commands fail when geo-rep
status is in 'Created'.

Cause:
During staging phase of geo-rep config, it checks
for the existence of 'monitor.pid' file. But the
pid file gets created only on start of geo-rep.
Hence it fails.

Fix:
Do not check for the existence of pid-file during
staging for config commands. It is not required.

> Change-Id: I626d368b249cf0423c7f49b4284465508371f566
> BUG: 1404678
> Signed-off-by: Kotresh HR 
> Reviewed-on: http://review.gluster.org/16132
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Aravinda VK 
> Reviewed-by: Atin Mukherjee 

Change-Id: I626d368b249cf0423c7f49b4284465508371f566
BUG: 1410707
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/16346
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Atin Mukherjee

glusterd (geo-rep): fix unused variable warnings/errors

2017-01-09T01:08:38+00:00

This patch fixes the fd leak when geo-rep config
command is run while geo-rep is running.

NOTE:
The patch is backport of http://review.gluster.org/15263
which was one of the collection of patches to fix the
bug https://bugzilla.redhat.com/show_bug.cgi?id=1369124

> Change-Id: I2edacd3d0f3924b1be0f0398ba9ac076459c5a61
> BUG: 1369124
> Signed-off-by: Kaleb S. KEITHLEY 
> Reviewed-on: http://review.gluster.org/15263
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Saravanakumar Arumugam 

Change-Id: I2edacd3d0f3924b1be0f0398ba9ac076459c5a61
BUG: 1410711
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/16345
Smoke: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

geo-rep: Do not restart workers when log-rsync-performance config change

2017-01-06T07:47:59+00:00

Geo-rep restarts workers when any of the configurations changed. We
don't need to restart workers if tunables like log-rsync-performance
is modified.

With this patch, Geo-rep workers will get new "log-rsync-performance"
config automatically without restart.

> Reviewed-on: http://review.gluster.org/15816
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Smoke: Gluster Build System 
> Reviewed-by: Kotresh HR 

BUG: 1402727
Change-Id: I40ec253892ea7e70c727fa5d3c540a11e891897b
Signed-off-by: Aravinda VK 
(cherry picked from commit a268e2865c21ec8d2b4fed26715e986cfcc66fad)
Reviewed-on: http://review.gluster.org/16070
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Kotresh HR

uss: snapd should enable SSL if SSL is enabled on volume

2017-01-03T06:46:50+00:00

During snapd graph generation we should check if SSL is
enabled on main volume or not. This is because clients
will communicate with snapd as if it is communicating to
a brick.

> Reviewed-on: http://review.gluster.org/15979
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Kaushal M 
(cherry picked from commit 182f0d12040dab5081ca645a3f370f65cd68b528)


Change-Id: I0d7fe86c567b297a8528a48faf06161d4c3cb415
Signed-off-by: Rajesh Joseph 
BUG: 1400460
Reviewed-on: http://review.gluster.org/15987
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Avra Sengupta 
Reviewed-by: Kaushal M

snapshot/ganesha: Copy export.conf, only if ganesha.enable is on.

2016-12-19T07:21:31+00:00

Status of the volume being exported via nfs ganesha, should be
checked by checking if ganesha.enable is set or not, rather than
deciding based on the errno of the stat

> Reviewed-on: http://review.gluster.org/16094
> CentOS-regression: Gluster Build System 
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: jiffin tony Thottan 
> Reviewed-by: Rajesh Joseph 

(cherry picked from commit 74322ce58b1c949e11cb0aa72bfded0e34422157)


Change-Id: Iaff786d9f77a2de1322ce8ccb4b80954f84d3373
BUG: 1404101
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/16112
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: jiffin tony Thottan 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Rajesh Joseph

glusterd: use GF_BRICK_STOPPING as intermediate brickinfo->status state

2016-12-15T07:07:43+00:00

On a volume stop trigger glusterd issues a brick-op to terminate the brick
process during brick-op phase , however in the commit-op glusterd once again
tries to kill the same process if it exists and then mark the brickinfo->status
flag to GF_BRICK_STOPPED. In the former case, if brick is successfully killed
there is a possibility that GlusterD will receive RPC_CLNT_DISCONNECT from the
said brick process before even the commit op phase is executed and hence by that
time brickinfo->status will still be set to GF_BRICK_STARTED.

BRICK_DISCONNECT event should be only sent if a brick has been killed and not
through a volume stop/remove brick trigger, however due to this trace, this
event is also sent out on a volume stop.

Fix is to introduce an intermediate state GF_BRICK_STOPPING which can be used to
mark the brick status at brick op phase of volume stop/remove brick to avoid
sending spurious BRICK_DISCONNECT events on a volume stop trigger.

>Reviewed-on: http://review.gluster.org/15699
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Kaushal M 

Change-Id: Ieed4450e1c988715e0f9958be44faa6b14be81e1
BUG: 1388461
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/15722
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Prashanth Pai

glusterd/geo-rep: Fix glusterd crash

2016-12-14T15:27:51+00:00

Problem:
glusterd crashes when geo-rep mountbroker setup is
created if the slave user length is more than
8 characters.

Cause:
_POSIX_LOGIN_NAME_MAX is used which is 9 including
NULL byte.

Analysis:
While the man page says it sufficient for portability, but
acutally it's not. Linux allows the creation of username
upto 32 characters by default where the max length is 256.
And NetBSD's max is 17.

Linux:
  #getconf LOGIN_NAME_MAX
   256
NetBSD:
  #getconf LOGIN_NAME_MAX
   17

Fix:
Use LOGIN_NAME_MAX instead of _POSIX_LOGIN_NAME_MAX

>Reviewed-on: http://review.gluster.org/16053
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Aravinda VK 
>Reviewed-by: Atin Mukherjee 

Change-Id: I26b7230433ecbbed6e6914ed39221a478c0266a8
BUG: 1403108
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/16084
Tested-by: Atin Mukherjee 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Atin Mukherjee

glusterd: Handle volinfo->refcnt properly during volume start command

2016-12-13T09:52:43+00:00

While running the volume start command, the refcnt of the volume is 
incremented. At the end of the command, the refcnt should also be
decremented. This is currently not the case.

This patch, makes sure the refcnt is also decremented at the end of the volume start command.

> Reviewed-on: http://review.gluster.org/16108
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Smoke: Gluster Build System 
> Reviewed-by: Atin Mukherjee 

(cherry picked from commit 9b1c9395a397e337e4a0acac55b935cb1ce094b7)

Change-Id: I017b5039be5948df41dde6bc89d2955d5d18971f
BUG: 1404104
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/16113
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Atin Mukherjee

glusterd/ganesha : handle volume reset properly for ganesha options

2016-12-08T03:07:40+00:00

The "gluster volume reset" should first unexport the volume and then delete
export configuration file. Also reset option is not applicable for ganesha.enable
if volume value is "all".
This patch also changes the name of create_export_config into manange_export_config

Upstream reference :
>Change-Id: Ie81a49e7d3e39a88bca9fbae5002bfda5cab34af
>BUG: 1397795
>Signed-off-by: Jiffin Tony Thottan 
>Reviewed-on: http://review.gluster.org/15914
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: soumya k 
>Reviewed-by: Kaleb KEITHLEY 
>Signed-off-by: Jiffin Tony Thottan 

Change-Id: Ie81a49e7d3e39a88bca9fbae5002bfda5cab34af
BUG: 1402366
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: http://review.gluster.org/16054
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY