glusterfs.git/xlators/mgmt/glusterd/src/glusterd-volume-ops.c, branch v3.4.0

glusterd: Introduce volume op-versions

2013-06-05T12:24:59+00:00

This is a backport of change
        9153855 glusterd: Introduce volume op-versions
from master.

Each volume is now associated with two op-versions,
 * op_version - the op-version of the highest op-versioned feature enabled
 * client_op_version - the op-version of the highest op-versioned feature
   enabled which affects the clients only.

These two op-versions are generated dynamically and kept updated during
runtime. Glusterd now uses the respective volumes' client-op-version during
getspec requests.

To achieve the above a new field in the vme table is introduced,
client_option, this boolean field tells if the option is a client side
option.

BUG: 907311
Change-Id: I59af02644a714e1c54fc89f1ead5aa551bba7ee7
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/4957
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd: Backport of vme table changes from master

2013-06-05T12:24:06+00:00

This patch backports the following changes from the master branch

99fe09f glusterd: Moved the volume entry table to a separate file.
e306d08 glusterd: Changing the volume entry table's representation.
eac54f6 glusterd: Added option description, and validation function fields.
bcb4235 glusterd: Added validation function for performance cache max and min size.
8897d08 glusterd: Added validation function for quota-timeout.
4579609 glusterd: Added validation function for stripe-block-size.
6788bad glusterd: Fix some options in vme table
549231d glusterd: Added the validation function for subvols-per-directory
9636e63 glusterd: Added description for nfs.transport-type option in volume set help.

Change-Id: I4a64ad94f17df4b45a3a32262a83e2c35fb5f7da
BUG: 907311
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/4956
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd: big lock - a coarse-grained locking to prevent races

2013-04-17T12:48:50+00:00

There are primarily three lists that are part of glusterd process,
that are concurrently accessed. Namely, priv->volumes, priv->peers
and volinfo->bricks_list.

Big-lock approach
-----------------
WHAT IS IT?
Big lock is a coarse-grained lock which protects all three
lists, mentioned above, from racy access.

HOW DOES IT WORK?
At any given point in time, glusterd's thread(s) are in execution
_iff_ there is a preceding, inbound network event. Of course, the
sigwaiter thread and timer thread are exceptions.
A network event is an external trigger to glusterd, via the epoll
thread, in the form of POLLIN and POLLERR.
As long as we take the big-lock at all such entry points and yield
it when we are done, we are guaranteed that all the network events,
accessing the global lists, are serialised.

This amounts to holding the big lock at
- all the handlers of all the actors in glusterd. (POLLIN)
- all the cbks in glusterd. (POLLIN)
- rpc_notify (DISCONNECT event), if we access/modify
  one of the three lists. (POLLERR)

In the case of synctask'ized volume operations, we must remember that,
if we held the big lock for the entire duration of the handler,
we may block other non-synctask rpc actors from executing.
For eg, volume-start would block in PMAP SIGNIN, if done incorrectly.
To prevent this, we need to yield the big lock, when we yield the
synctask, and reacquire on waking up of the synctask.

BUG: 948686
Change-Id: I429832f1fed67bcac0813403d58346558a403ce9
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/4835
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd: harden 'volume start' staging to check for brick dirs' presence

2013-02-09T03:13:36+00:00

PROBLEM:

When the brick directory of a volume is absent on any of the servers,
AND an attempt is made to start the volume, commit fails ONLY on the
node where the brick dir is absent, leading to a split-brain like
situation.

FIX:

Harden 'volume start' to check for the presence of brick directories
at the time of staging, thereby preventing commit failure.

Change-Id: I67faeb9afbd3aa76f08645924462db126bf7a977
BUG: 889996
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/4365
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

glusterd : Made volume clear-locks use synctask framework.

2013-02-08T22:08:22+00:00

Change-Id: Ia1fe3d0500d999c1f95b43c9e53947834e39d680
BUG: 852147
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/4490
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

glusterd: Made volume-stop use synctask framework.

2013-02-08T21:29:16+00:00

Change-Id: I88270f70538bb89d828bb51830b54e9f59be258a
BUG: 852147
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/4491
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

glusterd: Made volume-delete use synctask framework.

2013-02-08T21:28:58+00:00

Change-Id: I52573bb49946f904484e2ead483e8f6f41cbd0c8
BUG: 852147
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/4492
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

glusterd: Made volume-statedump use synctask framework.

2013-02-08T20:03:42+00:00

Change-Id: I230ecbd8978725070b5910ead4249f21038224a6
BUG: 852147
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/4494
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

glusterd: synctaskize 'volume create' operation

2013-02-07T07:39:52+00:00

.. and also move brickpath validation to volume create stage

Change-Id: Ia028677932ca5f6aa05dcf624f47033b62e7b212
BUG: 862834
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/4213
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Anand Avati

glusterd: remove extra call to glusterd_volume_compute_cksum()

2013-02-05T03:23:00+00:00

In the commit phase of volume create, checksum on volinfo is
computed twice - once in the call to glusterd_store_volinfo() and once,
further down, in the same function glusterd_op_create_volume().

Change-Id: I36f9426943cd48937d4946b4b4ef09f19f31d888
BUG: 812356
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/4463
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati