glusterfs.git/xlators/mgmt/glusterd/src/glusterd-syncop.c, branch v3.4.0alpha2

glusterd: Increasing throughput of synctask based mgmt ops.

2013-03-07T06:06:30+00:00

Change-Id: Ibd963f78707b157fc4c9729aa87206cfd5ecfe81
BUG: 913662
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/4638
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy

glusterd : Made volume clear-locks use synctask framework.

2013-02-08T22:08:22+00:00

Change-Id: Ia1fe3d0500d999c1f95b43c9e53947834e39d680
BUG: 852147
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/4490
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

glusterd: do dict unref after sending reply to cli

2013-02-03T20:35:09+00:00

This patch channelizes dict unrefs of dictionaries created from the cli
req during volume ops to one common function - glusterd_to_cli() - which
is guaranteed to be called irrespective of whether the command succeeds
or fails.

This patch also removes extra unrefs at a few places.

Change-Id: Ic8ba7166387b5dfd1f5ae860539e1b7093a94662
BUG: 861044
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/4003
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Anand Avati

glusterd: Made volume-status use synctask framework

2013-02-03T19:56:18+00:00

Change-Id: Id4062799104e5831467ced65a43bfe377b6163f4
BUG: 852147
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/4297
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

glusterd: Added syncop version of BRICK_OP

2013-02-03T19:54:16+00:00

- Made rsp dict available to all glusterd's STAGE/BRICK/COMMIT OP.

Change-Id: I5d825d0670d0f1aa8a0603f2307b3600ff6ccfe4
BUG: 852147
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/4296
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Anand Avati

glusterd: Removed start-unlock event injection in 'synctask' codepath

2013-02-03T19:51:03+00:00

Change-Id: I87e02c95d0b650dab7f9ee86c96b2e09ada50109
BUG: 862834
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/4118
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Anand Avati

glusterd: log enhancements for volume start

2013-01-04T15:26:25+00:00

* changed some of the log messages to give as much information as
  available in case of failure

* added logs to identify on which machine lock/stage/commit failed

* added macros to represent error strings to maintain uniformity
  among error messages for a given kind of error

* moved error logs wherever possible, from caller to callee to avoid
  code duplication

Change-Id: I0e98d5d3ba086c99240f2fbd642451f175f51942
BUG: 812356
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/4353
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Vijay Bellur 
Tested-by: Vijay Bellur

glusterd: log appropriate message when locking fails

2012-12-12T00:06:08+00:00

PROBLEM:

When a transaction is already in progress, and the user tries to
execute another glusterd operation, the second operation fails as
glusterd fails to acquire lock. But to the user, a message like
"Operation failed" does not give ample information about why the
operation failed.

FIX:

Made glusterd_op_txn_begin use and initialise error string, which is
needed to capture failure in the "lock" phase.

Also made gd_sync_task_begin set error string appropriately when
locking fails.

In the process, I had to introduce error string in some glusterd_handle_*
functions. And because I introduced error string in these handlers, I
decided to also set them in places where these handlers could possibly
fail.

HOW I TESTED IT:

For want of a better idea, I "commented out" the call to
"glusterd_unlock", recompiled glusterd and ran two glusterd volume
operations, one after the other. The second operation fails with the
message "Another transaction is in progress. Please try again after
sometime." as expected.

The tests were performed on two volume ops : one of them
synctask'ized (volume start) and the other NOT (volume create).

Change-Id: Ia862972929872ae2f053707a544824d9cadc37be
BUG: 873549
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/4197
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

glusterd: copy peers that participate in volume xaction

2012-11-19T06:21:35+00:00

- To avoid working with a mutable list of peers in
  the scope of a volume xaction.

Change-Id: I228ae96bccdce127026eff8320adb37b17e2cc6a
BUG: 862834
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/4113
Reviewed-by: Vijay Bellur 
Tested-by: Gluster Build System

glusterd: Fixed glusterd crash in volume add-brick

2012-11-12T15:08:35+00:00

PROBLEMS:

a. glusterd crashes when add-brick operation fails on the machine other
   than the originator, owing to double free done on op_errstr:
   once in glusterd_op_begin_synctask and once through a dict unref on
   req_dict in gd_sync_task_begin.

b. In gd_sync_task_begin, there's no need to place the error string
   in the dictionary, when it is never retrieved and used elsewhere.

c. Command execution status is not logged into .cmd_log_history.

FIX:

For (a) and (b): Knocked off code that places the error string in req_dict.
That way, both the problems are solved.

For (b), passed op_ctx to glusterd_op_send_cli_response as it is needed to
extract the command string before logging.

Change-Id: I549a07ba5e31332b691a8cacd1ab32c2673810ba
BUG: 862834
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/4102
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System