glusterfs.git/xlators/mgmt/glusterd/src/glusterd-snapshot.c, branch v3.7.7

all: reduce "inline" usage

2016-01-18T09:02:34+00:00

There are three kinds of inline functions: plain inline, extern inline,
and static inline.  All three have been removed from .c files, except
those in "contrib" which aren't our problem.  Inlines in .h files, which
are overwhelmingly "static inline" already, have generally been left
alone.  Over time we should be able to "lower" these into .c files, but
that has to be done in a case-by-case fashion requiring more manual
effort.  This part was easy to do automatically without (as far as I can
tell) any ill effect.

In the process, several pieces of dead code were flagged by the
compiler, and were removed.

backport of Change-Id: I56a5e614735c9e0a6ee420dab949eac22e25c155,
http://review.gluster.org/11769, BUG: 1245331

Change-Id: Iba1efb0bc578ea4a5e9bf76b7bd93dc1be9eba44
BUG: 1283302
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/12646
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos

snapshot: Fix quorum check for clone

2015-12-04T07:14:33+00:00

    Backport of http://review.gluster.org/#/c/12490/

snapshot clone was not performing quorum check
and was just relying on glusterd server quorum.

Wrote glusterd_snap_quorum_check_for_clone(), to
perform the same. Also moved common quorum check code
from glusterd_snap_quorum_check_for_create(), to
glusterd_snap_common_quorum_chk_clone_create() to be
shared by both

Change-Id: Ib78c709186841780876de8ef7d7c9243b7f67995
BUG: 1288030
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/12490
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Rajesh Joseph 
(cherry picked from commit cb7da0ffba147173bc9e6cd05f0a88a2c1ac9cdc)
Reviewed-on: http://review.gluster.org/12869
Reviewed-by: mohammed rafi  kc

snapshot/clone : Fix tier pause failure for snapshot clone

2015-12-03T05:58:56+00:00

    Backport of http://review.gluster.org/#/c/12548

On a tiered volume, snapshot clone fails while trying to
pause tier, as we pass volname(snap) to the brick_op_phase module,
which tries to look for the snap volume amongst regular
volumes, and obviously doesn't find it and fail.

Well as snapshot volumes are read only volume, and will not
have tiering daemon acting upon them, there is really no need
to pause tiereing while taking clone of snapshot volumes. Hence
removing the code to pause and resume tiering during clone create.

Change-Id: I2266aba589a830a13a806c0d8a56fd8855143ccd
BUG: 1287538
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/12846
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Rajesh Joseph

snapshot: Inherit snap-max-hard-limit from original volume

2015-11-18T06:37:55+00:00

    Backport of http://review.gluster.org/#/c/12437/

A snapshot should inherit snap-max-hard-limit from the original
volume while being created and when being restored to, it should
restore the same.

Similarly a clone taken from a snapshot should inherit
snap-max-hard-limit from the snapshot.

Change-Id: If8e90e2ffc10e22086b803ac8e2638a16bcec968
BUG: 1277390
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/12437
Tested-by: Gluster Build System 
Reviewed-by: mohammed rafi  kc 
Tested-by: NetBSD Build System 
Reviewed-by: Rajesh Joseph 
(cherry picked from commit 1f74a3efbd0337759878ffff5cd4ee6782ddfe3f)
Reviewed-on: http://review.gluster.org/12492

snapshot : copying nfs-ganesha export file

2015-11-10T11:39:13+00:00

Backport of http://review.gluster.org/#/c/12483/

While taking snapshot, the export file used by the volume should
copy to snap directory. So that when restore of snapshot happens,
the volume can retain all its configuration for exporting via
nfs-ganesha. The export file is stored at "/etc/ganesha/export" in
the following format "export..conf"

The fix handles given cases in the following manner :

case a: The nfs-ganesha(global) is ON during snapshot and restore.
        i.) Volume was exported during snapshot. When we restore snapshot,
            then volume should be exported back with old configuration file.
        ii.) Volume was unexported during snapshot. When we restore snapshot,
             then volume should unexported again.

case b: The nfs-ganesha is ON during snapshot and OFF during restore
        Volume was exported during snapshot. When we restore snapshot, the
        conf will be copied to corresponding location and if nfs-ganesha enabled
        again, then volume will be exported.

For the clones, export conf file will created in /etc/ganesha/export and then
export it via ganesha.

Upstream Reference:

(cherry picked from commit 5583bac79851d24f0a552478b361049fe63c32b7)
>Change-Id: Ideecda15bd4db58e991cf6c8de7bb93f3db6cd20
>BUG: 1257709
>Signed-off-by: Jiffin Tony Thottan 
>Reviewed-on: http://review.gluster.org/12034
>Reviewed-by: Avra Sengupta 
>Tested-by: Gluster Build System 
>Reviewed-by: Kaleb KEITHLEY 

Change-Id: I19725ec3d093fb32067bba4aba7f5bc3fd61b0e3
BUG: 1257710
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: http://review.gluster.org/12483
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Avra Sengupta 
Reviewed-by: Kaleb KEITHLEY

snapshot: Fix snapshot clone postvalidate

2015-10-27T09:06:27+00:00

    BackPort Of http://review.gluster.org/#/c/12364/

In glusterd_snapshot_clone_postvalidate(), we were deleting
snap object and snap vol, by looking up snapname. Hence, it
was deleting the orignal snapshot from which the clone was
being created

Instead it should fetch the clonename, the respective
clone vol, and its corresponding snap object, and delete them.

Also glusterd_snap_remove(), needs to differentiate a clone
snap object from a snaphsot snap object, as in case of a clone
snap object, we don't have any persisted data in
/var/run/gluster/snaps/ and hence is shouldn't try to delete
anything there.

Change-Id: I02bb22a3898d5720e318a02d6cc32d25f75d317d
BUG: 1271627
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/12364
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: mohammed rafi  kc 
Reviewed-by: Rajesh Joseph 
(cherry picked from commit 59401a32de51cdb6c1a5a1208723e89e1a4abd30)
Reviewed-on: http://review.gluster.org/12406

cluster/tier: add pause tier for snapshots

2015-10-22T02:46:18+00:00

This is a backport of 12304

Snaps of tiered volumes cannot handle files undergoing migration.
We implement a helper mechanism to "pause" migration. Any files
undergoing migration are aborted. Clean up is done to remove
sticky bits and data at the destination. Migration is restarted
after snap completes.

For testing an internal switch is added. It is not exposed externally.

gluster volume set vol1 tier-pause [true|false]

> Change-Id: Ia85bbf89ac142e9b7e73fcbef98bb9da86097799
> BUG: 1267950
> Signed-off-by: Dan Lambright 
> Reviewed-on: http://review.gluster.org/12304
> Reviewed-by: N Balachandran 
> Tested-by: NetBSD Build System 
> Tested-by: Gluster Build System 
Signed-off-by: Dan Lambright 

Conflicts:
	xlators/mgmt/glusterd/src/glusterd-messages.h

Change-Id: I5f039d8d38a4c915bd873969f336b96755a0b8f1
BUG: 1274101
Reviewed-on: http://review.gluster.org/12411
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright 
Tested-by: Dan Lambright

gluster/cli: snapshot delete all does not work with xml

2015-09-01T06:40:52+00:00

    Backport of http://review.gluster.org/#/c/12027/

Problem: snapshot delete all command fails with --xml option
Fix: Provided xml support for delete all command

Change-Id: I77cad131473a9160e188c783f442b6a38a37f758
BUG: 1258113
Signed-off-by: Rajesh Joseph 
Reviewed-on: http://review.gluster.org/12027
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Avra Sengupta 
(cherry picked from commit fd47635a4ffab621a2357c99cd1edd0482940bd5)
Reviewed-on: http://review.gluster.org/12042

snapshot:cleanup snaps during unprobe

2015-09-01T06:39:43+00:00

    Backport of http://review.gluster.org/#/c/9930/

When doing an unprobe, the volume that doesnot
contain any brick of the particular node will be
deleted. So the snaps associated with that volume
should also delete

Change-Id: I9f3d23bd11b254ebf7d7722cc1e12455d6b024ff
BUG: 1255384
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/11970
Tested-by: NetBSD Build System 
Reviewed-by: Rajesh Joseph

snapshot: Log deletion of snapshot, during auto-delete

2015-08-24T06:51:05+00:00

    Backport of http://review.gluster.org/#/c/11963/

When auto-delete is enabled, and soft-limit is reached,
on creation of a snapshot, the oldest snapshot for that
volume is deleted.

Displaying a warning log before deleting the oldest
snapshot.

Change-Id: I75f0366935966a223b63a4ec5ac13f9fe36c0e82
BUG: 1255311
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/11964
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: mohammed rafi  kc 
Reviewed-by: Rajesh Joseph