glusterfs.git/xlators/mgmt/glusterd/src/glusterd-snapshot-utils.c, branch v3.7.18

snapshot/snapd: Don't display pid when snapd is offline

2016-08-22T08:34:31+00:00

    Backport of http://review.gluster.org/#/c/14981/

We were previously reading the pidfile, and displaying
the pid even if snapd daemon is not running. Now to fix
it, we re-assign pid value to -1, if snapd is offline.

> Reviewed-on: http://review.gluster.org/14981
> Tested-by: Vijay Bellur 
> NetBSD-regression: NetBSD Build System 
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Jeff Darcy 

(cherry picked from commit ec6925a379c7bee071df1638bc2751b266cee346)

Change-Id: I4baff8d489fe9380061c52aea006db90fa421cd7
BUG: 1360979
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/15032
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Rajesh Joseph

glusterd/snapshot: Fix snapshot creation with geo-rep

2016-06-02T05:50:47+00:00

Backport of http://review.gluster.org/#/c/14595

The construction of path to geo-rep session directory
is broken with the commit "http://review.gluster.org/13111"
as it saves the slave volume uuid in 'gsync_slaves'
dictionary. This patch fixes the same.

Change-Id: Ic7fc3c37d368549feb44b3a08d60157ce61227c3
Signed-off-by: Kotresh HR 
BUG: 1341478
Reviewed-on: http://review.gluster.org/14597
Smoke: Gluster Build System 
Reviewed-by: Saravanakumar Arumugam 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Rajesh Joseph

snapshot/quota: Copy quota.cksum during snapshot operations

2016-04-26T15:58:20+00:00

    Backport of http://review.gluster.org/#/c/13760/

A volume having a quota.conf file, should always have
a quota.cksum file too. Based on this above assumption
modifying glusterd_copy_quota_files() to always copy
quota.cksum, if quota.conf is present.

This change will be reflected when a snapshot is created,
restored and cloned.

Change-Id: Ia49dc26eacef32eeb8f7d7d9553c80e304b08779
BUG: 1329492
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/13760
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Vijaikumar Mallikarjuna 
Reviewed-by: Rajesh Joseph 
(cherry picked from commit 8f3ad1e3ede77fa5f8c8d606e18a7e83865a822c)
Reviewed-on: http://review.gluster.org/14047

glusterd: coverity warning in gluster_copy_nfs_ganesha_file()

2016-03-05T23:50:52+00:00

fix unused return value from snprintf.

Also minor cleanup, including safe handling of truncated output
by snprintf, and lstat() -> sys_lstat()

backport from mainline:
>Change-Id: Ibec8c7e6cc4ef07b6535d01a0719359fa3ef8030
>BUG: 1310755
>Reviewed-on: http://review.gluster.org/13486

Change-Id: Ic893751c5ce83c85b01c311091f2728d4997e599
BUG: 1315009
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/13612
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Vijay Bellur

snapshot: Return before redundant quorum check

2016-01-20T06:57:21+00:00

    Backport of http://review.gluster.org/#/c/13260/

As of today, we don't support creation of snapshot even
if one brick is down. Hence the older quorum check is
redundant. Returning after performing the check to
see if all bricks are up.

Change-Id: I35661d05a15be0109aaae51b4fe0d5a8ca4333ad
BUG: 1299822
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/13261
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Rajesh Joseph

snapshot: Fix quorum check for clone

2015-12-04T07:14:33+00:00

    Backport of http://review.gluster.org/#/c/12490/

snapshot clone was not performing quorum check
and was just relying on glusterd server quorum.

Wrote glusterd_snap_quorum_check_for_clone(), to
perform the same. Also moved common quorum check code
from glusterd_snap_quorum_check_for_create(), to
glusterd_snap_common_quorum_chk_clone_create() to be
shared by both

Change-Id: Ib78c709186841780876de8ef7d7c9243b7f67995
BUG: 1288030
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/12490
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Rajesh Joseph 
(cherry picked from commit cb7da0ffba147173bc9e6cd05f0a88a2c1ac9cdc)
Reviewed-on: http://review.gluster.org/12869
Reviewed-by: mohammed rafi  kc

snapshot : copying nfs-ganesha export file

2015-11-10T11:39:13+00:00

Backport of http://review.gluster.org/#/c/12483/

While taking snapshot, the export file used by the volume should
copy to snap directory. So that when restore of snapshot happens,
the volume can retain all its configuration for exporting via
nfs-ganesha. The export file is stored at "/etc/ganesha/export" in
the following format "export..conf"

The fix handles given cases in the following manner :

case a: The nfs-ganesha(global) is ON during snapshot and restore.
        i.) Volume was exported during snapshot. When we restore snapshot,
            then volume should be exported back with old configuration file.
        ii.) Volume was unexported during snapshot. When we restore snapshot,
             then volume should unexported again.

case b: The nfs-ganesha is ON during snapshot and OFF during restore
        Volume was exported during snapshot. When we restore snapshot, the
        conf will be copied to corresponding location and if nfs-ganesha enabled
        again, then volume will be exported.

For the clones, export conf file will created in /etc/ganesha/export and then
export it via ganesha.

Upstream Reference:

(cherry picked from commit 5583bac79851d24f0a552478b361049fe63c32b7)
>Change-Id: Ideecda15bd4db58e991cf6c8de7bb93f3db6cd20
>BUG: 1257709
>Signed-off-by: Jiffin Tony Thottan 
>Reviewed-on: http://review.gluster.org/12034
>Reviewed-by: Avra Sengupta 
>Tested-by: Gluster Build System 
>Reviewed-by: Kaleb KEITHLEY 

Change-Id: I19725ec3d093fb32067bba4aba7f5bc3fd61b0e3
BUG: 1257710
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: http://review.gluster.org/12483
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Avra Sengupta 
Reviewed-by: Kaleb KEITHLEY

snapshot: Fix snapshot clone postvalidate

2015-10-27T09:06:27+00:00

    BackPort Of http://review.gluster.org/#/c/12364/

In glusterd_snapshot_clone_postvalidate(), we were deleting
snap object and snap vol, by looking up snapname. Hence, it
was deleting the orignal snapshot from which the clone was
being created

Instead it should fetch the clonename, the respective
clone vol, and its corresponding snap object, and delete them.

Also glusterd_snap_remove(), needs to differentiate a clone
snap object from a snaphsot snap object, as in case of a clone
snap object, we don't have any persisted data in
/var/run/gluster/snaps/ and hence is shouldn't try to delete
anything there.

Change-Id: I02bb22a3898d5720e318a02d6cc32d25f75d317d
BUG: 1271627
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/12364
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: mohammed rafi  kc 
Reviewed-by: Rajesh Joseph 
(cherry picked from commit 59401a32de51cdb6c1a5a1208723e89e1a4abd30)
Reviewed-on: http://review.gluster.org/12406

snapshot:cleanup snaps during unprobe

2015-09-01T06:39:43+00:00

    Backport of http://review.gluster.org/#/c/9930/

When doing an unprobe, the volume that doesnot
contain any brick of the particular node will be
deleted. So the snaps associated with that volume
should also delete

Change-Id: I9f3d23bd11b254ebf7d7722cc1e12455d6b024ff
BUG: 1255384
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/11970
Tested-by: NetBSD Build System 
Reviewed-by: Rajesh Joseph

glusterd: Porting left out log messages to new framework

2015-06-27T06:56:09+00:00

This is a backport of http://review.gluster.org/11388
cherry-picked from commit 23c1e6dc0fa86c014e1a8b6aa5729675f6d69017
>Change-Id: I70d40ae3b5f49a21e1b93f82885cd58fa2723647
>BUG: 1235538
>Signed-off-by: Nandaja Varma 

Change-Id: I70d40ae3b5f49a21e1b93f82885cd58fa2723647
BUG: 1217722
Signed-off-by: Nandaja Varma 
Reviewed-on: http://review.gluster.org/11422
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Anand Nekkunti 
Reviewed-by: Kaushal M