glusterfs.git/xlators/mgmt/glusterd/src/glusterd-handler.c, branch v3.12.6

glusterd: clean up portmap on brick disconnect

2017-11-06T06:09:45+00:00

GlusterD's portmap entry for a brick is cleaned up when a PMAP_SIGNOUT event is
initiated by the brick process at the shutdown. But if the brick process crashes
or gets killed through SIGKILL then this event is not initiated and glusterd
ends up with a stale port. Since GlusterD's portmap traversal happens both ways,
forward for allocation and backward for registry search, there is a possibility
that glusterd might end up running with a stale port for a brick which
eventually will end up with clients to fail to connect to the bricks.

Solution is to clean up the port entry in case the process is down as
part of the brick disconnect event. Although with this the handling
PMAP_SIGNOUT event becomes redundant in most of the cases, but this is
the safeguard method to avoid glusterd getting into the stale port
issues.

> mainline patch : https://review.gluster.org/#/c/18541/

Change-Id: I04c5be6d11e772ee4de16caf56dbb37d5c944303
BUG: 1507747
Signed-off-by: Atin Mukherjee 
(cherry picked from commit 30e0b86aae00430823f2523c6efa3c4ebbf0a478)

glusterd: fix brick restart parallelism

2017-11-06T06:09:21+00:00

glusterd's brick restart logic is not always sequential as there is
atleast three different ways how the bricks are restarted.
1. through friend-sm and glusterd_spawn_daemons ()
2. through friend-sm and handling volume quorum action
3. through friend handshaking when there is a mimatch on quorum on
friend import.

In a brick multiplexing setup, glusterd ended up trying to spawn the
same brick process couple of times as almost in fraction of milliseconds
two threads hit glusterd_brick_start () because of which glusterd didn't
have any choice of rejecting any one of them as for both the case brick
start criteria met.

As a solution, it'd be better to control this madness by two different
flags, one is a boolean called start_triggered which indicates a brick
start has been triggered and it continues to be true till a brick dies
or killed, the second is a mutex lock to ensure for a particular brick
we don't end up getting into glusterd_brick_start () more than once at
same point of time.

Change-Id: I292f1e58d6971e111725e1baea1fe98b890b43e2
BUG: 1508283
Signed-off-by: Atin Mukherjee 
(cherry picked from commit 82be66ef8e9e3127d41a4c843daf74c1d8aec4aa)

glusterd:Marking all the brick status as stopped when a process goes down in brick multiplexing

2017-10-12T18:49:37+00:00

In brick multiplexing environment, if a brick process goes down
i.e., if we kill it with SIGKILL, the status of the brick for which
the process came up for the first time is only changing to stopped.
all other brick statuses are remain started. This is happening because
the process was killed abruptly using SIGKILL signal and signal
handler wasn't invoked and further cleanup wasn't triggered.

When we try to start a volume using force, it shows error saying
"Request timed out", since all the brickinfo->status are still in
started state, we're waiting for one of the brick process to come up
which never going to happen since the brick process was killed.

To resolve this, In the disconnect event, We are checking all the
processes that whether the brick which got disconnected belongs the
process. Once we get the process we are calling a function named
glusterd_mark_bricks_stopped_by_proc() and sending brick_proc_t object as
an argument.

From the glusterd_brick_proc_t we can get all the bricks attached
to that process. but these are duplicated ones. To get the original
brickinfo we are reading volinfo from brick. In volinfo we will have
original brickinfo copies. We are changing brickinfo->status to
stopped for all the bricks.

>Change-Id: Ifb9054b3ee081ef56b39b2903ae686984fe827e7
>BUG: 1499509
>Signed-off-by: Sanju Rakonde 
>Reviewed-on: https://review.gluster.org/#/c/18444/
>Smoke: Gluster Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Atin Mukherjee 
>cherry picked from commit 9422446d72bc054962d72ace9912ecb885946d49)

Change-Id: Ifb9054b3ee081ef56b39b2903ae686984fe827e7
BUG: 1501154
Signed-off-by: Sanju Rakonde

glusterd: fix client io-threads option for replicate volumes

2017-10-09T12:21:08+00:00

Backport of https://review.gluster.org/#/c/18430/

Problem:
Commit ff075a3d6f9b142911d25c27fd209838782bfff0 disabled loading
client-io-threads for replicate volumes (it was set to on by default in
commit e068c1997314046658dd502e9118dab32decf879) due to performance
issues but in doing so, inadvertently failed to load the xlator even if
the user explicitly enabled the option using the volume set command.
This was despite returning returning sucess for the volume set.

Fix:
Modify the check in perfxl_option_handler() and add checks in volume
create/add-brick/remove-brick code paths, tying it all to
GD_OP_VERSION_3_12_2.

Change-Id: Ib612973a999a7da818cc926f5c2601b1f0794fcf
BUG: 1499158
Signed-off-by: Ravishankar N

tier: separation of attach-tier from add-brick

2017-08-04T20:34:03+00:00

PROBLEM: Both attach tier and add brick have the same RPC
and set of code. This becomes a hurdle while tring to implement
add brick on a tiered volume.

FIX: This patch separates the add brick and attach tier
giving them separate RPCs.

>Change-Id: Iec57e972be968a9ff00b15b507e56a4f6dc398a2
>BUG: 1376326
>Signed-off-by: hari gowtham 
>Reviewed-on: https://review.gluster.org/15503
>Smoke: Gluster Build System 
>Tested-by: hari gowtham 
>Reviewed-by: Samikshan Bairagya 
>CentOS-regression: Gluster Build System 

Signed-off-by: hari gowtham 
Change-Id: Iec57e972be968a9ff00b15b507e56a4f6dc398a2
BUG: 1478276
Reviewed-on: https://review.gluster.org/17974
Smoke: Gluster Build System 
Tested-by: hari gowtham 
Reviewed-by: Shyamsundar Ranganathan 
CentOS-regression: Gluster Build System

glusterd: Add geo-replication session details to get-state output

2017-08-04T13:32:52+00:00

This commit adds support to the get-state CLI to capture details
on geo-replication session as obtained in
`gluster volume geo-replication status detail` in its output.

> Reviewed-on: https://review.gluster.org/17941
> Smoke: Gluster Build System 
> Reviewed-by: Shubhendu Tripathi 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Atin Mukherjee 

(cherry picked from commit 2e7daeffef05c6100cbcc39f1be62935711db3eb)

Fixes: #291
Change-Id: I2fbcba70bfdaf439522637234805545194777ed4
Signed-off-by: Samikshan Bairagya 
Reviewed-on: https://review.gluster.org/17971
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

logging: localtime logging, cmdline, volume set option

2017-08-03T12:04:50+00:00

Despite the fact that appliances generally use UTC, some
users really want log entries in localtime.

fixes gluster/glusterfs#272

feature page: https://review.gluster.org/17807

Backport from master https://review.gluster.org/#/c/16911/

Change-Id: I5fbf2c3eedd9eb128fb3f851dd67b2f4081c8bba
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: https://review.gluster.org/17928
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

glusterd: add rebal estimates time in get-state

2017-08-02T15:03:24+00:00

>Reviewed-on: https://review.gluster.org/17862
>Smoke: Gluster Build System 
>Reviewed-by: Samikshan Bairagya 
>CentOS-regression: Gluster Build System 
>(cherry picked from commit 1431786305055e0fe90e012e03278f504a2d8d14)

Fixes: #279
Change-Id: If62fa59042604c9450749d3012c7a962ed0eb374
Signed-off-by: Atin Mukherjee 
Reviewed-on: https://review.gluster.org/17871
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

glusterd: Add option to get all volume options through get-state CLI

2017-07-31T17:34:26+00:00

This commit makes the get-state CLI capable to returning the values
for all volume options for all volumes. This is similar to what you
get when you issue a `gluster volume get  all` command.

This is the new usage for the get-state CLI:

 # gluster get-state [] [[odir ] \
[file ]] [detail|volumeoptions]

> Reviewed-on: https://review.gluster.org/17858
> CentOS-regression: Gluster Build System 
> Reviewed-by: Atin Mukherjee 
> Reviewed-by: Gaurav Yadav 
> Smoke: Gluster Build System 

(cherry picked from commit 8dcf91660e0bd10eb75ef25a29ca02ec51c81be4)

Change-Id: Ice52d936a5a389c6fa0ba5ab32416a65cdfde46d
Fixes: #277
Signed-off-by: Samikshan Bairagya 
Reviewed-on: https://review.gluster.org/17874
Reviewed-by: Atin Mukherjee 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System

glusterd: highlight arbiter brick in get-state

2017-07-31T17:31:40+00:00

>Reviewed-on: https://review.gluster.org/17864
>Reviewed-by: Ravishankar N 
>Reviewed-by: Samikshan Bairagya 
>Reviewed-by: Shubhendu Tripathi 
>Smoke: Gluster Build System 
>CentOS-regression: Gluster Build System 
>(cherry picked from commit 555990188ae7fabd4ca36c07ddaa92a39dccc813)

Fixes: #278
Change-Id: I1af5255127457a70e6362a2c20c53ee533e27c29
Signed-off-by: Atin Mukherjee 
Reviewed-on: https://review.gluster.org/17875
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan