glusterfs.git/xlators/mgmt/glusterd/src/glusterd-geo-rep.c, branch release-3.3

geo-rep: retire old style ssh setup

2013-04-27T16:36:58+00:00

Users are still using geo-rep with the old, deprecated, insecure, unsupported
ssh setup. Not their fault -- the implementation of the new method had the
following charasteristics:
- old method is possible, but with default settings it's not working
- it can be made operational by fiddling with "remote-gsyncd" tunable
- with default setting, an unhelpful, actually misleading error message is
  produced
- the UI gave no hint to the changes in the ssh setup

http://review.gluster.org/4392 tried to fix these; what it accomplished was
unrestricted support to the bad practice (by making the default old setup
operational).

From this on:
- we disable the old method by reserving the "remote-gsyncd" tunable
- if the old method is attempted, give a hint what to do

Change-Id: Icade94725d8d8d2d4c89cab992d4226351637b86
BUG: 895656
Signed-off-by: Csaba Henk 
Reviewed-on: http://review.gluster.org/4892
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd / geo-rep : fix rotating slave log file

2012-05-28T07:50:05+00:00

Attempt to rotate log files for slave that are local.
Remote slaves (identified by the 'ssh' scheme) are
ignored.

Change-Id: Iff46462c388d39433917159c0e89e7ac9e772c0f
BUG: 821443
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.com/3459
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd/geo-rep: cleanup and fixes

2012-05-27T18:25:55+00:00

- fix the hilarious fd leak of "geo-rep status"
- instead of "corrupt", which can trip up users to think their
  data is in danger, use the term "defunct" to describe the
  condition when gsyncd is dead/unresponsive
- don't use buffered I/O when unnecessary
- stop using PATH_MAX for sizing buffers that don't hold paths
- some cleanups wrt. memory management

Change-Id: I396aacc45dc06a002318b19c60c44041fa9fa18d
BUG: 764268
Signed-off-by: Csaba Henk 
Reviewed-on: http://review.gluster.com/3456
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd: command check failure fixes

2012-04-24T20:32:00+00:00

due to the patch 29f2de478cc6a475e6ae760d9cbe7ac847e9d79c (coverity
issues fix), geo-replications assumption of anything other than -2
is valid error (ie, expected error), was broken, which resulted in
staging failure of all geo-replication commands. now fixed!!!

Change-Id: I26c3574e966dd8ba89ef423a3ad17aa863a62c13
Signed-off-by: Amar Tumballi 
BUG: 815613
Reviewed-on: http://review.gluster.com/3219
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

geo-rep / glusterd: update list of reserved tunables

2012-04-24T03:02:07+00:00

(keeping up with http://review.gluster.com/399)

Change-Id: Iefc095a65efaa722a980315603f9ad027ee16eba
BUG: 764557
Signed-off-by: Csaba Henk 
Reviewed-on: http://review.gluster.com/3189
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

core: coverity issues fixed

2012-04-23T21:52:57+00:00

this is not a complete set of issues getting fixed. Will
address other issues in another patch.

Change-Id: Ib01c7b11b205078cc4d0b3f11610751e32d14b69
Signed-off-by: Amar Tumballi 
BUG: 789278
Reviewed-on: http://review.gluster.com/3145
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy

glusterd : Fixes for breakages caused by volume-id validation

2012-04-17T13:26:15+00:00

Fixes glusterd_op_build_payload() to,
1. take account of status cmd type when building payload for "volume status" to
   prevent "volume status all" from failing.
2. take account of volname being "help/help-xml" in volume set to prevent
   "volume set help/help-xml" from failing
3. obtain volname using key "master" prevent "volume geo-replication" commands
   from failing

Also, fails op and sets correct op_errstr if volume not found during
glusterd_dict_set_volid(), to make sure cli displays proper message.

Change-Id: I40ded15c50b54a82ee61bf6d6e9d07f571679c8c
BUG: 812801
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.com/3157
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi

fops/removexattr: prevent users from removing glusterfs xattrs

2012-03-05T17:17:47+00:00

* Each xlator prevents the user from removing xlator-specific
  xattrs like trusted.gfid by handling it in respective removexattr
  functions.

* For xlators which did not define remove and fremovexattr,
  the functions have been implemented with appropriate checks.

xlator         |     fops-added
_______________|__________________________
               |
1. stripe      |     removexattr and fremovexattr
2. quota       |     removexattr and fremovexattr

Change-Id: I98e22109717978134378bc75b2eca83fefb2abba
BUG: 783525
Signed-off-by: Rajesh Amaravathi 
Reviewed-on: http://review.gluster.com/2836
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Jeff Darcy

glusterd: auth allow enhancements

2012-02-20T08:30:54+00:00

* PROBLEM:

  When address-based authentication is enabled on a volume,
  the gNfs server, self-heal daemon (shd), and other operations
  such as quota, rebalance, replace-brick and geo-replication
  either stop working or the services are not started if all
  the peers' ipv{4,6} addresses or hostnames are not added in
  the "set auth.allow" operation, breaking the functionality
  of several operations.

  E.g:
    volume vol in a cluster of two peers:
    /mnt/brick1 in 192.168.1.4
    /mnt/brick2 in 192.168.1.5

    option auth.allow 192.168.1.6
    (allow connection requests only from 192.168.1.6)

    This will disrupt the nfs servers on 192.168.1.{4,5}.
    brick server processes reject connection requests from both
    nfs servers (on 4,5), because the peer addresses are not in
    the auth.allow list.

    Same holds true for local mounts (on peer machines),
    self-heal daemon, and other operations which perform
    a glusterfs mount on one of the peers.

* SOLUTION:

  Login-based authentication (username/password pairs,
  henceforth referred to as "keys") for gluster services and
  operations.

  These *per-volume* keys can be used to by-pass the addr-based
  authentication, provided none of the peers' addresses are put
  in the auth.reject list, to enable gluster services like gNfs,
  self-heal daemon and internal operations on volumes when
  auth.allow option is exercised.

* IMPLEMENTATION:

  1. Glusterd generates keys for each volume and stores it in
     memory as well as in respective volfiles.
     A new TRUSTED-FUSE volfile is generated which is
     fuse volfile + keys in protocol/client,
     and is named trusted--fuse.vol.
     This is used by all local mounts. ANY local mount (on any peer)
     is granted the trusted-fuse volfile instead of fuse volfile
     via getspec. non-local mounts are NOT granted the trusted fuse
     volfile.

  2. The keys generated for the volume is written to each server
     volfile telling servers to allow users with these keys.

  3. NFS, self-heal daemon and replace-brick volfiles are updated
     with the volume's authentication keys.

  4. The keys are NOT written to fuse volfiles for obvious reasons.

  5. The ownership of volfiles and logfiles is restricted to root users.

  6. Merging two identical definitions of peer_info_t in auth/addr
     and rpc-lib, throwing away the one in auth/addr.

  7. Code cleanup in numerous places as appropriate.

* IMPORTANT NOTES:

  1. One SHOULD NOT put any of the peer addresses in the auth.reject
     list if one wants any of the glusterd services and features
     such as gNfs, self-heal, rebalance, geo-rep and quota.

  2. If one wants to use username/password based authentication
     to volumes, one shall append to the server, nfs and shd volfiles,
     the keys one wants to use for authentication, *while_retaining
     those_generated_by_glusterd*.
     See doc/authentication.txt file for details.

Change-Id: Ie0331d625ad000d63090e2d622fe1728fbfcc453
BUG: 789942
Signed-off-by: Rajesh Amaravathi 
Reviewed-on: http://review.gluster.com/2733
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterfs: An effort to fix all the spell mistakes and typo

2011-11-17T05:08:56+00:00

in the entire glusterfs codebase.

This patch fixes many of spell mistakes and typo in the entire
glusterfs codebase and all supported modules.

Change-Id: I83238a41aa08118df3cf4d1d605505dd3cda35a1
BUG: 3809
Signed-off-by: Harshavardhana 
Reviewed-on: http://review.gluster.com/731
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Vijay Bellur