glusterfs.git/xlators/features, branch v3.8.0

features/worm: fixed issue with write FOP for normal files

2016-06-13T13:32:16+00:00

The write FOPs on normal files were being blocked after the recent change.
It should fail only for the WORM and WORM-Retained files, and should pass
for a normal file.
Using auto-commit period to check for dormant files instead of retention period.

Backport of http://review.gluster.org/#/c/14619/

> Change-Id: I30f82d4de2ea2c59c1eb7b4449ba6a60e568cfd5
> BUG: 1342259
> Signed-off-by: karthik-us 

Change-Id: I9c4ad589dd82cd33eecf207d9ed810a9d01f0f46
BUG: 1345713
Signed-off-by: karthik-us 
Reviewed-on: http://review.gluster.org/14705
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Niels de Vos

features/changelog: Change barrier notification mechanism

2016-06-13T11:22:51+00:00

Backport of http://review.gluster.org/#/c/14272/

The barrier notification mechanism was fd based and 'select'
was being used. 'select' breaks when number of fds opened
by brick process exceeds 1024. To avoid this and also
the maintainance of pipe between notify and 'changelog_rollover',
the pipe has been replaced with pthread condition signal
and timed wait mechanism.

> Change-Id: I530ea90d9a06953f8b23b4e12d122872ee1925de
> BUG: 1334314
> Signed-off-by: Kotresh HR 
> Reviewed-on: http://review.gluster.org/14272
(cherry picked from commit be00012e7be55d25870411f3e975db9a8e19c70a)

Change-Id: I530ea90d9a06953f8b23b4e12d122872ee1925de
BUG: 1342083
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/14614
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos 
Smoke: Gluster Build System

features/index: Exclude gfid-type for '.', '..'

2016-06-10T15:20:36+00:00

index_get_gfid_type is assuming all names are gfids where as some of these
entry->d_names can be '.' or '..'

Thanks a lot to Nithya for RC

 >BUG: 1336630
 >Change-Id: I06ad688a5865ab25b4f6c8a91af8c7fb2ed62186
 >Signed-off-by: Pranith Kumar K 
 >Reviewed-on: http://review.gluster.org/14589
 >Smoke: Gluster Build System 
 >NetBSD-regression: NetBSD Build System 
 >CentOS-regression: Gluster Build System 
 >Reviewed-by: Ravishankar N 
 >Reviewed-by: Krutika Dhananjay 
 >(cherry picked from commit a89a9d266c439800286f281655d67f4e362dec32)

Change-Id: Iad85874b4bc9ffbc4351c5a4f6c7a9c2e5bf4c9c
BUG: 1341477
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/14596
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Anuradha Talur 
Reviewed-by: Krutika Dhananjay 
Reviewed-by: Ravishankar N 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos

leases: Fix the recall code path

2016-06-10T15:19:37+00:00

1. Replace frame->op usage with frame->root->op, as frame->op
   is not filled with appropriate value in all cases
2. Add few log messages
3. Fix boolean assignment

Backport of http://review.gluster.org/#/c/14434/

Change-Id: I340f2200c1fcc4f4ce5a139b0fd22508cb8ac1e3
BUG: 1337638
Signed-off-by: Poornima G 
Reviewed-on: http://review.gluster.org/14568
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Rajesh Joseph 
Reviewed-by: Raghavendra Talur 
Reviewed-by: Niels de Vos

libglusterfs (timer): race conditions, illegal mem access, mem leak

2016-06-08T12:15:20+00:00

While investigating gfapi memory consumption with valgrind, valgrind
reported several memory access issues.

Also see the timer 'registry' being recreated (shortly) after being
freed during teardown due to the way it's currently written.

Passing ctx as data to gf_timer_proc() is prone to memory access
issues if ctx is freed before gf_timer_proc() terminates. (And in
fact this does happen, at least in valgrind.) gf_timer_proc() doesn't
need ctx for anything, it only needs ctx->timer, so just pass that.

Nothing ever calls gf_timer_registry_init(). Nothing outside of
timer.c that is. Making it and gf_timer_proc() static.

backport mainline:
> http://review.gluster.org/14247
> BUG: 1333925

Change-Id: Ia28454dda0cf0de2fec94d76441d98c3927a906a
BUG: 1342620
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/14644
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

posix/lock: implement meta-lock/unlock functionality

2016-06-06T06:33:53+00:00

problem : The lock state needs to be protected when rebalance is reading the
lock state on the source. Otherwise there will be locks left unmigrated.
Hence, to synchronize incoming lock requests with lock-migration, meta lock
is needed. Any new lock request will be queued if there is an active meta-lock
and with sucessful lock migration, will be unwound with EREMOTE, so that
dht module can wind the request to the correct destination.

On a successful lock migration, "pl_inode->migrated" flag is enabled. Hence,
any further request would be unwound with EREMOTE and will be redirected to
new destination.

More details can be found here:
https://github.com/gluster/glusterfs-specs/blob/master/accepted/Lock-Migration.md

design discussion:
https://www.gluster.org/pipermail/gluster-devel/2016-January/048088.html

Change-Id: Ief033d5652b5ca4ba6f499110a521cae283d6aba
BUG: 1338501
Signed-off-by: Susant Palai 
Reviewed-on: http://review.gluster.org/14462
Tested-by: Kotresh HR 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Raghavendra G 
CentOS-regression: Gluster Build System

features/worm: updating function names & unwinding FOPs with op_errno

2016-06-01T15:06:45+00:00

- Added gf_worm prefix to some of the functions in worm-helper files so that
  they do not clash with other functions
- Made the functions in worm.c static
- Unwinding the FOPs with op_errno instead of using different unwind statements
- Removed the multiple goto labels (wind & unwind)

Backport of http://review.gluster.org/#/c/14222/

> Change-Id: I3a2f114061aae4b422df54e91c4b3f702af5d0b0
> BUG: 1333263
> Signed-off-by: karthik-us 
> Reviewed-on: http://review.gluster.org/14222
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Joseph Fernandes
> Reviewed-by: Jeff Darcy 

Change-Id: Ic94aebf3f0cb202a258a53f5c678430a15aeb557
BUG: 1341556
Signed-off-by: karthik-us 
Reviewed-on: http://review.gluster.org/14600
Reviewed-by: Joseph Fernandes
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

core: Honour mandatory lock flags during lock migration

2016-05-27T14:50:37+00:00

lk_flags from posix_lock_t structure is the primary key used to
differentiate locks as either advisory and mandatory type. During
lock migration this field is not read in getactivelk() call path.
So in order to copy the exact lock state from source to destination
it is necessary to include lk_flags within lock_migration_info_t
structure to maintain accurate state. This change also includes
minor modifications to setactivelk() call to consider lk_flags
during lock migration.

> Reviewed-on: http://review.gluster.org/14189
> Smoke: Gluster Build System 
> Reviewed-by: Susant Palai 
> Reviewed-by: Poornima G 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Pranith Kumar Karampuri 

(cherry picked from commit deaf8439fc42435988aae6a7b9ab681cc0d36b09)

Change-Id: I20a7b6b6a0f3bdac5734cce8a2cd2349eceff195
BUG: 1337805
Signed-off-by: Anoop C S 
Reviewed-on: http://review.gluster.org/14457
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

features/shard: Get hard-link-count in {unlink,rename}_cbk before deleting shards

2016-05-24T08:57:46+00:00

        Backport of http://review.gluster.org/#/c/14334/

Change-Id: Iff0e90bee22e20c309eaea6c6a19e4fa6e101ed7
BUG: 1337839
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/14451
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos

features/worm: When disabled, worm xlator must directly pass fops to its child xlator

2016-05-24T08:34:45+00:00

Backport of http://review.gluster.org/#/c/14182/

> Change-Id: I56ea46c2743636ef7af5c85469cb2e186eadf21f
> BUG: 1332460
> Signed-off-by: Krutika Dhananjay 
> Reviewed-on: http://review.gluster.org/14182
> Smoke: Gluster Build System 
> Reviewed-by: Joseph Fernandes
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Niels de Vos 
> Signed-off-by: Joseph Fernandes 

Change-Id: Ic3995e8e81ae22a0c31167e356b203acfff4194d
BUG: 1334836
Signed-off-by: Joseph Fernandes 
Reviewed-on: http://review.gluster.org/14367
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Joseph Fernandes
Reviewed-by: Niels de Vos