glusterfs.git/xlators/features, branch v3.7.4

features/shard: Fix unlink failure due to non-existent shard(s)

2015-08-31T15:09:47+00:00

        Backport of: http://review.gluster.org/#/c/12059/

Unlink of a sharded file with holes was leading to EINVAL errors
because it was being wound on non-existent shards (those blocks that
fall in the hole region). loc->inode was NULL in these cases and
dht_unlink used to fail the FOP with EINVAL for failure to fetch
cached subvol for the inode.

The fix involves winding unlink on only those shards whose corresponding
inodes exist in memory.

Change-Id: I1e5d492a2e60491601da23f64a5d0089e536b305
BUG: 1258353
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/12061
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System

marker: preserve previous dirty flag during update txn

2015-08-31T11:14:44+00:00

This is a backport of http://review.gluster.org/#/c/12032/

In case if dir has become dirty because of crash,
this dirty flag on disk was getting reset in the
next update txn.

This patch now gets the dirty flag before setting
in the update txn and it the value is dirty, it keeps
the flag dirty, so that inspect_directory can fix the
dirty dir

> Change-Id: Iab2c343dbe19bd3b291adbfeebe6d9785b6bb9e3
> BUG: 1251454
> Signed-off-by: vmallika 

Change-Id: I10b81e5c0d9ffa00082171e295199d924a81ee0e
BUG: 1257441
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/12037
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Kaushal M

features/shard: Fix permission issues

2015-08-31T09:31:10+00:00

        Backport of: http://review.gluster.org/11992

This patch does the following:
* reverts commit b467af0e99b39ef708420d3f7f6696b0ca618512
* changes ownership on shards under /.shard to be root:root
* makes readv, writev, [f]truncate, rename, and unlink fops
  to perform operations on files under /.shard with
  frame->root->{uid,gid} as 0.

This would ensure that a [f]setattr on a sharded file
does not need to be called on all the shards associated with it.

Change-Id: I50d8533bd2b769a4dfe8cd1b49bdcfc117a7e660
BUG: 1253151
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/12052
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System

features/shard: Fix size update for writes at hole region

2015-08-30T06:51:50+00:00

        Backport of: http://review.gluster.org/#/c/12020

Change-Id: I4b6e9101ccb881d3d285704902484e1e89ccaceb
BUG: 1257204
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/12026
Tested-by: NetBSD Build System 
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System

marker: fix log when loc.parent and inode gfid is NULL

2015-08-28T04:24:57+00:00

This is the backport of http://review.gluster.org/#/c/11863

This patch does the following

1) Set loc.parent if it is NULL
   Don't log warning in txn if parent is NULL
2) Don't initiate txn when inode gfid is NULL
3) optimize invoking dirty txn with status flag

> Change-Id: I67dd9e6268014b0b257c136e951e6ded0a2e911f
> BUG: 1251454
> Signed-off-by: vmallika 

Change-Id: I6134aa37fc36141767afcc00d604806f349c74d1
BUG: 1257441
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/12023
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G

features/bitrot: Fix scrubber frequency set

2015-08-27T09:18:32+00:00

When bitrot is configured on multiple volumes
in a cluster and scrubber-frequency is changed
for one volume, it is resetting frequency for
all other volumes w.r.t to its scrubber-frequency.
This should not happen. Changing scrubber-frequency
should affect only that volume on which it is set.
This patch fixes the issue.

Also restricted the logs to the configure volume.

BUG: 1256669
Change-Id: I6eba385b50b3bdc86bc8f4ef295a004b3b87b68a
Reviewed-on: http://review.gluster.org/11897
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Venky Shankar 
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/12010

snapshot: Make fops static for correct resolution of symbols

2015-08-25T18:36:20+00:00

Few of the snapshot fops (like 'svc_lookup') may not get resolved
while using dynamic loading as there could be other libraries(like libntirpc)
with same routine names. Making them static to resolve the same.

This is backport of the below fix -
http://review.gluster.org/#/c/11805/

Change-Id: I6577bf3705864f5583425c94427b4e1025a59bcd
BUG: 1256485
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/11805
Reviewed-by: Niels de Vos 
Reviewed-by: Rajesh Joseph 
Reviewed-on: http://review.gluster.org/12008
Reviewed-by: Kaleb KEITHLEY 
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System

libgfapi: adding 'follow' flag to glfs_h_lookupat()

2015-08-25T12:31:35+00:00

This patch is backport of http://review.gluster.org/#/c/11883/

Previously glfs_h_lookupat won't follow the symlink, this patch
introduces new flag `follow` which will resolve the same. Applications
linking against the new library will need to use the new glfs_h_lookupat
API call.

In order to stay compatible with existing binaries that use the previous
glfs_h_lookupat() function, the old symbol needs to stay available.

Verification that there are two versions of glfs_h_lookupat:

  $ objdump -T /usr/lib64/libgfapi.so.0 | grep -w glfs_h_lookupat
  0000000000015070 g    DF .text  000000000000021e  GFAPI_3.7.4 glfs_h_lookupat
  0000000000015290 g    DF .text  0000000000000008 (GFAPI_3.4.2) glfs_h_lookupat

Testing with a binary (based on anonymous_fd_read_write.c from ./tests/)
that was linked against the old library:

  $ objdump -T ./lookupat | grep -w glfs_h_lookupat
  0000000000000000      DF *UND*  0000000000000000  GFAPI_3.4.2 glfs_h_lookupat

Enable debugging for 'ld.so' so that we can check that the GFAPI_3.4.2
version of the symbol gets loaded:

  $ export LD_DEBUG_OUTPUT=lookupat.ld.log LD_DEBUG=all
  $ ./lookupat
  $ grep -w glfs_h_lookupat lookupat.ld.log.2543
  2543:     symbol=glfs_h_lookupat;  lookup in file=./lookupat [0]
  2543:     symbol=glfs_h_lookupat;  lookup in file=/lib64/libgfapi.so.0 [0]
  2543:     binding file ./lookupat [0] to /lib64/libgfapi.so.0 [0]: normal symbol `glfs_h_lookupat' [GFAPI_3.4.2]

This change has been successfully cherry-picked as 1ead86a8bcbfe4045729466e4b98f765f3c13c8d
in master

Upstream reference
>Change-Id: I8bf9b1c19a0585f681bc1a7f84aad1ccd0f75f6a
>BUG: 1252410
>Signed-off-by: Jiffin Tony Thottan 
>Signed-off-by: Niels de Vos 
>Reviewed-on: http://review.gluster.org/11883
>Reviewed-by: soumya k 
>Reviewed-by: Kaleb KEITHLEY 
>Tested-by: NetBSD Build System 
Signed-off-by: Jiffin Tony Thottan 

Change-Id: Idbbf0cd6802f86c53b16377d90d08ff6d99e7b08
BUG: 1256616
Reviewed-on: http://review.gluster.org/12009
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

features/bitrot: Fix rescheduling scrub-frequency

2015-08-24T04:36:43+00:00

While rescheduling scrub frequency, boot time of
the brick was considered where it is not required
and also delta is calculated using unsigned int
resulting in the loss of fractional part leading to
wrong scrub frequency. Boot time is completely
removed and delta calculation is simplified.

BUG: 1253160
Change-Id: I98dd1fa99304c6d91c0a330dfca7fef57a770397
Reviewed-on: http://review.gluster.org/11853
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Venky Shankar 
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/11904

bitrot: Scrubber log should mark bad file as a ALERT in the scrubber log

2015-08-21T09:39:22+00:00

If bad file detected by scrubber then scrubber should log that bad
file as a ALERT message in scrubber log.

Change-Id: I410429e78fd3768655230ac028fa66f7fc24b938
BUG: 1255605
Signed-off-by: Gaurav Kumar Garg 
Reviewed-on: http://review.gluster.org/11965
Reviewed-by: Raghavendra Bhat 
Tested-by: NetBSD Build System 
(cherry picked from commit 6cb73b4fe798b7bf3aface0aac2a4e6c7c618c0e)
Reviewed-on: http://review.gluster.org/11974
Tested-by: Gluster Build System