glusterfs.git/xlators/features, branch v3.7.1

features/changelog: Remove inline keyword to avoid warnings (gcc v5.1.1)

2015-06-01T13:56:04+00:00

        Backport of http://review.gluster.org/11004

When compiled with gcc5, following warnings were displayed
and volume start failed:

changelog-helpers.h:499:1: warning: inline function 'changelog_dispatch_event'
declared but never defined
 changelog_dispatch_event (xlator_t *, changelog_priv_t *, changelog_event_t *);

gf-changelog-journal-handler.c:692:17: warning: 'list_add_tail' is static but
used in inline function 'gf_changelog_queue_journal' which is not static
                 list_add_tail (&entry->list, &jnl_proc->entries);

Fix is to remove the keyword from function prototype and
definitions.

Change-Id: I188b35b7ca087a94d7a48a052b05a6d845e3b74b
BUG: 1226853
Signed-off-by: Anoop C S 
Reviewed-on: http://review.gluster.org/11030
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Venky Shankar

featuress/changelog: On snapshot, notify irrespective of failures

2015-06-01T02:39:24+00:00

During snapshot, changelog barrier is enabled and a
explicit rollover of changelog is initiated. During
rollover of changelog, if any error or changelog is
empty, the notification was not sent to reconfigure
and hence snapshot was failing because of timeout.
This patch addresses it by sending notification
irrespective of failures and sends error if any
back to barrier.

BUG: 1225543
Change-Id: I971ef3bdc63bb50bda0b655e55cd814e44254ba9
Reviewed-On: http://review.gluster.org/10951
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/10988
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Venky Shankar

features/bit-rot-stub: implement mknod fop

2015-06-01T02:33:21+00:00

    Backport of http://review.gluster.org/10790

With the absence of mknod() fop implementation in bitrot stub,
further operations that trigger versioning resulted in crashes
as they expect the inode context to be valid. Therefore, this
patch implements mknod() following similar simantics to fops
such as create().

Furthermore, bitrot stub test C program is fixed to stop lying
and validate obj versions according to the versioning protocol.

Change-Id: If76f252577445d1851d6c13c7e969e864e2183ef
BUG: 1226139
Original-Author: Raghavendra Bhat 
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/10987
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System

features/bitrot: serialize versioning

2015-05-31T12:16:10+00:00

    Backport of http://review.gluster.org/10832

Current signing interface (fsetxattr()) had couple of issues:

One, a signing request (by bitrot daemon) is denied if the version
against which an object is to be signed is unequal to the current
version of the object (cases where another subsequent modification
increments the version). Such request(s) are rejected with EINVAL
sent back to the signer resulting in a bunch of errors (in logs)
reported by bitrot daemon. Although, the object would be eventaully
signed with the version matching the current version, the "lagging"
request should be correctly handled.

Two, more than one signing request could race against each other
with the object getting signed with a version depending on which
request ended up last in the race. Although harmless to some extent,
such a case could end up marking the object's signature as stale
for infinity (if the object is *never* touched) thereby resulting
in scrubber skipping the object during verification.

This patch fixes these issues by ordering signing request(s) and
fixing version comparison checks at the time of signing.

Change-Id: I9fa83dfa3be664ba4db61d7f2edc408f4bde77dd
BUG: 1224650
Signed-off-by: Venky Shankar 
Tested-by: Gluster Build System 
Reviewed-on: http://review.gluster.org/10900
Tested-by: NetBSD Build System

features/bitrot: refactor brick connection logic

2015-05-31T04:15:04+00:00

    Backport of http://review.gluster.org/10763

Brick connection was bloated (and not implemented efficiently) with
calls which were not required to be called under lock. This resulted
in starvation of lock by critical code paths. This eventally did not
scale when the number of bricks per volume increases (add-brick and
the likes).

Also, this patch cleans up some of the weird reconnection logic that
added more to the starvation of resources and cleans up uncontrolled
growing of log files.

Change-Id: I05e737f2a9742944a4a543327d167de2489236a4
BUG: 1226146
Original-Author: Raghavendra Bhat 
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/10986
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System

features/bitrot: reimplement scrubbing frequency

2015-05-31T04:14:10+00:00

This patch reimplments existing scrub-frequency mechanism used
to schedule scrubber runs. Existing mechanism uses periodic
sleeps (waking up periodically on minimum granularity) and
performing a number of tracking checks based on counters and
sleep times. This patch does away with all the nifty counters
and uses timer-wheel to schedule scrub runs.

Scheduling changes are peformed by merely calculating the new
expiry time and calling mod_timer() [mod_timer_pending() in
some cases] making the code more debuggable and easier to
follow. This also introduces "hourly" scrubbing tunable as an
aid for testing scrubbing during development/testing cycle.

One could also implement on-demand scrubbing with ease: by
invoking mod_timer() with an expiry of one (1) second, thereby
scheduling a scrub run the very next second.

Change-Id: I6c7c5f0c6c9f886bf574d88c04cde14b76e60a8b
BUG: 1224647
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/10902
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System

features/bitrot: stub improvements and fixes

2015-05-31T04:12:48+00:00

This patch refactors the signing trigger mechanism used by bitrot
daemon as a "catch up" meachanism to sign files which _missed_
signing on the last run either due to bitrot being disabled and
enabled again or if bitrot is enabled for a volume with existing
data.

Existing implementation relies on overloading writev() to trigger
signing which just by the looks sounded dangerous and I hated it
to the core. This change moves all that business to the setxattr
interface thereby keeping the writev path strictly for client
IO.

Why not use IPC fop to trigger signing?
There's a need to access the object's inode to perform various
maintainance operations. inode is not _directly_ accessible in
the IPC fop (although, it can be found via inode_grep() for the
object's GFID - the inode just needs to be pinned in memory,
which is the case if there's an active fd on the inode). This
patch relies on good old technique of overloading fsetxattr()
to do the job instead of using IPC fop.

There are some pretty nice cleanups along the lines of memory
deallocations, unncessary allocations and redundant ref()ing
of structures (such as fd's) provided by this patch. All in
all - much improved code navigation.

Change-Id: Id93fe90b1618802d1a95a5072517dac342b96cb8
BUG: 1225709
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/10953
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System

quota: fix for spurious failure

2015-05-29T06:24:36+00:00

This is a backport of http://review.gluster.org/#/c/10918/

> During ancestry build, loc path was set to invalid
> path. path was set to one of its child instead
> of itself. Because of this quota accounting was
> going wrong
>
> This patch fix the issue
>
> Below mentioned tests removed from bad test list
> as part of patch# 10930
>         ./tests/basic/ec/quota.t
>         ./tests/basic/quota-nfs.t
>         ./tests/bugs/quota/bug-1035576.t
>
> Change-Id: Iaa65b2d968c04c9abcd476d0e9f588cb7fd39294
> BUG: 1223798
> Signed-off-by: vmallika 
> Reviewed-on: http://review.gluster.org/10918
> Tested-by: NetBSD Build System
> Reviewed-by: Vijay Bellur 

Change-Id: I2986d18c111790bef8f2a7a1df5e43f46755e85e
BUG: 1224894
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/10958
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System
Reviewed-by: Pranith Kumar Karampuri

features/shard: Skip block count and size update for directories

2015-05-29T02:24:21+00:00

        Backport of: http://review.gluster.org/10772

Change-Id: I3594641ef0bf6a17e1ceab3c9ad87ef18b981d2e
BUG: 1225922
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/10972
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System

features/locks: Handle virtual getxattrs in more fops

2015-05-28T11:12:28+00:00

        Backport of http://review.gluster.com/10880

With this patch getxattr of inodelk/entrylk counts can be requested in
readv/writev/create/unlink/opendir.

BUG: 1225279
Change-Id: Ifb9378ce650377e67a8601147eac95cfbdf0abf0
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/10925
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System