glusterfs.git/xlators/features, branch v3.6.2beta1

USS : Decide the log entry based on the type of graph.

2014-12-16T13:37:59+00:00

Problem : When a lookup is issued, and if the entry is not found
then snapview-client will log failure stating that
"Lookup on normal graph failed with error Stale file handle"
irrespective of type of graph it received call back from.

Solution : Introduced a check to find out the graph from which
the snapview-client received call-back.

> Change-Id: Iadd5b525c394be3675d40231711058e1cf1396cd
> BUG: 1146479
> Signed-off-by: Sachin Pandit 
> Reviewed-on: http://review.gluster.org/8851
> Reviewed-by: Raghavendra Bhat 
> Tested-by: Gluster Build System 
> Reviewed-by: Vijay Bellur 
> Signed-off-by: Raghavendra Bhat 

Change-Id: I6971d3e2a44db14431205b4c14cffd86a79de51f
BUG: 1174639
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/9281
Tested-by: Gluster Build System 
Reviewed-by: Sachin Pandit

build: FreeBSD 11-Current causes libtool to fail with '-shared'

2014-12-13T06:04:48+00:00

Thanks for Markiyan Kushnir  for
reporting this

Change-Id: Ia0272e51be4ddede1e6bc188dfb892979626a7cd
BUG: 1171524
Signed-off-by: Harshavardhana 
Reviewed-on: http://review.gluster.org/9252
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos 
Reviewed-by: Raghavendra Bhat 
Tested-by: Raghavendra Bhat

features/marker: Filter internal xattrs in lookup

2014-11-17T07:35:25+00:00

        Backport of http://review.gluster.org/9061

Afr should ignore quota-size-key as part of self-heal
but should heal quota-limit key.

BUG: 1163569
Change-Id: I93d203002eac4fe20b70730c27c852d783c16d7f
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/9110
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glupy: portability fixes

2014-11-17T07:06:25+00:00

Fixes portability problems so that NetBSD passes tests/features/glupy.t

- Use python-config to detect python build environment on all systems,
  not just Linux and Darwin.
- Get the site-package directory from python and make sure we install
  glupy.py there, Previously we installed within glusterfs prefix,
  which caused a problem if it was different that python's prefix.
- Set PYTHONPATH for tests so that the detected site-packages is used
  in python's search path. This should be useless, but let us have it
  just in case.
- Pass glupy.so path from glusterfsd to glupy.py through an
  environment variable and use it in CDLL instead of "", as the
  later seems not portable (at least it fails on NetBSD).
- Use gil_init_key pthread_getspecific to avoid deadlocks (that
  code was #ifdef out, perhaps because it was not needed on Linux,
  but it seems to be required for NetBSD.
- Recover the error message from Python and send it to the logs
  to help debugging problems.

Backport of: http://review.gluster.org/8978

This is the same patchset as previously submitted to retrigger regression
tests after a spurious failure.

BUG: 1138897
Change-Id: I1e23ba5cc18f129ee1032f905cb053953b683a81
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/8980
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

feature/gfid-access: Always send setattr down in overloaded setxattr.

2014-11-14T09:53:14+00:00

Problem: File ownership is not being preserved for root in geo-rep
         mountbroker setup.

Analysis and Cause:
         Entry creations for geo-rep is overloaded in ga_setxattr.
         It happens in two phase, entry creation followed by setattr
         to preserve ownership as in master.

         If uid and gid of file being synced is root, setattr was
         not being sent down. Since, the file creation happens with
         non-root user in mountborker geo-rep setup, if setattr is
         not done explicitly, file ownership is not preserved for root.

Solution:
         Always pass setattr down in overloaded ga_setxattr.

BUG: 1159213
Change-Id: I0a6ef16333190b069e2ae326721d2b983f6a1a44
Reviewed-on: http://review.gluster.org/9051
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/9083
Tested-by: Gluster Build System 
Reviewed-by: Venky Shankar 
Tested-by: Venky Shankar

feature/changelog: Fix changelog missing SETATTR entries.

2014-11-14T05:54:01+00:00

Problem: Valid SETATTR entries are missing in changelog when more
         than one metadata operation happen on same inode within
         changelog roll-over time.

Cause: Metadata entries with fop num being GF_FOP_NULL are logged
       in changelog which is of no use. Since slice version
       checking is done for metadata entries to avoid logging of
       subsequent entries of same inode falling into same
       changelog, if the entry with GF_FOP_NULL is logged first,
       subsequent valid ones will be missed.

Solution: Have a boundary condition to log only those fops whose fop
          number falls between GF_FOP_NULL and GF_FOP_MAXVALUE.

BUG: 1159213
Change-Id: I128cad323afba7d33f48df1ee5e78cb829536211
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/8964
Reviewed-by: Aravinda VK 
Tested-by: Gluster Build System 
Reviewed-by: Venky Shankar 
Tested-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/9028

features/snapview-server: verify the fs instance in revalidated lookups as well

2014-10-30T18:39:59+00:00

Change-Id: I691635e60aba72642c3c79d7da472884f1228301
BUG: 1158791
Reviewed-on: http://review.gluster.org/9008
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

features/snapview-server: check if the reference to the snapshot world is correct before doing any fop

2014-10-30T18:39:15+00:00

The following operations might lead to problems:
* Create a file on the glusterfs mount point
* Create a snapshot (say "snap1")
* Access the contents of the snapshot
* Delete the file from the mount point
* Delete the snapshot "snap1"
* Create a new snapshot "snap1"

Now accessing the new snapshot "snap1" gives problems. Because the inode and
dentry created for snap1 would not be deleted upon the deletion of the snapshot
(as deletion of snapshot is a gluster cli operation, not a fop). So next time
upon creation of a new snap with same name, the previous inode and dentry itself
will be used. But the inode context contains old information about the glfs_t
instance and the handle in the gfapi world. Directly accessing them without
proper check leads to ENOTCONN errors. Thus the glfs_t instance should be
checked before accessing. If its wrong, then right instance should be obtained
by doing the lookup.

Change-Id: I975245b8f6b7fea0a90eb5e36e8149d12457ac10
BUG: 1158791
Reviewed-on: http://review.gluster.org/9007
Reviewed-by: Vijay Bellur 
Tested-by: Vijay Bellur

Fix invalid seekdir() usage

2014-09-30T16:50:26+00:00

According to POSIX, seekdir() should only be given offset obtained from
telldir() on the same DIR *
http://pubs.opengroup.org/onlinepubs/9699919799/functions/seekdir.html

Code from afr-self-heald.c and index.c is operating outside of the
specification, by doing using seekdir() with offset from a previously
open/close/re-open directory. This seems to work on Linux (although with
no guarantee it will always in the future). On NetBSD the seekdir()
with a in invalid offset is a nilpotent operation, and causes an infinite
loop, since index_fill_readdir() always restart from the beginning of the
directory.

The situation is fixed by using a non anonymous fd in afr-self-heald.c:
we explicitely open the directory so that it remains open on the brick
side during the timeframe where we want to reuse offsets in seekdir().
This requires adding an opendir fop in index xlator.

If the brick was not updated, the opendir will fail and we fallback
to the standard violating approach for backward compatibility on Linux.
On other systems we fail since it never worked.

While there, add tests to check seekdir() success in index and posix
xlators, so that incorrect usage from calling code produce an explicit
error instead of an infinite loop. We can only do it on non Linux systems,
for the sake of backward compatibility when the brick was updated but
not the client.

Backport of I88ca90acfcfee280988124bd6addc1a1893ca7ab

BUG: 1138897
Change-Id: I5446a9a17d5451ec5aab8fbd10d381da9a0a23ad
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/8860
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Vijay Bellur

features/marker: Fill loc->path before sending the control to healing

2014-09-23T16:48:21+00:00

        Backport of: http://review.gluster.org/8296

Problem:
The xattr healing part of the marker requires path to be present in the loc.
Currently path is not filled while triggering from the readdirp_cbk.

Solution:
Current patch tries to fill the loc with path.

Change-Id: I2e2589ecfa6b6a6e27407c9541fa90a314649bec
BUG: 1145623
Signed-off-by: Varun Shastry 
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/8820
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur