glusterfs.git/xlators/features, branch v3.5.2

rpcsvc: Validate RPC procedure number before fetch

2014-07-08T10:36:18+00:00

While accessing the procedures of given RPC program in,
rpcsvc_get_program_vector_sizer(), It was not checking boundary
conditions which would cause buffer overflow and subsequently SEGV.

Make sure rpcsvc_actor_t arrays have numactors number of actors.

FIX:
Validate the RPC procedure number before fetching the actor.

Upstream main review: http://review.gluster.org/7726

BUG: 1096020

Change-Id: Iaf207ee976cb56fa9a554ec82c9eab36d3b289ed
Signed-off-by: Santosh Kumar Pradhan 
Reviewed-on: http://review.gluster.org/8228
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

features/gfid-access: Fix entry operations

2014-07-08T08:13:15+00:00

        Backport of http://review.gluster.org/8204

Problem:
When more than one aux-mounts are performing rmdir .gfid//dir
simultaneously, then sometimes a hang is observed.  In gfid-access xlator When
virtual parent/inode are replaced with real parent/inode in loc, virtual
pargfid/gfid are not replaced with real pargfid/gfid respectively. Afr is using
parent_loc->gfids to order the entry locks. But parent_loc->gfid contains
random/virtual gfid generated by gfid-access xlator. Entrylk in client xlator
is using loc->inod->gfid for sending entrylk which has 'real' gfid. Because the
ordering is happening based on random gfids, One mount orders the locks as (L1,
L2) where as the other orders them as (L2, L1) leading to a dead-lock thus
a hang.

Fix:
Replace virtual pargfid/gfid with real pargfid/gfid when virtual-inodes are
replaced with real-inodes in loc.

BUG: 1114501
Change-Id: I13016de1da11762e0697792d76e6e946d991c0a4
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/8251
Reviewed-by: Kotresh HR 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

features/gfid-access: Fix inode leaks and loc path corruption

2014-07-08T08:11:50+00:00

        Backport of http://review.gluster.org/8009
        Backport of http://review.gluster.org/8163

BUG: 1112659
Change-Id: Ic70a3ddfcfef88909c12ca6791a8e20c3fee2eae
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/8250
Reviewed-by: Kotresh HR 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

quotad: Remove dead code

2014-07-08T08:06:11+00:00

        Backport of http://review.gluster.org/8180

client_t is created by server xlator for managing connection related
resources. Quotad doesn't do that. So no need to handle anything related
to it.

BUG: 1113403
Change-Id: I4f457b60c0b3377f8980857a883da1cf3e44d16e
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/8227
Reviewed-by: Krutika Dhananjay 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

feautre/gfid-access: Fix EINVAL when stat on .gfid

2014-07-07T07:22:28+00:00

Problem: Some of the inode operations on '.gfid'
virtual directory was resulting in the error
EINVAL from dht after failing to find the layout.

Solution: Inode operations on '.gfid' virtual directory
should not wind further down and should be handled
accordingly in the gfid-access translator itself.

Change-Id: I156cb10ffea0c46b0d747e26f74538d7fb01a1dd
BUG: 1105891
Signed-off-by: Kotresh H R 
Reviewed-on: http://review.gluster.org/8011
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Reviewed-by: Venky Shankar 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/8234
Reviewed-by: Niels de Vos

features/index : Creation of indices directory as soon as brick is up.

2014-06-27T08:48:49+00:00

Missing indices directory in the bricks leads to unwanted log messages.
Therefore, indices directory needs to be created as soon as the brick
comes up.
This patch results in creation of indices/xattrop directory as required.
Also includes a testcase to test the same.

Backport of http://review.gluster.org/#/c/6343/
and http://review.gluster.org/#/c/6426/

Change-Id: I2a6f48b78aa09357ed60e45b62ec5fb08f816d76
BUG: 1112111
Signed-off-by: Anuradha 
Reviewed-on: http://review.gluster.org/8152
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

features/index: Don't delete current xattrop index.

2014-06-24T09:27:55+00:00

Problem:
`gluster v heal  statistics heal-count` was not able to read the
number of entries to be healed from the source brick because the base xattrop
entries in indices/base_indices_holder and indices/xattrop were getting deleted
after a successful heal and the code flow prevented them from creating it again.

Fix:
Don't delete the xattrop index unless it is stale (i.e. brick is restarted)

Change-Id: Ief4eee0ddf42c4d8b711d00751be92bbbc7bbbb0
BUG: 1101647
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/7897
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Niels de Vos

features/quota: Fix dict leak

2014-06-23T09:53:55+00:00

Change-Id: Id4542d1629175cce5fec5ab8f9a5899eec48e2eb
BUG: 1110777
Signed-off-by: Varun Shastry 
Reviewed-on: http://review.gluster.org/8132
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

features/locks: Clean up logging of cleanup in DISCONNECT codepath

2014-06-23T09:38:31+00:00

        Backport of http://review.gluster.org/7981

Now, gfid is printed as opposed to path in cleanup messages.

Also, refkeeper update is eliminated in inodelk and entrylk.
Instead, the patch ensures inode and pl_inode are kept alive as
long as there is atleast one lock (granted/blocked) on an inode.

Also, every inode is unref'd appropriately on a DISCONNECT from the
lock-owning client.

Change-Id: I234db688ad0d314f4936a16cc5af70a3bd071970
BUG: 1104915
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/8042
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Niels de Vos

features/gfid-access: Fix memory leaks.

2014-06-10T09:37:49+00:00

Change-Id: I90f6cdb1c8c4face1bb72a9cc77818d308389e45
BUG: 1104919
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/7983
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos