glusterfs.git/xlators/features, branch v3.12.3

features/worm: Adding check to newloc when doing rename

2017-10-25T14:07:19+00:00

Problem: Since rename didn't check if newloc exists and it's
retention state it was possible to rename a new file that wasn't
in retention over a existing file that was in read-only state.

Cherry picked from commit 00a4dc0:
> Change-Id: I63c6bbabb7bb456ebedf201cc77b878ffda62229
> BUG: 1484490
> Signed-off-by: luneo7 
> Reviewed-on: https://review.gluster.org/18104
> Tested-by: jiffin tony Thottan 
> Tested-by: Prashanth Pai 
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Prashanth Pai 
> Reviewed-by: Karthik U S 
> Reviewed-by: Amar Tumballi 

Change-Id: I63c6bbabb7bb456ebedf201cc77b878ffda62229
BUG: 1484489
Signed-off-by: luneo7

libgfchangelog: Fix possible null pointer dereference

2017-10-25T11:38:12+00:00

If pthread_attr_init fails, gf_msg uses this->name
where 'this' is not initialized yet. This patch fixes
the same.

> Change-Id: Ie004cbe1015a0d62fc3b5512e8954c5606eeeb5f
> Signed-off-by: Kotresh HR 
> BUG: 1505325
(cherry picked from commit 738c38f0efa7b4d4dab0cf23d00589d68e4eb88d)


Change-Id: Ie004cbe1015a0d62fc3b5512e8954c5606eeeb5f
Signed-off-by: Kotresh HR 
BUG: 1505856

features/locks: Maintain separation of lock->client_pid, flock->l_pid

2017-10-06T06:30:35+00:00

Problem:
grant_blocked_locks() constructs flock from lock. Locks xlator uses
frame->root->pid interchangeably flock->l_pid. With gNFS frame->root->pid
(which translates to lock->client_pid) is not same as flock->l_pid, this leads
to lk's cbk returning flock with l_pid from lock->client_pid instead of input
flock->l_pid. This triggers EC's error code path leading to failure of lk call,
because the response' flock->l_pid is different from request's flock->l_pid.

Fix:
Maintain separation of lock->client_pid, flock->l_pid. Always unwind with
flock with correct pid.

 >BUG: 1472961
 >Change-Id: Ifab35c458662cf0082b902f37782f8c5321d823d
 >Signed-off-by: Pranith Kumar K 
 >(cherry picked from commit 572b4bf889d903dcaed49a57a75270a763dc259d)

BUG: 1496326
Change-Id: Ifab35c458662cf0082b902f37782f8c5321d823d
Signed-off-by: Pranith Kumar K

features/shard: Change default shard-block-size to 64MB

2017-09-28T20:53:46+00:00

        Backport of:
        > Change-Id: I55fa87e07136cff10b0d725ee24dd3151016e64e
        > BUG: 1489823
        > Reviewed-on: https://review.gluster.org/18243
        > cherry picked from commit e4a59b384f5bbaaeb937a53cef64f4e388f85153

Change-Id: I55fa87e07136cff10b0d725ee24dd3151016e64e
BUG: 1492026
Signed-off-by: Krutika Dhananjay

arbiter: return ENOSYS for 'non readable' FOPs

2017-09-10T18:34:38+00:00

AFR marks the arbiter as 'non readable'. This has been introduced with
commit 8ab87137 (afr: do not set arbiter as a readable subvol in inode
context). arbiter_readv() should not get called anymore, so it could be
removed. However, it is a good defensive approach to have all the inode
read FOPs that can not be handled by the arbiter to return ENOSYS.

> Reviewed-on: https://review.gluster.org/18103
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
(cherry picked from commit b1352d0974328b367afa7360e9523585efb7178d)

Change-Id: I6ea41680832859bd6790dc8d7440ee98d38205fc
BUG: 1489511
Signed-off-by: Niels de Vos 
Signed-off-by: Ravishankar N 
Reviewed-on: https://review.gluster.org/18227
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

features/shard: Return aggregated size in stbuf of LINK fop

2017-09-07T06:43:43+00:00

    Backport of:
    > Change-Id: I42df7679d63fec9b4c03b8dbc66c5625f097fac0
    > Reviewed-on: https://review.gluster.org/18209
    > BUG: 1488546
    > cherry-picked from 91430817ce5bcbeabf057e9c978485728a85fb2b

Change-Id: I42df7679d63fec9b4c03b8dbc66c5625f097fac0
BUG: 1488718
Signed-off-by: Krutika Dhananjay 
Reviewed-on: https://review.gluster.org/18211
Smoke: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
CentOS-regression: Gluster Build System

features/shard: Increment counts in locks

2017-09-06T07:48:11+00:00

       Backport of https://review.gluster.org/18203

Problem:
Because create_count/eexist_count are incremented without locks, all the shards may not
be created because call_count will be lesser than what it needs to be. This can lead
to crash in shard_common_inode_write_do() because inode on which we want to do
fd_anonymous() is NULL

Fix:
Increment the counts in frame->lock

 >Change-Id: Ibc87dcb1021e9f4ac2929f662da07aa7662ab0d6
 >BUG: 1488354
 >Signed-off-by: Pranith Kumar K 

Change-Id: Ibc87dcb1021e9f4ac2929f662da07aa7662ab0d6
BUG: 1488387
Signed-off-by: Pranith Kumar K 
Reviewed-on: https://review.gluster.org/18204
Smoke: Gluster Build System 
Reviewed-by: Krutika Dhananjay 
CentOS-regression: Gluster Build System

uss/svc: Send the first lookup to the normal graph

2017-08-21T14:29:24+00:00

When parent inode is not looked up before, the inode type
won't be set. In this scenario we should send the lookup
to the normal graph first.

Backport of>
>Change-Id: I5d3e53f5c1c33a17be32204f3114749d9b1e6db8
>BUG: 1480591
>Signed-off-by: Mohammed Rafi KC 
>Reviewed-on: https://review.gluster.org/18028
>Smoke: Gluster Build System 
>Reviewed-by: Raghavendra Bhat 
>CentOS-regression: Gluster Build System 
>Reviewed-by: soumya k 

(cherry picked from commit d396d358d4f0cfe87693179cfd13eb2a84ce62c2)

Change-Id: I5d3e53f5c1c33a17be32204f3114749d9b1e6db8
BUG: 1481931
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: https://review.gluster.org/18042
Smoke: Gluster Build System 
Reviewed-by: Amar Tumballi 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

gfapi: Duplicate the buffer sent in setxattr calls

2017-08-12T13:33:55+00:00

Issue:
The caller of glfs_setxattr sends a buffer to set as the value.
We create a dict in which the pointer to the value is set.
Underlying layers like md-cache take a ref on this dict to store
the value for a longer time. But the moment setxattr is complete,
the caller of glfs_setxattr can free the value memory.

Solution:
memcpy the setxattr value to the gluster buffer.

> Reviewed-on: https://review.gluster.org/17967
> Reviewed-by: soumya k 
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Jeff Darcy 
> (cherry picked from commit e11296f8e52b7e3b13d21b41d4fa34baea878edf)

Change-Id: I58753fe702e8b7d0f6c4f058714c65d0ad5d7a0a
BUG: 1479655
Signed-off-by: Poornima G 
Reviewed-on: https://review.gluster.org/18001
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

posix: add null gfid checks

2017-08-12T13:29:47+00:00

(Backport of https://review.gluster.org/17975)

...in file/dir creation and lookup codepaths. The check is relaxed for
fops coming from trash xlator at the moment until trash has client side
logic to send the create fops with gfid-req.

Also fixed the missing trash pid assignment in creates sent by trash
xlator. Without this, truncated files won't be moved to .trashcan.

Change-Id: Ieddd7f0634850e7c7010e4fbb4ad1eead35888c8
BUG: 1479474
Signed-off-by: Ravishankar N 
Reviewed-on: https://review.gluster.org/17996
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan