glusterfs.git/xlators/features/upcall/src/upcall-internal.c, branch v3.10dev

md-cache: Register the list of xattrs with cache-invalidation

2016-08-31T06:07:01+00:00

Issue:
md-cache caches a specified list of xattrs, and when cache invalidation
is enabled, it makes sense to recieve invalidation only when those xattrs
are modified by other clients. But the current implementation of upcall
is that, it will send invalidation when any of the on-disk xattrs is modified.

Solution:
md-cache sends a list of xattrs that it is interested in, to upcall by
issuing an ipc(). The challenge here is to make sure everytime a brick
goes offline and comes back up, the ipc() needs to be issued to the
bricks. Hence ipc() is sent from md-cache every time there is a
CHILD_UP/CHILD_MODIFIED event.

TODO:
There will be patches following, in cluster xlators, to implement ipc fop.

Change-Id: I6efcf3df474f5ce6eabd3d6694c00c7bd89bc25d
BUG: 1211863
Signed-off-by: Poornima G 
Reviewed-on: http://review.gluster.org/15002
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Rajesh Joseph 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Prashanth Pai 
Reviewed-by: Raghavendra G

upcall: fix unused variable warnings/errors

2016-08-25T12:11:31+00:00

http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.

However 14085 won't pass the smoke test until all the warnings are
fixed.

Change-Id: I887aa033f00ab67f73c7d7a7f1b3054d43bffc49
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/15252
Reviewed-by: Niels de Vos 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

upcall: pass dict with xattrs on xattr invalidation

2016-05-19T09:28:07+00:00

In case of xattr invalidation, return a dict containing
the updated xattrs.

[ndevos: move chunks to change 12995 and only address the xattrs-dict here]

Change-Id: I8733f06a519a9a0f24be1bb4b2c38c9c9dce0ce2
BUG: 1211863
Signed-off-by: Poornima G 
Reviewed-on: http://review.gluster.org/12996
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Niels de Vos 
Reviewed-by: soumya k 
Tested-by: soumya k

upcall: Add support to invalidate xattrs

2016-05-11T18:23:00+00:00

When SElinux is used, clients should get a notification that the
extended attributes have been updated. Other components (like md-cache)
will be able to use this too.

A big part of the implementation comes from Poornima through the first
version of http://review.gluster.org/12996.

Also moving the flags from upcall-cache-invalidation.h to the main
libglusterfs upcall-utils.h file, so that other places can easily use
them in future.

Change-Id: I525345bed8f22d029524ff19ccaf726a2c905454
BUG: 1211863
Signed-off-by: Niels de Vos 
Signed-off-by: Poornima G 
Reviewed-on: http://review.gluster.org/12995
Reviewed-by: soumya k 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

Upcall: Read gfid from iatt in case of invalid inode

2015-12-01T10:32:50+00:00

When any file/dir is looked upon for the first time, inode
created shall be invalid till it gets linked to the inode table.
In such cases, read the gfid from the iatt structure returned
as part of such fops for UPCALL processing.

Change-Id: Ie5eb2f3be18c34cf7ef172e126c9db5ef7a8512b
BUG: 1283983
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/12773
Reviewed-by: Kaleb KEITHLEY 
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

upcall: prevent busy loop in reaper thread

2015-06-14T10:20:57+00:00

http://review.gluster.org/10342 introduced a cleanup thread for expired
client entries. When enabling the 'features.cache-invalidation' volume
option, the brick process starts to run in a busy-loop. Obviously this
is not intentional, and a process occupying 100% of the cycles on a CPU
or core is not wanted.

Change-Id: I453c612d72001f4d8bbecdd5ac07aaed75b43914
BUG: 1200267
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/11198
Reviewed-by: soumya k 
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Gluster Build System

Upcall/cache-invalidation: Ignore fops with frame->root->client not set

2015-06-09T13:46:20+00:00

Server-side internally generated fops like 'quota/marker' will
not have any client associated with the frame. Hence we need a
check for clients to be valid before processing for upcall cache
invalidation. Also fixed an issue with initializing reaper-thread.

Added a testcase to test the fix.

Change-Id: If7419b98aca383f4b80711c10fef2e0b32498c57
BUG: 1227204
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/10909
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: jiffin tony Thottan 
Tested-by: NetBSD Build System 
Reviewed-by: Niels de Vos

build: do not #include "config.h" in each file

2015-05-29T12:43:17+00:00

Instead of including config.h in each file, and have the additional
config.h included from the compiler commandline (-include option).

When a .c file tests for a certain #define, and config.h was not
included, incorrect assumtions were made. With this change, it can not
happen again.

BUG: 1222319
Change-Id: I4f9097b8740b81ecfe8b218d52ca50361f74cb64
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/10808
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Pranith Kumar Karampuri

Upcall: Send stat as part of cache_invalidation notifications

2015-05-05T13:57:43+00:00

Have added support to send attributes of both entries and
its parent (include oldparent in case of RENAME fop) in the
same notification request to avoid multiple rpc requests.

Also, made changes in gfapi to send parent object and its
attributes changed in a single upcall event.

Change-Id: I92833da3bcec38d65216921c2ce4d10367c32ef1
BUG: 1200262
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/10460
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

Upcall: Cleanup expired client entries

2015-05-04T23:27:41+00:00

To cleanup expired client entries (with access_time > 2*CACHE_INVALIDATION_TIMEOUT),
have
        * defined a global list to contain all the upcall_inode_ctx allocated
        * Every time a upcall_inode_ctx is allocated, it is added to the global list
        * during inode_forget, that upcall_inode_ctx is marked for destroy
        * created a reaper thread which scans through that list
                * cleans up expired client entries
                * frees the inode_ctx with destroy_mode set.

Note: This reaper thread is initialized only when features.cache_invalidation option
is enabled.

Change-Id: Iea2a63eb31b8e08d5709e7e090cf26fd13d01265
BUG: 1200267
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/10342
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY