glusterfs.git/xlators/features/trash, branch v3.7.9

features/trash: Handle unlink unwind properly

2016-03-08T15:29:51+00:00

When enabled, trash translator does a rename
internally for every unlink request and unwinds
the original unlink call. But this was unwinded
back with prerparent and postparent as NULL which
resulted in changing the parent directory
permissions to 000.

This issue is consistently seen as a failure
when a non-root user executes vim commands which
internally tries to perform stat operations (as
part of swap/backup file creation) on a file
whose parent directory's permission was modified
to 000 due to recent unlink for another file
inside the same directory.

>Change-Id: I161a036b37fb815866d50d2d6260ff0ad22d7223
>BUG: 1302307
>Signed-off-by: Anoop C S 
>Reviewed-on: http://review.gluster.org/13346
>Smoke: Gluster Build System 
>Tested-by: jiffin tony Thottan 
>Reviewed-by: jiffin tony Thottan 
>CentOS-regression: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
(cherry picked from commit b609a55be4119c44b19252bd951780a78deb21c9)

Signed-off-by: Anoop C S 
Change-Id: I88950b7d2e42bda65272bc359e8dc60a2ce04d89
BUG: 1305749
Reviewed-on: http://review.gluster.org/13401
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: jiffin tony Thottan 
Reviewed-by: Vijay Bellur 
Smoke: Gluster Build System

features/trash: Retain file permissions during truncate

2016-03-06T00:18:15+00:00

Consider the situation where directory path for a truncated
file does not exists under trash directory. In this scenario
after creating the required path we failed to create the
orginal file with proper permissions. Eventhough we try to
fetch permissions from local->origpath, it was never filled
with required value in truncate and ftruncate call paths.
This change will copy original location to local->origpath
inside both fop handling functions.

>Change-Id: If5930b6d368d08e58f04db999f3f9edb9250bcb9
>BUG: 1309342
>Signed-off-by: Anoop C S 
>Reviewed-on: http://review.gluster.org/13461
>Smoke: Gluster Build System 
>CentOS-regression: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>Reviewed-by: jiffin tony Thottan 
>Reviewed-by: Jeff Darcy 
(cherry picked from commit b1cb581424305592fac5394a578b307117b22fe7)

Change-Id: I5d964b4d802551bb04a7011f88edb59a1231238e
BUG: 1313233
Signed-off-by: Anoop C S 
Reviewed-on: http://review.gluster.org/13555
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: jiffin tony Thottan 
Reviewed-by: Vijay Bellur

marker: do remove xattr only for last link

2015-11-09T11:12:55+00:00

This is a backport of http://review.gluster.org/#/c/12033/

With unlink, rename, rmdir, contribution xattrs
are removed. If the file is a last link
then remove_xattr will fail with ENOENT.

So it better to perform remove_xattr
only if there are more links to the file

> Change-Id: Ifc1e7fda4d310fd87f6f28a635c9ea78b8f3929d
> BUG: 1257694
> Signed-off-by: vmallika 

Change-Id: Icf5fdd86bbb8eef0adeb9518e89e5b612e9e0705
BUG: 1279331
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/12549
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G

fd: Do fd_bind on successful open

2015-10-06T06:11:02+00:00

- fd_unref should decrement fd->inode->fd_count only if it is present in the
inode's fd list.
- successful open/opendir should perform fd_bind.

 >Change-Id: I81dd04f330e2fee86369a6dc7147af44f3d49169
 >BUG: 1207735
 >Signed-off-by: Pranith Kumar K 
 >Reviewed-on: http://review.gluster.org/11044
 >Reviewed-by: Anoop C S 
 >Tested-by: NetBSD Build System 
 >Tested-by: Gluster Build System 
 >Reviewed-by: Raghavendra G 

BUG: 1259697
Change-Id: I73b79dd3519aa085fb84dde74b321511cbccce1a
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/12100
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra G

features/trash : Notify CTR translator if an unlink happens to a file

2015-05-05T06:21:06+00:00

        Backport of http://review.gluster.org/#/c/9989/

This implementation is same as the posix_unlink_cbk() where CTR sends
a request during a unlink to send the number of links to the inode
and posix obliges sending it using the unwind xdata dict.
For Trash xlator a unlink is stat + mkdir(if parent is not present)
+ rename. And hence this is handled in trash_unlink_rename_cbk().

Change-Id: I402e83567b88e3c9fe171379693c82937af567f9
BUG: 1218032
Signed-off-by: Jiffin Tony Thottan 
Signed-off-by: Joseph Fernandes 
Signed-off-by: Anoop C S 
Reviewed-on: http://review.gluster.org/10513
Reviewed-by: Joseph Fernandes
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright 
Reviewed-by: Vijay Bellur

features/trash: Minor coverity fixes

2015-04-27T06:25:28+00:00

        Backport of http://review.gluster.org/10315

CID 1288784
CID 1288785
CID 1288795
CID 1288796
CID 1288797
CID 1288802

Change-Id: I51dd7653a2dce3b7b6387e5d91c1c07eb157a04b
BUG: 1215026
Signed-off-by: Anoop C S 
Tested-by: Gluster Build System 
Tested-by: jiffin tony Thottan 
Reviewed-by: jiffin tony Thottan 
Reviewed-on: http://review.gluster.org/10361
Tested-by: NetBSD Build System

features/trash: More coverity fixes

2015-04-04T17:58:15+00:00

The following CIDs are being addressed:

1288792
1288794

Change-Id: Ic2cdaf43f05488e04616ceb801b47a47c6a93656
BUG: 789278
Signed-off-by: Anoop C S 
Reviewed-on: http://review.gluster.org/10082
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

Avoid conflict between contrib/uuid and system uuid

2015-04-04T17:48:35+00:00

glusterfs relies on Linux uuid implementation, which
API is incompatible with most other systems's uuid. As
a result, libglusterfs has to embed contrib/uuid,
which is the Linux implementation, on non Linux systems.
This implementation is incompatible with systtem's
built in, but the symbols have the same names.

Usually this is not a problem because when we link
with -lglusterfs, libc's symbols are trumped. However
there is a problem when a program not linked with
-lglusterfs will dlopen() glusterfs component. In
such a case, libc's uuid implementation is already
loaded in the calling program, and it will be used
instead of libglusterfs's implementation, causing
crashes.

A possible workaround is to use pre-load libglusterfs
in the calling program (using LD_PRELOAD on NetBSD for
instance), but such a mechanism is not portable, nor
is it flexible. A much better approach is to rename
libglusterfs's uuid_* functions to gf_uuid_* to avoid
any possible conflict. This is what this change attempts.

BUG: 1206587
Change-Id: I9ccd3e13afed1c7fc18508e92c7beb0f5d49f31a
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/10017
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

features/trash: fix remove_trash_path in the internal case

2015-04-01T06:52:04+00:00

In the internal case, copy_trash_path adds a second
path component "internal_op/", so remove_trash_path
should remove it again. Originally, remove_trash_path
did the same thing in the internal and non-internal case.
This patch fixes this problem.

Change-Id: If247d18217a2375d369672182f69a54881df26b9
BUG: 1207709
Signed-off-by: Michael Adam 
Reviewed-on: http://review.gluster.org/10073
Tested-by: Gluster Build System 
Reviewed-by: Anoop C S 
Reviewed-by: Vijay Bellur

features/trash: fix remove_trash_path() to do what it is intended.

2015-04-01T06:51:33+00:00

The intention is to set the the rem_path string pointer that
is handed in from the outside. So the string has to be passed
in by reference, or else the function just sets a pointer on
the stack.

Found by Coverity, CID 1288791

Also fixes:
CID 1288791
CID 1288809
CID 1288810
CID 1288814
CID 1288815
CID 1288817
CUD 1288818

Change-Id: I6ef5eeb58b83a875cf90513291abe37dee3fc9fb
BUG: 789278
Signed-off-by: Michael Adam 
Reviewed-on: http://review.gluster.org/10064
Tested-by: Gluster Build System 
Reviewed-by: Anoop C S 
Reviewed-by: Vijay Bellur