glusterfs.git/xlators/features/trash/src, branch v3.7.4

features/trash : Notify CTR translator if an unlink happens to a file

2015-05-05T06:21:06+00:00

        Backport of http://review.gluster.org/#/c/9989/

This implementation is same as the posix_unlink_cbk() where CTR sends
a request during a unlink to send the number of links to the inode
and posix obliges sending it using the unwind xdata dict.
For Trash xlator a unlink is stat + mkdir(if parent is not present)
+ rename. And hence this is handled in trash_unlink_rename_cbk().

Change-Id: I402e83567b88e3c9fe171379693c82937af567f9
BUG: 1218032
Signed-off-by: Jiffin Tony Thottan 
Signed-off-by: Joseph Fernandes 
Signed-off-by: Anoop C S 
Reviewed-on: http://review.gluster.org/10513
Reviewed-by: Joseph Fernandes
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright 
Reviewed-by: Vijay Bellur

features/trash: Minor coverity fixes

2015-04-27T06:25:28+00:00

        Backport of http://review.gluster.org/10315

CID 1288784
CID 1288785
CID 1288795
CID 1288796
CID 1288797
CID 1288802

Change-Id: I51dd7653a2dce3b7b6387e5d91c1c07eb157a04b
BUG: 1215026
Signed-off-by: Anoop C S 
Tested-by: Gluster Build System 
Tested-by: jiffin tony Thottan 
Reviewed-by: jiffin tony Thottan 
Reviewed-on: http://review.gluster.org/10361
Tested-by: NetBSD Build System

features/trash: More coverity fixes

2015-04-04T17:58:15+00:00

The following CIDs are being addressed:

1288792
1288794

Change-Id: Ic2cdaf43f05488e04616ceb801b47a47c6a93656
BUG: 789278
Signed-off-by: Anoop C S 
Reviewed-on: http://review.gluster.org/10082
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

Avoid conflict between contrib/uuid and system uuid

2015-04-04T17:48:35+00:00

glusterfs relies on Linux uuid implementation, which
API is incompatible with most other systems's uuid. As
a result, libglusterfs has to embed contrib/uuid,
which is the Linux implementation, on non Linux systems.
This implementation is incompatible with systtem's
built in, but the symbols have the same names.

Usually this is not a problem because when we link
with -lglusterfs, libc's symbols are trumped. However
there is a problem when a program not linked with
-lglusterfs will dlopen() glusterfs component. In
such a case, libc's uuid implementation is already
loaded in the calling program, and it will be used
instead of libglusterfs's implementation, causing
crashes.

A possible workaround is to use pre-load libglusterfs
in the calling program (using LD_PRELOAD on NetBSD for
instance), but such a mechanism is not portable, nor
is it flexible. A much better approach is to rename
libglusterfs's uuid_* functions to gf_uuid_* to avoid
any possible conflict. This is what this change attempts.

BUG: 1206587
Change-Id: I9ccd3e13afed1c7fc18508e92c7beb0f5d49f31a
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/10017
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

features/trash: fix remove_trash_path in the internal case

2015-04-01T06:52:04+00:00

In the internal case, copy_trash_path adds a second
path component "internal_op/", so remove_trash_path
should remove it again. Originally, remove_trash_path
did the same thing in the internal and non-internal case.
This patch fixes this problem.

Change-Id: If247d18217a2375d369672182f69a54881df26b9
BUG: 1207709
Signed-off-by: Michael Adam 
Reviewed-on: http://review.gluster.org/10073
Tested-by: Gluster Build System 
Reviewed-by: Anoop C S 
Reviewed-by: Vijay Bellur

features/trash: fix remove_trash_path() to do what it is intended.

2015-04-01T06:51:33+00:00

The intention is to set the the rem_path string pointer that
is handed in from the outside. So the string has to be passed
in by reference, or else the function just sets a pointer on
the stack.

Found by Coverity, CID 1288791

Also fixes:
CID 1288791
CID 1288809
CID 1288810
CID 1288814
CID 1288815
CID 1288817
CUD 1288818

Change-Id: I6ef5eeb58b83a875cf90513291abe37dee3fc9fb
BUG: 789278
Signed-off-by: Michael Adam 
Reviewed-on: http://review.gluster.org/10064
Tested-by: Gluster Build System 
Reviewed-by: Anoop C S 
Reviewed-by: Vijay Bellur

features/trash: fix storing/wiping of eliminate path (coverity)

2015-04-01T06:08:23+00:00

Functions store_eliminate_path() and wipe_eliminate_path() take
eliminate as a plain pointer not pointer to pointer. Hence
store_eliminate_path fails to hand the allocated and filled
eliminate data out to the caller (in particular leaking memory),
and wipe_eliminate_path() fails to NULL the freed eliminate path.

This leads to several leak and access after free errors found
by Coverity. This patch fixes the issue by handing in eliminate
by reference and in the case of wipe_eliminate path, also NULLing
out the free'd pointer.

This fixes the following coverity IDs:

CID 1288759
CID 1288790

Change-Id: I7520ae42c5f6e369a145bea67b4ff95b75d2ae73
BUG: 789278
Signed-off-by: Michael Adam 
Reviewed-on: http://review.gluster.org/10068
Tested-by: Gluster Build System 
Reviewed-by: Anoop C S 
Reviewed-by: Vijay Bellur

features/trash : Discarding extended truncate for trash-translator

2015-03-30T07:48:50+00:00

Change-Id: I5c571cbb2d6da1e95831ec206639926722a9d281
BUG: 1132465
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: http://review.gluster.org/9984
Tested-by: Gluster Build System 
Reviewed-by: Anoop C S 
Reviewed-by: Vijay Bellur

features/trash: Removing dead callbacks

2015-03-27T17:43:23+00:00

Since ftruncate create, mkdir, writev, readv and
unlink calls are being re-directed to corresponding
truncate calls, we no longer need their cbks. So
removing those cbks for now.

Change-Id: I41ecde7093a555b3bf69b66afaa8eca835b4982a
BUG: 1132465 
Signed-off-by: Anoop C S 
Reviewed-on: http://review.gluster.org/10002
Tested-by: Gluster Build System 
Reviewed-by: jiffin tony Thottan 
Reviewed-by: Vijay Bellur

features/trash: Handling hardlinks in trash translator

2015-03-24T07:18:50+00:00

In the current code of trash translator, file is moved to
trash directory without checking whether it is the last
hardlink.This may lead to inconsistency for a file in that
gluster volume.To avoid those scenarios,so a file is moved
to trash directory only if it is the last hardlink.

Change-Id: Id098e53a2236c6406ef91e6e2599ea2cff9bace3
BUG: 1132465
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: http://review.gluster.org/9926
Reviewed-by: Anoop C S 
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Vijay Bellur