glusterfs.git/xlators/features/trash/src, branch v3.7.17

xlator/trash : append '/' at the end in trash_notify_lookup_cbk

2016-08-16T06:23:14+00:00

In the notify function in trash xlator, a lookup is performed
to obtain path of old trash directory. The result usually contains
path without '/' at the end. The trash xlator maintains expects
'/' at the end for the values such as 'old trash dir' and
'new trash dir'. Otherwise certian checks in the code will fail.

Upstream reference:
>Change-Id: I89e02e4b249314fb6536297f959865feee182c83
>BUG: 1357397
>Signed-off-by: Jiffin Tony Thottan 
>Reviewed-on: http://review.gluster.org/14938
>Smoke: Gluster Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Anoop C S 
>NetBSD-regression: NetBSD Build System 
>Reviewed-by: Jeff Darcy 
>(cherry picked from commit d90307c1b0245e0e6a39044a28819cde520a100c)

Change-Id: I89e02e4b249314fb6536297f959865feee182c83
BUG: 1358268
Signed-off-by: Jiffin Tony Thottan 
Signed-off-by: Oleksandr Natalenko 
Reviewed-on: http://review.gluster.org/14966
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

features/trash: Handle unexpected errors during mkdir

2016-05-03T13:09:56+00:00

When expected directory hierarchy in not present in trash directory,
trash translator tries to create it inside the same. Any errors from
posix other than the expected ones should be handled properly during
an internal mkdir call and logged accordingly explaining the reason
for not moving the file to trash directory.

>Change-Id: I4e19637138ea4fb92f9301be372ac19542a6aed8
>BUG: 1318757
>Reviewed-on: http://review.gluster.org/13771
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: jiffin tony Thottan 

(cherry picked from commit 7b8e82f80942b862f30d3fb72c7eecb23fcae226)

Change-Id: I8574f461a4e60491b359685deeadedfb9760366e
BUG: 1319380
Signed-off-by: Anoop C S 
Reviewed-on: http://review.gluster.org/13783
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: jiffin tony Thottan

features/trash: wind mkdir with special pid

2016-05-03T11:22:48+00:00

Recent changes done w.r.t handling of mkdir calls in posix translator
resulted in crashing the brick process from trash translator. This was
due to the changes made in posix translator to return EPERM for every
mkdir calls without 'gfid-req' set in dictionary. In order to avoid
gfid mismatches during directory creation from brick side trash
translator does not set 'gfid-req'. This patch is to have an exemption
for trash based on a special pid set for those mkdir calls originating
from trash translator and to reset it in callback.

This patch also includes a small optimization to the existing test case for trash feature.

> Reviewed-on: http://review.gluster.org/13776
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Jeff Darcy 

(cherry picked from commit b5cfe948cb3569f034da80ac97b5d2f028b3b0e5)

Change-Id: I59f084ac875e54342ecf2bffa6e43ebd84814153
BUG: 1332372
Signed-off-by: Anoop C S 
Reviewed-on: http://review.gluster.org/14173
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System

features/trash: Handle unlink unwind properly

2016-03-08T15:29:51+00:00

When enabled, trash translator does a rename
internally for every unlink request and unwinds
the original unlink call. But this was unwinded
back with prerparent and postparent as NULL which
resulted in changing the parent directory
permissions to 000.

This issue is consistently seen as a failure
when a non-root user executes vim commands which
internally tries to perform stat operations (as
part of swap/backup file creation) on a file
whose parent directory's permission was modified
to 000 due to recent unlink for another file
inside the same directory.

>Change-Id: I161a036b37fb815866d50d2d6260ff0ad22d7223
>BUG: 1302307
>Signed-off-by: Anoop C S 
>Reviewed-on: http://review.gluster.org/13346
>Smoke: Gluster Build System 
>Tested-by: jiffin tony Thottan 
>Reviewed-by: jiffin tony Thottan 
>CentOS-regression: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
(cherry picked from commit b609a55be4119c44b19252bd951780a78deb21c9)

Signed-off-by: Anoop C S 
Change-Id: I88950b7d2e42bda65272bc359e8dc60a2ce04d89
BUG: 1305749
Reviewed-on: http://review.gluster.org/13401
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: jiffin tony Thottan 
Reviewed-by: Vijay Bellur 
Smoke: Gluster Build System

features/trash: Retain file permissions during truncate

2016-03-06T00:18:15+00:00

Consider the situation where directory path for a truncated
file does not exists under trash directory. In this scenario
after creating the required path we failed to create the
orginal file with proper permissions. Eventhough we try to
fetch permissions from local->origpath, it was never filled
with required value in truncate and ftruncate call paths.
This change will copy original location to local->origpath
inside both fop handling functions.

>Change-Id: If5930b6d368d08e58f04db999f3f9edb9250bcb9
>BUG: 1309342
>Signed-off-by: Anoop C S 
>Reviewed-on: http://review.gluster.org/13461
>Smoke: Gluster Build System 
>CentOS-regression: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>Reviewed-by: jiffin tony Thottan 
>Reviewed-by: Jeff Darcy 
(cherry picked from commit b1cb581424305592fac5394a578b307117b22fe7)

Change-Id: I5d964b4d802551bb04a7011f88edb59a1231238e
BUG: 1313233
Signed-off-by: Anoop C S 
Reviewed-on: http://review.gluster.org/13555
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: jiffin tony Thottan 
Reviewed-by: Vijay Bellur

marker: do remove xattr only for last link

2015-11-09T11:12:55+00:00

This is a backport of http://review.gluster.org/#/c/12033/

With unlink, rename, rmdir, contribution xattrs
are removed. If the file is a last link
then remove_xattr will fail with ENOENT.

So it better to perform remove_xattr
only if there are more links to the file

> Change-Id: Ifc1e7fda4d310fd87f6f28a635c9ea78b8f3929d
> BUG: 1257694
> Signed-off-by: vmallika 

Change-Id: Icf5fdd86bbb8eef0adeb9518e89e5b612e9e0705
BUG: 1279331
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/12549
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G

fd: Do fd_bind on successful open

2015-10-06T06:11:02+00:00

- fd_unref should decrement fd->inode->fd_count only if it is present in the
inode's fd list.
- successful open/opendir should perform fd_bind.

 >Change-Id: I81dd04f330e2fee86369a6dc7147af44f3d49169
 >BUG: 1207735
 >Signed-off-by: Pranith Kumar K 
 >Reviewed-on: http://review.gluster.org/11044
 >Reviewed-by: Anoop C S 
 >Tested-by: NetBSD Build System 
 >Tested-by: Gluster Build System 
 >Reviewed-by: Raghavendra G 

BUG: 1259697
Change-Id: I73b79dd3519aa085fb84dde74b321511cbccce1a
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/12100
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra G

features/trash : Notify CTR translator if an unlink happens to a file

2015-05-05T06:21:06+00:00

        Backport of http://review.gluster.org/#/c/9989/

This implementation is same as the posix_unlink_cbk() where CTR sends
a request during a unlink to send the number of links to the inode
and posix obliges sending it using the unwind xdata dict.
For Trash xlator a unlink is stat + mkdir(if parent is not present)
+ rename. And hence this is handled in trash_unlink_rename_cbk().

Change-Id: I402e83567b88e3c9fe171379693c82937af567f9
BUG: 1218032
Signed-off-by: Jiffin Tony Thottan 
Signed-off-by: Joseph Fernandes 
Signed-off-by: Anoop C S 
Reviewed-on: http://review.gluster.org/10513
Reviewed-by: Joseph Fernandes
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright 
Reviewed-by: Vijay Bellur

features/trash: Minor coverity fixes

2015-04-27T06:25:28+00:00

        Backport of http://review.gluster.org/10315

CID 1288784
CID 1288785
CID 1288795
CID 1288796
CID 1288797
CID 1288802

Change-Id: I51dd7653a2dce3b7b6387e5d91c1c07eb157a04b
BUG: 1215026
Signed-off-by: Anoop C S 
Tested-by: Gluster Build System 
Tested-by: jiffin tony Thottan 
Reviewed-by: jiffin tony Thottan 
Reviewed-on: http://review.gluster.org/10361
Tested-by: NetBSD Build System

features/trash: More coverity fixes

2015-04-04T17:58:15+00:00

The following CIDs are being addressed:

1288792
1288794

Change-Id: Ic2cdaf43f05488e04616ceb801b47a47c6a93656
BUG: 789278
Signed-off-by: Anoop C S 
Reviewed-on: http://review.gluster.org/10082
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur