glusterfs.git/xlators/features/quota, branch v3.7.5

rpc: add owner xlator argument to rpc_clnt_new

2015-08-14T10:10:47+00:00

The @owner argument tells RPC layer the xlator that owns
the connection and to which xlator THIS needs be set during
network notifications like CONNECT and DISCONNECT.

Code paths that originate from the head of a (volume) graph and use
STACK_WIND ensure that the RPC local endpoint has the right xlator saved
in the frame of the call (callback pair). This guarantees that the
callback is executed in the right xlator context.

The client handshake process which includes fetching of brick ports from
glusterd, setting lk-version on the brick for the session, don't have
the correct xlator set in their frames. The problem lies with RPC
notifications. It doesn't have the provision to set THIS with the xlator
that is registered with the corresponding RPC programs. e.g,
RPC_CLNT_CONNECT event received by protocol/client doesn't have THIS set
to its xlator. This implies, call(-callbacks) originating from this
thread don't have the right xlator set too.

The fix would be to save the xlator registered with the RPC connection
during rpc_clnt_new. e.g, protocol/client's xlator would be saved with
the RPC connection that it 'owns'. RPC notifications such as CONNECT,
DISCONNECT, etc inherit THIS from the RPC connection's xlator.

Change-Id: I9dea2c35378c511d800ef58f7fa2ea5552f2c409
BUG: 1253212
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/11436
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra G 
(cherry picked from commit f7668938cd7745d024f3d2884e04cd744d0a69ab)
Reviewed-on: http://review.gluster.org/11908
Reviewed-by: Pranith Kumar Karampuri

quota: fix parents caching during build ancestry

2015-08-03T04:04:41+00:00

This is a backport of http://review.gluster.org/#/c/11574/

In build ancestry, we get the list of parents for a file,
these parents are cached in inode ctx.
This caching is not happening because posix is not setting
d_stat information in the leaf node entry
This patch fixes the issue

Inode-ctx is not updated with new parent when
rename performed on same directory.
This patch fixes the issue

There is a possibility of caching stale entries,
consider below example:
1) build_ancestry invoked on a file
2) rename is invoked on the same file
3) buils_ancestry prepared entries of old parent
4) rename completed and in cbk old parent is replaced with
       new parent in inode ctx
5) now build_ancestry cbk adds old parent to inode ctx

In this patch we also remove stale entries in writev and fallocate

> Change-Id: Ib1854a41b47b14eb775326588352015c83d034de
> BUG: 1240949
> Signed-off-by: vmallika 
> Reviewed-on: http://review.gluster.org/11574
> Tested-by: Gluster Build System 
> Reviewed-by: Raghavendra G 

Change-Id: I26a196e7eeed343593bea3a0b7b51d7be12500a3
BUG: 1248325
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/11799
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G

quota: Fix crash in quota enforcer

2015-07-21T10:20:18+00:00

This is a backport of http://review.gluster.org/11510

With multiple hardlinks check_quota_limit is invoked for each parent
each of this check_limit can invoke validation
this can cause frame->local to get corrupted during validation.

Testcase tests/bugs/quota/bug-1235182.t fails spuriously with
this problem

> Change-Id: I53adc54b431fb5f43e67a94248102ddaf0d7978f
> BUG: 1238747
> Signed-off-by: vmallika 
> Reviewed-on: http://review.gluster.org/11510
> Tested-by: NetBSD Build System 
> Reviewed-by: Raghavendra G 

Change-Id: Ia7f57276db034e0fc6cd84dbf618ce0d4fae4321
BUG: 1242898
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/11662
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G

quotad: create sock listener only after graph init is complete

2015-07-10T03:55:51+00:00

This is a backport of http://review.gluster.org/#/c/11552/

If FOPs are received before completing graph initialization,
FOP path can crash while accessing uninitialized variables

This patch fixes issue by not creating listener until
graph initialization is complete and hence not receiving
FOP request

> Change-Id: I4771e376410843dff44bfe819329a4632523d266
> BUG: 1240254
> Signed-off-by: vmallika 

Change-Id: I6c5964a8334abdc26aa2813c13f09e796e22b10a
BUG: 1240906
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/11570
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra G

quota: fix mem leak in quota enforcer

2015-07-07T11:01:10+00:00

This is a backport of review.gluster.org/#/c/11526/

Do inode_unref on parent

> Change-Id: I21d82eb8716dd73aa2dc291b3ae8506e4fb4ea8b
> BUG: 1207735
> Signed-off-by: vmallika 

Change-Id: I4caeedbe8721b660df1c8502a0a42033f1d40a97
BUG: 1229282
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/11529
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G

features/quota: port QUOTA messages to new logging framework

2015-06-24T04:07:25+00:00

Change-Id: I2fa725323ee9a9959fd105ea014c90e2fad11c14
BUG: 1234297
Signed-off-by: Susant Palai 
Reviewed-on: http://review.gluster.org/7574
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G 
Signed-off-by: Susant Palai 
Reviewed-on: http://review.gluster.org/11341

quota: allow writes when with ENOENT/ESTALE on active fd

2015-06-22T11:11:39+00:00

This is a backport of http://review.gluster.org/#/c/11307/

> We may get ENOENT/ESTALE in case of below scenario
>         fd = open file.txt
>         unlink file.txt
>         write on fd
> Here build_ancestry can fail as the file is removed.
> For now ignore ENOENT/ESTALE on active fd with
> writev and fallocate.
> We need to re-visit this code once we understand
> how other file-system behave in this scenario
>
> Below patch fixes the issue in DHT:
> http://review.gluster.org/#/c/11097
>
> Change-Id: I7be683583b808c280e3ea2ddd036c1558a6d53e5
> BUG: 1188242
> Signed-off-by: vmallika 

Change-Id: Ic836d200689fe6f27d4675bc0ff89063b7dc3882
BUG: 1219358
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/11326
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G

quota: don't log error when disk quota exceeded

2015-06-17T12:16:23+00:00

This is a backport of http://review.gluster.org/#/c/11135

> When disk quota exceeded, quota enforcer logs
> alert message, so no need to log error message
> as this can fill up the log file
>
> Change-Id: Ia913f47bc0cedb7c0a9c611330ee5124d3bb6c9d
> BUG: 1229609
> Signed-off-by: vmallika 

Change-Id: I7b0b91965d8eb1b38ef6fa5ce0276a6b6da3372d
BUG: 1232135
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/11242
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G

features/quota: Fix ref-leak

2015-06-11T10:52:37+00:00

This is a backport of http://review.gluster.org/#/c/11045

> Change-Id: I0b44b70f07be441e044d9dfc5c2b64bd5b4cac18
> BUG: 1207735
> Signed-off-by: Pranith Kumar K 
> Reviewed-on: http://review.gluster.org/11045
> Tested-by: Gluster Build System 
> Reviewed-by: Raghavendra G 
> Tested-by: Raghavendra G 
> Signed-off-by: vmallika 

Change-Id: Id740d74fb5cf7a9b23027dbbb0a9f42616dcf2fc
BUG: 1229282
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/11124
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G

quota: retry connecting to quotad on ENOTCONN error

2015-06-04T08:48:31+00:00

This is a backport of http://review.gluster.org/#/c/10230/

> Suppose if there are two volumes vol1 and vol2,
> and quota is enabled and limit is set on vol1.
> Now if IO is happening on vol1 and quota is enabled/disabled
> on vol2, quotad gets restarted and client will receive
> ENOTCONN in the IO path of vol1.
>
> This patch will retry connecting to quotad upto 60sec
> in a interval of 5sec (12 retries)
> If not able to connect with 12 retries, then return ENOTCONN
>
> Change-Id: Ie7f5d108633ec68ba9cc3a6a61d79680485193e8
> BUG: 1211220
> Signed-off-by: vmallika 
> Reviewed-on: http://review.gluster.org/10230
> Tested-by: Gluster Build System 
> Reviewed-by: Raghavendra G 
> Tested-by: Raghavendra G 

Change-Id: I94d8d4a814a73d69e934f3e77e989e5f3bf2e65a
BUG: 1226789
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/11024
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G