glusterfs.git/xlators/features/marker, branch release-3.7

marker: Fix inode value in loc, in setxattr fop

2016-11-22T05:44:23+00:00

Backport of http://review.gluster.org/15826

On recieving a rename fop, marker_rename() stores the,
oldloc and newloc in its 'local' struct, once the rename
is done, the xtime marker(last updated time) is set on
the file, but sending a setxattr fop. When upcall
receives the setxattr fop, the loc->inode is NULL and
it crashes. The loc->inode can be NULL only in one valid
case, i.e. in rename case where the inode of new loc
can be NULL. Hence, marker should have filled the inode
of the new_loc before issuing a setxattr.

> Reviewed-on: http://review.gluster.org/15826
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Kotresh HR 
> Smoke: Gluster Build System 
> Reviewed-by: Rajesh Joseph 
(cherry picked from commit 46e5466850311ee69e6ae9a11c2bba2aabadd5de)

Change-Id: Id638f678c3daaf4a5c29b970b58929d377ae8977
BUG: 1396419
Signed-off-by: Poornima G 
Reviewed-on: http://review.gluster.org/15879
Reviewed-by: Rajesh Joseph 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System

features/marker: Fix dict_get errors when key is NULL

2016-05-04T05:46:21+00:00

Backport of:
>Change-Id: I25e497459441334c13af77b3fec83c42a7a92ac4
>BUG: 1319581
>Signed-off-by: Kotresh HR 
>Reviewed-on: http://review.gluster.org/13793
>Smoke: Gluster Build System 
>Tested-by: Vijaikumar Mallikarjuna 
>Reviewed-by: Vijaikumar Mallikarjuna 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Venky Shankar 
>Signed-off-by: Kotresh HR 

Change-Id: I8054ffab3574b6ceb1c7d4290e9f6de3dbf38724
BUG: 1332074
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/14144
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Venky Shankar

marker: do mq_reduce_parent_size_txn in FG for unlink & rmdir

2016-04-06T14:08:40+00:00

This is a backport of http://review.gluster.org/#/c/13874/

* If a "rm -rf" is performed by a client, we initiate a
  marker background operation mq_reduce_parent_size_txn
  for rmdir and unlink.

  mq_reduce_parent_size_txn can fail when updating
  size on the ancestor directories, if these directories
  are removed during the txn as the child-parent association
  removed in the dentry list.

  So execute mq_reduce_parent_size_txn in foreground
  and then do the UNWIND for rmdir and unlink FOP

> Change-Id: Iefcdced4c6ae0dbd43f92814d0ddcd1e33825864
> BUG: 1322489
> Signed-off-by: vmallika 

Change-Id: I79e4b53e4bacd39d23dad5278a7d02a338e59195
BUG: 1324040
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/13910
Smoke: Gluster Build System 
Reviewed-by: Raghavendra G 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

marker: optimize mq_update_dirty_inode_task

2016-04-06T12:23:52+00:00

This is a backport of http://review.gluster.org/#/c/13892/

In function mq_update_dirty_inode_task we do readdirp
on a dirty directory and for entry we again do
lookup to fecth the contribution xattr.
We can fetch this contribution as part of readdirp

> Change-Id: I766593c0dba793f1ab3b43625acce1c7d9af8d7f
> BUG: 1320818
> Signed-off-by: vmallika 

Change-Id: Id826a09a72529f7435372ea7f04068dd10da5fcb
BUG: 1324040
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/13908
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

marker: build_ancestry in marker

2016-04-06T08:24:00+00:00

This is a backport of http://review.gluster.org/#/c/13857/

* quota-enforcer doesn't execute build_ancestry in the below
  code path
    1) Special client (PID < 0)
    2) unlink
    3) rename within the same directory
    4) link within the same directory

    In these cases, marker accounting can fail as parent not found.
    We need to build_ancestry in marker if it doesn't find parent
    during update txn

> Change-Id: Idb7a2906500647baa6d183ba859b15e34769029c
> BUG: 1320818
> Signed-off-by: vmallika 

Change-Id: Ib56a556bdeebcc498d59599baf4655be05d765e5
BUG: 1324040
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/13907
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra G

storage/posix: send proper iatt attributes for the root inode

2016-04-04T12:33:32+00:00

This is a backport of http://review.gluster.org/13730

* changes in posix to send proper iatt attributes for the root directory
  when ancestry is built. Before posix was filling only the gfid and the
  inode type in the iatt structure keeping rest of the fields zeros.
  This was cached by posix-acl and used to send EACCES when some fops came on
  that object if the uid of the caller is same as the uid of the object
  on the disk.

* getting and setting inode_ctx in function 'posix_acl_ctx_get' is not
  atomic and can lead to memory leak when there are multiple lookups for an
  inode at same time. This patch fixes this problem

* Linking an inode in posix_build_ancestry, can cause a race in
  posix_acl.
  When parent inode is linked in posix_build_ancestry, and before
  it reaches posix_acl_readdirp_cbk, create/lookup can
  come on a leaf-inode, as parent-inode-ctx not yet updated
  in posix_acl_readdirp_cbk, create/lookup can fail
  with EACCESS. So do the inode linking in the quota xlator

> Change-Id: I3101eefb65551cc4162c4ff2963be1b73deacd6d
> BUG: 1320818
> Signed-off-by: Raghavendra Bhat 
> Reviewed-on: http://review.gluster.org/13730
> Tested-by: Vijaikumar Mallikarjuna 
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Raghavendra G 

Change-Id: I65b0bbf83e563b519db07f2bcddcc6465743b6ea
BUG: 1320892
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/13825
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos 
Reviewed-by: Raghavendra G

marker: set inode ctx before lookup unwind

2016-03-23T03:48:28+00:00

This is a backport of http://review.gluster.org/13748

When a file is unlinked before it was accounted by the marker,
then we may see error "ctx for the node ... is NULL" at many places.
This is actually not an error and can be ignored.

It is better to set the inode ctx before lookup/create is unwind
back to protocol server

> Change-Id: I462b5542951f2fc2964f59af7a31978979dab1de
> BUG: 1318158
> Signed-off-by: vmallika 
> Reviewed-on: http://review.gluster.org/13748
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Raghavendra G 

Change-Id: I04b03e3caefc7fbd5e79b3f73980e2ccb0cb57f5
BUG: 1320024
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/13804
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Raghavendra G

geo-rep: Mask xtime and stime xattrs

2016-03-07T10:24:18+00:00

Allow access to xtime and stime xattrs only
to gsyncd client and mask them for the rest.

This is to prevent afr from performing self
healing on marker xtime and geo-rep stime
xattr which is not expected as each of which
gets updated them from backend brick and
should not be healed.

BUG: 1313623
Change-Id: I9b4b3ce30bbc09d300e6d5c6782e2446f2411c6f
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/13242
NetBSD-regression: NetBSD Build System 
Reviewed-by: Vijaikumar Mallikarjuna 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/13572
Reviewed-by: Aravinda VK

cluster/ec: Mark self-heal fops as internal

2016-03-05T01:26:21+00:00

 >Change-Id: I8ae7af266d3e00460f0cfdc9389a926e5f2fee36
 >BUG: 1282761
 >Signed-off-by: Pranith Kumar K 
 >Reviewed-on: http://review.gluster.org/12598
 >Tested-by: Gluster Build System 
 >Tested-by: NetBSD Build System 
 >Reviewed-by: Xavier Hernandez 

BUG: 1283757
Change-Id: Ic20d4ee031265305db1a6ed2cf591ce94b7d0749
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/12668
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

quota: Fix incorrect disk usage shown on a tiered volume

2016-02-11T06:12:08+00:00

When quota is enabled on a tiered volume, incorrect data usage is
shown, it is because, during the process of migrating files in tiering,
we are accounting both for the src file and dst file at some point. By the
time we make the srcfile as a T file, marker has already accounted the
contri and has updated it's parent and also we are not accounting for the
truncate operation done, which accounts to incorrect data usage even after
unlinking the file. The size can increase drastically with multiple promotes
and demotes since the contri keeps changing and the parent is being updated.

        Backport of http://review.gluster.org/#/c/13363/

> Change-Id: Ie567228786713d7dc257ff374a69ad3be40f9e82
> BUG: 1304970
> Signed-off-by: Manikandan Selvaganesh 

Change-Id: I72138aa3bb9ad180287e9bed916b845ec028f259
BUG: 1305029
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/13388
Reviewed-by: Vijaikumar Mallikarjuna 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Raghavendra G