glusterfs.git/xlators/features/marker/src, branch release-3.5

quota : avoid "contribution node is empty" error logs

2016-02-12T08:28:36+00:00

In versions older than 3.7, "contribution node list is empty which is
an error" gets logged numerous number of times. It is completely fixed
in 3.7. Since the entire marker and quota code has almost been
refactored, it is hard to backport the complete fix and also it could
not be fixed with the older approach. As a temporary fix, to avoid
numerous logs, the patch just supresses the log level.

3.6 Patch -> http://review.gluster.org/#/c/13304/

Change-Id: Ie666ba99c7bb16b9ce249b581e09857734589f51
BUG: 1288195
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/12990
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Niels de Vos 
Reviewed-by: Vijaikumar Mallikarjuna

quota: Validate NULL inode from the entries received in readdirp_cbk

2015-06-28T19:52:19+00:00

This is a backport of http://review.gluster.org/#/c/10416/

> In quota readdirp_cbk, inode ctx filled for the all entries
> received.
> In marker readdirp_cbk, files/directories are inspected for
> dirty

> There is no guarantee that entry->inode is populated.
> If entry->inode is NULL, this needs to be treated as readdir
>
> Change-Id: Id2d17bb89e4770845ce1f13d73abc2b3c5826c06
> BUG: 1215550
> Signed-off-by: vmallika 
> Reviewed-on: http://review.gluster.org/10416
> Tested-by: NetBSD Build System
> Tested-by: Gluster Build System 
> Reviewed-by: Raghavendra G 
> Tested-by: Raghavendra G 

Change-Id: If6578984ab1a33a3bdbaf0ec169f7c9548991144
BUG: 1217433
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/10472
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

features/marker: Filter internal xattrs in lookup

2015-02-12T12:08:12+00:00

        Backport of http://review.gluster.com/9061

Afr should ignore quota-size-key as part of self-heal
but should heal quota-limit key.

BUG: 1162230
Change-Id: I639cfabbc44468da29914096afc7e2eca1ff1292
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/9091
Tested-by: Gluster Build System 
Reviewed-by: Ravishankar N 
Reviewed-by: Raghavendra G 
Reviewed-by: Krutika Dhananjay 
Reviewed-by: Niels de Vos

features/marker: do not call inode_path on the inode not yet linked

2015-02-05T15:17:24+00:00

This is a backport of http://review.gluster.org/#/c/9320

> * in readdirp callbak marker is calling inode_path on the inodes that
>   are not yet linked to the inode table.
>
> Change-Id: I7f5db29c6a7e778272044f60f8e73c60574df3a9
> BUG: 1176393
> Signed-off-by: Raghavendra Bhat 
> Reviewed-on: http://review.gluster.org/9320
> Tested-by: Gluster Build System 
> Reviewed-by: Raghavendra G 
> Tested-by: Raghavendra G 

Change-Id: I9e2c14d0e0dd52d01ff1dd65b0b50f83874eef0e
BUG: 1174250
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/9508
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

features/marker: Fill loc->path before sending the control to healing

2014-09-22T07:34:09+00:00

        Backport of: http://review.gluster.org/8296

Problem:
The xattr healing part of the marker requires path to be present in the loc.
Currently path is not filled while triggering from the readdirp_cbk.

Solution:
Current patch tries to fill the loc with path.

Change-Id: Icc16c740bc6453714306eae19526e18c1775c1d8
BUG: 1144315
Signed-off-by: Varun Shastry 
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/8778
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G

features/marker-quota: more stringent error handling in rename.

2014-05-11T02:36:10+00:00

If an error occurs and op_errno is not set to non-zero value, we can
end up in loosing a frame resulting in a hung syscall. This patch
adds code setting op_errno appropriately in storage/posix and
makes marker to set err to a default non-zero value in case of
op_errno being zero.

Change-Id: Idc2c3e843b932709a69b32ba67deb284547168f2
BUG: 833586
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/6913
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

features/marker: Filter quota xattrs on file as well

2014-02-03T04:26:13+00:00

Problem:
Quota contributions of a file/directory are tracked by quota
xlator using xattrs on the file. Quota allows these xattrs to be
healed as part of metadata self-heal. This leads to
wrong quota calculations on this brick after self-heal because
quota xattrs don't represent the actual contributions on the
brick anymore.

Fix:
Don't let self-heal of this xattr happen as part of self-heal
by filtering quota xattrs on file in listxattr.

Change-Id: Iea68a116595ba271e58c6fdcc3dd21c7bb55ebb3
BUG: 1035576
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/6374
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/6812

features/quota: Metadata cleanup

2014-01-29T06:39:43+00:00

Quota and marker uses 'trusted.glusterfs.quota*' and 'trusted.pgfid*' xattrs to
store its configurations and accounting information and also to build the
parent inode chain in case of absense of path.

Problem:
After disabling and then enabling quota back, the xattrs may contain stale data
leading to impaired accounting and thus improper enforcement.

Solution:
Clean up all the quota related xattrs after quota disable.

Marker xlator implements a virtual xattr to cleanup quota and pgfid xattrs. In
this approach glusterd mounts an auxiliary mount and sends the below command to
all the files by crawling the mountpoint.

 #setfattr -n "glusterfs.quota-xattr-cleanup" -v 1 

Credit:
Krishnan Parthasarathi 
Varun Shastry          
Change-Id: I9380eca58a285dc27dd572de1767aac8f2cd8049
BUG: 969461
Signed-off-by: Varun Shastry 
Reviewed-on: http://review.gluster.org/6369
Reviewed-by: Raghavendra G 
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/6838

cluster/dht: instruct marker whenever it shouldn't do accounting

2013-11-26T18:27:21+00:00

This is needed for two reasons:

* since dht-linkfiles are internal, they shouldn't be accounted.
* hardlink handling in marker is broken. link/unlink of hardlinks
  present in same directory can break marker accounting. Hence, if src
  and dst are in same directory in case of rename, dht - if it breaks
  rename into link/unlink operations - should instruct marker to not to
  do accounting.

Change-Id: I9c9f7384569f75a2792f6450ee7a5279bf751ae7
BUG: 1022995
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/6203
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

features/marker-quota: exclude dht-linkfiles from being accounted.

2013-11-26T18:27:03+00:00

Change-Id: I3239f5e8477664dcc04434e4d455ae447493a7ac
BUG: 1022995
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/6153
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati