glusterfs.git/xlators/features/locks/src/posix.c, branch v3.3.2

localtime and ctime are not MT-SAFE

2013-02-08T20:04:42+00:00

There are a number of nit-level issues throughout the source with
the use of localtime and ctime. While they apparently aren't causing
too many problems, apart from the one in bz 828058, they ought to be
fixed. Among the "real" problems that are fixed in this patch:
1) general localtime and ctime not MT-SAFE. There's a non-zero chance
   that another thread calling localtime (or ctime) will over-write
   the static data about to be used in another thread
2) localtime(& <64-bit-type>) or ctime(& <64-bit-type>) generally
   not a problem on 64-bit or little-endian 32-bit. But even though
   we probably have zero users on big-ending 32-bit platforms, it's
   still incorrect.
3) multiple nested calls passed as params. Last one wins, i.e. over-
   writes result of prior calls.
4) Inconsistent error handling. Most of these calls are for logging,
   tracing, or dumping. I submit that if an error somehow occurs in
   the call to localtime or ctime, the log/trace/dump still should
   still occur.
5) Appliances should all have their clocks set to UTC, and all log
   entries, traces, and dumps should use GMT.
6) fix strtok(), change to strtok_r()

Other things this patch fixes/changes (that aren't bugs per se):
1) Change "%Y-%m-%d %H:%M:%S" and similar to their equivalent shorthand,
   e.g. "%F %T"
2) change sizeof(timestr) to sizeof timestr. sizeof is an operator,
   not a function. You don't use i +(32), why use sizeof().
   (And yes, you do use parens with sizeof().)
3) change 'char timestr[256]' to 'char timestr[32]' where appropriate.
   Per-thread stack is limited. Time strings are never longer than ~20
   characters, so why waste 220+ bytes on the stack?

Things this patch doesn't fix:
1) hodgepodge of %Y-%m-%d %H:%M:%S versus %Y/%m/%d-%H%M%S and other
   variations. It's not clear to me whether this ever matters, not to
   mention 3rd party log filtering tools may already rely on a
   particular format. Still it would be nice to have a single manifest
   constant and have every call to localtime/strftime consistently use
   the same format.

BUG: 832173

Change-Id: Iee9719db4576eacc6c75694d9107954d0912cba8
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/3613
Reviewed-by: Anand Avati 
Tested-by: Anand Avati

features/locks: Fix statedump code

2012-08-12T07:12:09+00:00

RCA:
Taking blocking mutex/spin locks lead to dead locks
because of the locking order in statedumps. Also we
were asked to remove gf_logs if possible to avoid extra
cost in signal handlers.

Fix:
changed blocking mutes/spin locks to their non-blocking variants.
Removed gf_logs in locks xlator statedump code-path.

Tests:
State-dump success cases are working fine.
Triggered try-lock failures by putting statedumps in a while loop.
In parallel did chown of the same file in a while loop.

BUG: 843781
Change-Id: Iac9b75d79cd5e036cd3eafc1e106074e2c6b5c47
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/3752
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

features/locks: Don't delete blocked locks in pl_flush

2012-05-22T11:30:19+00:00

BUG: 810502
Change-Id: I68c1c11754e1f4413b457c5f4bb7da3bc1aafc23
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/3398
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

locks: Set flock.l_type on successful F_UNLCK to signal last unlock on fd.

2012-05-10T22:26:54+00:00

NLM expects a successful F_UNLCK on an fd to set flock.l_type to F_UNLCK
if it were the last unlock else F_RDLCK.

Change-Id: Ib304ac6102664abbb13d1fda649b3da63f1ee97e
BUG: 800300
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.com/3306
Tested-by: Gluster Build System 
Reviewed-by: Krishna Srinivas 
Reviewed-by: Anand Avati

features/locks: Find parent-entrylk presence in lookup

2012-04-19T05:20:47+00:00

Change-Id: I8fc85676827f26b07bf578ea1152d3e251adb4af
BUG: 765551
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/3177
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

locks, stripe: check if dict is NULL before refing it

2012-04-03T11:20:48+00:00

Change-Id: Ifab58504280ed92e4435f7805052745e56bef5ef
BUG: 808003
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.com/3073
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

features/locks: check whether dict is NULL before refing it

2012-03-29T14:47:11+00:00

Change-Id: I8906b80e584466aceb5a7402e3cee6ac2a552fab
BUG: 808003
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.com/3036
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy

core: adding extra data for fops

2012-03-22T23:40:27+00:00

with this change, the xlator APIs will have a dictionary as extra
argument, which is passed between all the layers. This can be
utilized for overloading in some of the operations.

Change-Id: I58a8186b3ef647650280e63f3e5e9b9de7827b40
Signed-off-by: Amar Tumballi 
BUG: 782265
Reviewed-on: http://review.gluster.com/2960
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

features/locks: Make inodelk ref-counted

2012-03-10T10:24:30+00:00

Ref when the object is allocated.
Unref after the response is submitted to that inodelk.

Ref when the lock is granted.
Unref when the lock is unlocked.

Change-Id: I2bfe9182b67bea7dc7b9d0ed9f99f1c7fa0b8a3c
BUG: 783449
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/2891
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

locks: Made dump locks formatting more 'readable'.

2012-02-24T13:13:50+00:00

Also,
Added inode's path to dump locks.
Added basename to entrylk dump output.
Added whence field of range locks to dump output.

Change-Id: Ifd3f8b585a52de7ff68cd54506619ac3eaedeecc
BUG: 789858
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.com/798
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur