glusterfs.git/xlators/features/locks/src/inodelk.c, branch v3.3.2

features/locks: Fix statedump code

2012-08-12T07:12:09+00:00

RCA:
Taking blocking mutex/spin locks lead to dead locks
because of the locking order in statedumps. Also we
were asked to remove gf_logs if possible to avoid extra
cost in signal handlers.

Fix:
changed blocking mutes/spin locks to their non-blocking variants.
Removed gf_logs in locks xlator statedump code-path.

Tests:
State-dump success cases are working fine.
Triggered try-lock failures by putting statedumps in a while loop.
In parallel did chown of the same file in a while loop.

BUG: 843781
Change-Id: Iac9b75d79cd5e036cd3eafc1e106074e2c6b5c47
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/3752
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

core: adding extra data for fops

2012-03-22T23:40:27+00:00

with this change, the xlator APIs will have a dictionary as extra
argument, which is passed between all the layers. This can be
utilized for overloading in some of the operations.

Change-Id: I58a8186b3ef647650280e63f3e5e9b9de7827b40
Signed-off-by: Amar Tumballi 
BUG: 782265
Reviewed-on: http://review.gluster.com/2960
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

features/locks: Avoid race in creating domains

2012-03-21T18:15:15+00:00

Thread:1                 |       Thread:2
-----------------------------------------
1) Does inodelk on inode1| 1) Does inodelk on inode1
2) It tries to get the   | 2) It tries to get the
dom object for the volume| dom object for the volume
volname-replicate-0. But | volname-replicate-0. But
the domain list is empty.| the domain list is empty.
3) Create the new domain |
dom1 and add it to head  |
of the list of domains.  |
4) inodelk happens on    | 3) Create the new domain
dom1 on range r1.        | dom2 and add it to head
                         | of the list of domains.
                         | 4) inodelk happens on dom2 on range r2
5) unlock for r1 comes   | 5) Unlock on r2 succeeds.
on inode1.               |
6) It tries to get the   |
domain, of the inodelk   |
for volume               |
volname-replicate-0, gets|
dom2 but the lock on     |
range r1 is not present  |
so it fails.             |

subsequent inode lock, unlocks will keep happening on the domain dom2.
The stale lock present in the dom1 on range r1 will live on.
It wont cause any hangs, but the statedump will always be scary.

Change-Id: I9adc120d33febf685b30859cc307768c2fc63ae5
BUG: 770080
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/2993
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy 
Reviewed-by: Anand Avati

Logs: Improved logs in lock/unlock execution path

2012-03-18T08:53:41+00:00

Statedump will now start showing the lk-owner of the stack.

Change-Id: I9f650ce9a8b528cd626c8bb595c1bd1050462c86
BUG: 803209
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/2968
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

features/locks: Make inodelk ref-counted

2012-03-10T10:24:30+00:00

Ref when the object is allocated.
Unref after the response is submitted to that inodelk.

Ref when the lock is granted.
Unref when the lock is unlocked.

Change-Id: I2bfe9182b67bea7dc7b9d0ed9f99f1c7fa0b8a3c
BUG: 783449
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/2891
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

features/locks: Don't access free'd memory

2012-02-22T11:26:24+00:00

Change-Id: I4e22ede84622f2c9c46cc0bc9f17bef73afa815c
BUG: 796069
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/2791
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

core: change lk-owner as a 1k buffer

2012-01-25T04:14:17+00:00

so, NLM can send the lk-owner field directly to the locks translators,
while doing the same effort, also enabled sending maximum of 500 aux gid
over protocol.

Change-Id: I87c2514392748416f7ffe21d5154faad2e413969
Signed-off-by: Amar Tumballi 
BUG: 767229
Reviewed-on: http://review.gluster.com/779
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

features/locks: Fix release of locks on disconnect

2011-12-22T13:11:25+00:00

When a disconnect comes on a transport, all the locks on that
transport should be cleared irrespective of entry presence.

Change-Id: I1c432ec1ddc8fe3f7bf236992f47437d0dacd6ae
BUG: 765430
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/808
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy 
Reviewed-by: Vijay Bellur

locks: dump client pid and time of blocking/granting.

2011-09-30T07:50:04+00:00

Change-Id: Icaa919f3009fb70f6af9b95fceaf800f3beca447
BUG: 3662
Reviewed-on: http://review.gluster.com/532
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

features/locks: free the string allocated by inode_path

2011-09-20T05:39:56+00:00

Change-Id: I1b7d4059610713b92c4bb78676c3b48335e3a0fe
BUG: 3468
Reviewed-on: http://review.gluster.com/465
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur