glusterfs.git/xlators/features/changetimerecorder/src/ctr-helper.c, branch v4.1.0

features/changetimerecorder:unused value coverity fix

2017-11-17T16:51:26+00:00

Problem : Overwritting the value of ret in extract_db_params.

Fix : The value is used in out.

Change-Id: Ib7bee999c6f19e0c83ef47deab61835977162bd5
BUG: 789278
Signed-off-by: Subha sree Mohankumar

ctr/sql: Providing for vol set for sqlcachesize and sqlWALsize and skip recording path

2015-12-22T15:14:10+00:00

1. Providing vol set option for cache size and wal autocheck point
   so that performance can be tuned.
2. Removed recording of file path in the db. Trimming database columns.
   Path need not be stored in the db, as PARGFID, GFID, Basename is suffice
   to derive the path during migration.

Change-Id: I2cb590451a6d244bc91fe66c6dbffe2c2059dfb8
BUG: 1293034
Signed-off-by: Joseph Fernandes 
Reviewed-on: http://review.gluster.org/12972
Reviewed-by: N Balachandran 
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Dan Lambright 
Tested-by: Dan Lambright

tier/glusterd : Validation for frequency thresholds and record-counters

2015-12-01T23:39:34+00:00

1) if record-counters is set to off
   check if both the frequency thresholds are non-zero, then pop
   an error message, with volume set failed.
2) if record-counters is set to on
   check if both the frequency thresholds are zero, then pop
   an note, but volume set is not failed.
3) If any of the frequency thresholds are set to a non-zero value,
   switch record-counters on, if not already on
4) If both the frequency thresholds are set to zero,
   switch record-counters off, if not already off

NOTE: In this fix we have
1) removed unnecessary ctr vol set options.
2) changed  ctr_hardlink_heal_expire_period to ctr_lookupheal_link_timeout

Change-Id: Ie7ccfd3f6e021056905a79de5a3d8f199312f315
BUG: 1286346
Signed-off-by: Joseph Fernandes 
Signed-off-by: Dan Lambright 
Reviewed-on: http://review.gluster.org/12780
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System

tier/ctr: Correcting rename logic

2015-11-25T16:21:35+00:00

Problem: When a file with old_file_name and GFID_1 is renamed with a new_file_name
which already exists and with GFID_2, this is what happens in linux internaly.
   a. "new_file_name" is unlinked for GFID_2
   b. a hardlink "new_file_name" is created to GFID_1
   c. "old_file_name" hardlink is unlinked for GFID_2.
Well this is all internal to linux, and gluster just issues a rename system call
at POSIX layer. But CTR Xlator doesn't delete the entries corresponding to the
"new_file_name" and GFID_2. Thus leaving the stale entry in the DB.
The following are the implications.
a. Promotion are tried on these stale entries which will fail and show
false results in the status of migration,
b. GFID_2 Files with 2 hardlinks, which will have only one hardlink
after the rename will not be promoted or demoted as the DB shows 2 entries.

Solution: Delete the older database entry for the replaced hardlink

Change-Id: I4eafa0872253e29ff1f0bec4283bcfc579ecf0e2
BUG: 1284090
Signed-off-by: Joseph Fernandes 
Reviewed-on: http://review.gluster.org/12711
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright 
Tested-by: Dan Lambright

tier/ctr: Providing option to record or ignore metadata heat

2015-11-15T21:47:48+00:00

Currently we heat up a file for both data and metadata write.
Here we provide a ctr xlator option called "ctr-record-metadata-heat"
were the admin can decide on recording metadata heat i.e heatup a
file on metadata writes or not.
Metadata data operation are
a. setattr: explicit changing of atime/mtime using utimes,
            changing of posix permissions of the file
b. rename: Renaming a file,
c. unlink, link: adding or deleting hardlinks
d. xattrs: setting or removal of xattrs.

NOTE: atime, mtime and ctime change through writev, readv, truncate, mknod
and create will not be considered here as these fops are data and primary
metadata fops.

Defaultly "ctr-record-metadata-heat" is off. Admin can
switch it on using gluster volume set command.

Change-Id: I91157509255dd5cb429cda2b6d4f64582e155e7b
BUG: 1279166
Signed-off-by: Joseph Fernandes 
Reviewed-on: http://review.gluster.org/12540
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright 
Tested-by: Dan Lambright

features/ctr: Reduce the log-level for ctr-disabled message

2015-07-09T19:15:17+00:00

Since by default CTR translator is disabled, the following
log message is being displayed in brick logs.

[ctr-helper.c:256:extract_ctr_options] 0-gfdbdatastore: CTR Xlator is disabled.

Therefore this change is to reduce the log-level to INFO.

Change-Id: I3b82d6b0dc0445286f91490fb497167a36914a2b
BUG: 1241379
Signed-off-by: Anoop C S 
Reviewed-on: http://review.gluster.org/11592
Reviewed-by: Joseph Fernandes
Tested-by: Joseph Fernandes
Tested-by: NetBSD Build System

tier/ctr: Ignore creation of T file and Ctr Lookup heal improvememnts

2015-06-26T23:05:20+00:00

1) Ignore creation of T file in ctr_mknod
2) Ignore lookup for T file in ctr_lookup
3) Ctr_lookup:
    a. If the gfid and pgfid in empty dont record
    b. Decreased log level for multiple heal attempts
    c. Inode/File heal happens after an expiry period, which is configurable.
    d. Hardlink heal happens after an expiry period, which is configurable.

Change-Id: Id8eb5092e78beaec22d05f5283645081619e2452
BUG: 1235269
Signed-off-by: Joseph Fernandes 
Reviewed-on: http://review.gluster.org/11334
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright 
Tested-by: Dan Lambright

changetimerecorder : Porting to new logging framework

2015-06-10T08:58:01+00:00

Change-Id: I66e7ccc5e62482c3ecf0aab302568e6c9ecdc05d
BUG: 1194640
Signed-off-by: Mohamed Ashiq 
Reviewed-on: http://review.gluster.org/10938
Tested-by: Gluster Build System 
Reviewed-by: Joseph Fernandes

CTR/Libgfdb: Log typo fix

2015-05-10T07:20:32+00:00

Log typo fix for CTR Xlator and Libgfdb

Change-Id: I8d7208b9756199f8dc0a72771a3c953b4fa00f3f
BUG: 1215896
Signed-off-by: Joseph Fernandes 
Reviewed-on: http://review.gluster.org/10668
Reviewed-by: Dan Lambright 
Reviewed-by: N Balachandran 
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur 
Tested-by: Vijay Bellur

ctr/libgfdb: Performance enhancer for unlink/create/rename/link fops

2015-05-01T16:10:30+00:00

1) ctr_link_consistency option for ctr xaltor is provided so that
   the user can choose to switch it on or off.
   /* For link consistency we do a double update i.e mark the link
   * during the wind and during the unwind we update/delete the link.
   * This has a performance hit. We give a choice here whether we need
   * link consistency to be spoton or not using link_consistency flag.
   * This will have only one link update */

2) In delete the wind time recording is moved to unwind path.
   /* Special performance case:
   * Updating wind time in unwind for delete. This is done here
   * as in the wind path we will not know whether its the last
   * link or not. For a last link there is not use to update any
   * wind or unwind time!*/

Change-Id: I209472fb816f939db4a868b97ba053b028f17ea6
BUG: 1217786
Signed-off-by: Joseph Fernandes 
Reviewed-on: http://review.gluster.org/10170
Reviewed-by: Dan Lambright 
Tested-by: Gluster Build System