glusterfs.git/xlators/features/bit-rot/src/bitd, branch v3.7.9

features / bitrot: Prevent spurious pthread_cond_wait() wakeup

2016-01-28T13:29:08+00:00

        Backport of http://review.gluster.org/13302

pthread_cond_wait() is prone to spurious wakeups and it's utmost
necessarry to check a boolean predicate for thread continuation.

See man(3) pthread_cond_wait() for details.

The following is done in bitrot scrubber:

    if (list_empty (&fsscrub->scrublist))
       pthread_cond_wait (&fsscrub->cond, &fsscrub->mutex);

followed by:

    list_first_entry (&fsscrub->scrublist, ...)

A spurious wakeup from pthread_cond_wait() with the absence of
list_empty() check causes list_first_entry() to return garbage.

BUG: 1302199
Change-Id: I60151eabb8af257a35acd8e7c117876388166a0e
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/13307
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

all: reduce "inline" usage

2016-01-18T09:02:34+00:00

There are three kinds of inline functions: plain inline, extern inline,
and static inline.  All three have been removed from .c files, except
those in "contrib" which aren't our problem.  Inlines in .h files, which
are overwhelmingly "static inline" already, have generally been left
alone.  Over time we should be able to "lower" these into .c files, but
that has to be done in a case-by-case fashion requiring more manual
effort.  This part was easy to do automatically without (as far as I can
tell) any ill effect.

In the process, several pieces of dead code were flagged by the
compiler, and were removed.

backport of Change-Id: I56a5e614735c9e0a6ee420dab949eac22e25c155,
http://review.gluster.org/11769, BUG: 1245331

Change-Id: Iba1efb0bc578ea4a5e9bf76b7bd93dc1be9eba44
BUG: 1283302
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/12646
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos

bitrot: getting correct value of scrub stat's

2015-12-18T03:29:00+00:00

This patch is backport of: http://review.gluster.org/#/c/12776/

When user execute bitrot scrub status command then gluster
is not giving correct value of Number of Scrubbed files,
Number of Unsigned files, Last completed scrub time,
Duration of last scrub.

With this patch scrub status will give correct value for
all the above fields.

  >> Change-Id: Ic966f76d22db5b0c889e6386a1c2219afbda1f49
  >> BUG: 1285989
  >> Signed-off-by: Gaurav Kumar Garg 
  >> Signed-off-by: Kotresh HR 
  >> Reviewed-on: http://review.gluster.org/12776
  >> Tested-by: NetBSD Build System 
  >> Tested-by: Gluster Build System 
  >> Reviewed-by: Venky Shankar 

Change-Id: Ic966f76d22db5b0c889e6386a1c2219afbda1f49
BUG: 1291546
Signed-off-by: Gaurav Kumar Garg 


(cherry picked from commit 22827d51c232c44a8f5ac003529d907d93baf7b0)

Change-Id: Icef24cce35c8d54ffdfa5282491338318e78780b
Reviewed-on: http://review.gluster.org/12966
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Venky Shankar

glusterd/bitrot : Integration of bad files from bitd with scrub status command

2015-11-24T07:40:53+00:00

This patch is backport of: http://review.gluster.org/#/c/12720/

Currently scrub status command is not displaying list of all the bad files. All
the bad files are avaliable in the bitd daemon.

With this patch it will dispaly list of all the bad file's in the scrub
status command.

   >> Change-Id: If09babafaf5d7cf158fa79119abbf5b986027748
   >> BUG: 1207627
   >> Signed-off-by: Gaurav Kumar Garg 


Change-Id: If09babafaf5d7cf158fa79119abbf5b986027748
BUG: 1283881
Signed-off-by: Gaurav Kumar Garg 
Reviewed-on: http://review.gluster.org/12725
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Atin Mukherjee

features/bit-rot: scrubber changes for getting the list of bad objects from stub

2015-11-24T03:56:50+00:00

                  Backport of http://review.gluster.org/12654

> Change-Id: I62885e4aba4a9b345db3c78c3291d563ff3d3567
> BUG: 1207627
> Signed-off-by: Raghavendra Bhat 
> Reviewed-on: http://review.gluster.org/12654
> Tested-by: NetBSD Build System 
> Tested-by: Gluster Build System 
> Reviewed-by: Venky Shankar 
> Signed-off-by: Raghavendra Bhat 

Change-Id: I8e1f04f3f730cbd90bdf3cdc7b2149d0de53ea37
BUG: 1283881
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/12716
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Venky Shankar

glusterd: cli command implementation for bitrot scrub status

2015-11-23T03:53:58+00:00

This patch is backport of: http://review.gluster.org/10231

CLI command  for bitrot scrub status will be :

gluster volume bitrot  scrub status

Above command will show the statistics of bitrot scrubber.

Upon execution of this command it will show some common
scrubber tunable value of volume  followed by
statistics of scrubber statistics of individual nodes.

sample ouput for single node:

Volume name : 

State of scrub: Active

Scrub frequency: biweekly

Bitrot error log location: /var/log/glusterfs/bitd.log

Scrubber error log location: /var/log/glusterfs/scrub.log

=========================================================

Node name:

Number of Scrubbed files:

Number of Unsigned files:

Last completed scrub time:

Duration of last scrub:

Error count:

=========================================================

This is just infrastructure. list of bad file, last scrub
time, error count value will be taken care by
http://review.gluster.org/#/c/12503/  and
http://review.gluster.org/#/c/12654/ patches.

    >> Change-Id: I3ed3c7057c9d0c894233f4079a7f185d90c202d1
    >> BUG: 1207627
    >> Signed-off-by: Gaurav Kumar Garg 
    >> Reviewed-on: http://review.gluster.org/10231
    >> Reviewed-by: Atin Mukherjee 
    >> Tested-by: NetBSD Build System 
    >> Tested-by: Gluster Build System 

Change-Id: I45ed94e5e0e78a1e007c30eb0b252f74cf3c9187
BUG: 1283881
Signed-off-by: Gaurav Kumar Garg 
Reviewed-on: http://review.gluster.org/12704
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Atin Mukherjee

features/bitrot: Fix scrubber frequency set

2015-08-27T09:18:32+00:00

When bitrot is configured on multiple volumes
in a cluster and scrubber-frequency is changed
for one volume, it is resetting frequency for
all other volumes w.r.t to its scrubber-frequency.
This should not happen. Changing scrubber-frequency
should affect only that volume on which it is set.
This patch fixes the issue.

Also restricted the logs to the configure volume.

BUG: 1256669
Change-Id: I6eba385b50b3bdc86bc8f4ef295a004b3b87b68a
Reviewed-on: http://review.gluster.org/11897
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Venky Shankar 
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/12010

features/bitrot: Fix rescheduling scrub-frequency

2015-08-24T04:36:43+00:00

While rescheduling scrub frequency, boot time of
the brick was considered where it is not required
and also delta is calculated using unsigned int
resulting in the loss of fractional part leading to
wrong scrub frequency. Boot time is completely
removed and delta calculation is simplified.

BUG: 1253160
Change-Id: I98dd1fa99304c6d91c0a330dfca7fef57a770397
Reviewed-on: http://review.gluster.org/11853
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Venky Shankar 
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/11904

bitrot: Scrubber log should mark bad file as a ALERT in the scrubber log

2015-08-21T09:39:22+00:00

If bad file detected by scrubber then scrubber should log that bad
file as a ALERT message in scrubber log.

Change-Id: I410429e78fd3768655230ac028fa66f7fc24b938
BUG: 1255605
Signed-off-by: Gaurav Kumar Garg 
Reviewed-on: http://review.gluster.org/11965
Reviewed-by: Raghavendra Bhat 
Tested-by: NetBSD Build System 
(cherry picked from commit 6cb73b4fe798b7bf3aface0aac2a4e6c7c618c0e)
Reviewed-on: http://review.gluster.org/11974
Tested-by: Gluster Build System

features/bitrot: move inode state just at the last moment

2015-07-23T10:16:18+00:00

    Backport of http://review.gluster.org/11461

Which was done at half the set expiry time resulting in actual
IOs incrementing the object version. Now this is done just at
the last moment with re-notification now cut-shorting into
checksum calculation without waiting in the timer-wheel.

BUG: 1242718
Change-Id: If655b77d822ebf7b2a4f65e1b5583dd3609306e7
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/11653
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat